qidaye merged PR #43643:
URL: https://github.com/apache/doris/pull/43643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apach
github-actions[bot] commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2480879368
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2480879361
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2477921639
TeamCity be ut coverage result:
Function Coverage: 37.96% (9903/26090)
Line Coverage: 29.16% (82762/283795)
Region Coverage: 28.29% (42519/150280)
Branch Coverage: 24.8
zzzxl1993 commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2477885467
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zzzxl1993 commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1843144620
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/ApproxTopK.java:
##
@@ -55,9 +55,19 @@ public ApproxTopK(boolean distinct, boolea
zzzxl1993 commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1843143244
##
be/src/vec/aggregate_functions/aggregate_function_approx_top_sum.h:
##
@@ -0,0 +1,245 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
zzzxl1993 commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1843143720
##
be/src/vec/aggregate_functions/aggregate_function.h:
##
@@ -43,7 +43,7 @@ class IDataType;
struct AggregateFunctionAttr {
bool enable_decimal256 {false};
-
doris-robot commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2477006156
TeamCity be ut coverage result:
Function Coverage: 37.96% (9904/26090)
Line Coverage: 29.16% (82764/283794)
Region Coverage: 28.29% (42514/150280)
Branch Coverage: 24.8
zzzxl1993 commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2476739438
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
xiaokang commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1841322880
##
be/src/vec/aggregate_functions/aggregate_function_approx_top_sum.h:
##
@@ -0,0 +1,245 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
zzzxl1993 commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2470546049
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zzzxl1993 commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1838012741
##
regression-test/suites/inverted_index_p0/test_index_approx_top_k.groovy:
##
@@ -88,15 +88,11 @@ suite("test_index_approx_top_k", "p0"){
sql """ set debu
superdiaodiao commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1837990358
##
regression-test/suites/inverted_index_p0/test_index_approx_top_k.groovy:
##
@@ -88,15 +88,11 @@ suite("test_index_approx_top_k", "p0"){
sql """ set
superdiaodiao commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1837990358
##
regression-test/suites/inverted_index_p0/test_index_approx_top_k.groovy:
##
@@ -88,15 +88,11 @@ suite("test_index_approx_top_k", "p0"){
sql """ set
zzzxl1993 commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2470284588
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zzzxl1993 commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2469672434
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zzzxl1993 commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2469450583
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1836869196
##
be/src/vec/aggregate_functions/aggregate_function_approx_top_sum.h:
##
@@ -0,0 +1,245 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+
doris-robot commented on PR #43643:
URL: https://github.com/apache/doris/pull/43643#issuecomment-2468465775
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce
zzzxl1993 opened a new pull request, #43643:
URL: https://github.com/apache/doris/pull/43643
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Tes
21 matches
Mail list logo
