Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-25 Thread via GitHub
yiguolei merged PR #25386: URL: https://github.com/apache/doris/pull/25386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-24 Thread via GitHub
github-actions[bot] commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1778631670 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-24 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1778577565 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.59 seconds stream load tsv: 561 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-24 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1778511583 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-24 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1777687909 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.47 seconds stream load tsv: 558 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-24 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1777492624 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-24 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1777494357 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-24 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1776785813 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-24 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1776729328 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.08 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1776599737 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1776457243 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
jacktengg commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1369469324 ## be/src/exec/schema_scanner.cpp: ## @@ -287,6 +287,12 @@ Status SchemaScanner::fill_dest_column_for_range(vectorized::Block* block, size_ rein

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
Gabriel39 commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1369461827 ## be/src/exec/schema_scanner.cpp: ## @@ -287,6 +287,12 @@ Status SchemaScanner::fill_dest_column_for_range(vectorized::Block* block, size_ rein

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1776316781 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1776316737 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1775763053 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.43 seconds stream load tsv: 557 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1775710155 TeamCity be ut coverage result: Function Coverage: 37.18% (8371/22513) Line Coverage: 29.33% (67467/230015) Region Coverage: 27.86% (35011/125660) Branch Coverage: 24.4

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1775572940 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
jacktengg commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1368357670 ## fe/fe-core/src/main/java/org/apache/doris/nereids/types/DecimalV3Type.java: ## @@ -99,18 +103,49 @@ public static DecimalV3Type createDecimalV3Type(int precision)

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
jacktengg commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1368357670 ## fe/fe-core/src/main/java/org/apache/doris/nereids/types/DecimalV3Type.java: ## @@ -99,18 +103,49 @@ public static DecimalV3Type createDecimalV3Type(int precision)

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-23 Thread via GitHub
jacktengg commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1368318735 ## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java: ## @@ -306,6 +307,10 @@ private void handleQuery(MysqlCommand mysqlCommand) { if (mysq

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-22 Thread via GitHub
morrySnow commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1368173681 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Multiply.java: ## @@ -52,7 +53,12 @@ public DecimalV3Type getDataTypeForDecimalV3(DecimalV3Type

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-22 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1774114786 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-22 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1774098303 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-22 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1774051038 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-21 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1773983159 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-21 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1773901653 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.89 seconds stream load tsv: 551 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-21 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1773892872 TeamCity be ut coverage result: Function Coverage: 37.21% (8378/22513) Line Coverage: 29.37% (67536/229926) Region Coverage: 27.95% (35028/125340) Branch Coverage: 24.5

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-21 Thread via GitHub
github-actions[bot] commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1367772481 ## be/test/vec/data_types/decimal_test.cpp: ## @@ -0,0 +1,212 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-21 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1773870984 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-20 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1772265653 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-20 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1772197714 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.42 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-19 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1772158605 TeamCity be ut coverage result: Function Coverage: 37.13% (8357/22510) Line Coverage: 29.26% (67356/230228) Region Coverage: 27.86% (34941/125425) Branch Coverage: 24.4

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-19 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1772097119 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-19 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1771570663 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.67 seconds stream load tsv: 555 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-19 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1771521058 TeamCity be ut coverage result: Function Coverage: 37.06% (8341/22507) Line Coverage: 29.17% (67135/230174) Region Coverage: 27.78% (34844/125407) Branch Coverage: 24.3

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-19 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1771409591 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1770101629 TeamCity be ut coverage result: Function Coverage: 37.12% (8342/22474) Line Coverage: 29.18% (67123/230020) Region Coverage: 27.80% (34851/125366) Branch Coverage: 24.4

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1364882564 ## be/src/vec/core/decomposed_float.h: ## @@ -0,0 +1,222 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1769885822 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1769749938 TeamCity be ut coverage result: Function Coverage: 37.11% (8340/22474) Line Coverage: 29.17% (67053/229869) Region Coverage: 27.79% (34833/125362) Branch Coverage: 24.3

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1364764778 ## be/src/vec/functions/function_string.h: ## @@ -2423,12 +2423,33 @@ struct MoneyFormatDecimalImpl { frac_part = frac_part * multiplie

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1769729707 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1769198003 TeamCity be ut coverage result: Function Coverage: 37.11% (8340/22474) Line Coverage: 29.17% (67057/229869) Region Coverage: 27.78% (34829/125362) Branch Coverage: 24.3

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1364350250 ## be/src/vec/core/wide_integer.h: ## @@ -0,0 +1,302 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
jacktengg commented on PR #25386: URL: https://github.com/apache/doris/pull/25386#issuecomment-1769084195 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1364289279 ## be/src/vec/core/decomposed_float.h: ## @@ -0,0 +1,201 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1364288519 ## be/src/vec/core/accurate_comparison.h: ## @@ -464,6 +467,114 @@ template inline bool_if_safe_conversion greaterOrEqualsOp(A a, B b) { return a >=

Re: [PR] [feature](decimal) support decimal256 [doris]

2023-10-17 Thread via GitHub
github-actions[bot] commented on code in PR #25386: URL: https://github.com/apache/doris/pull/25386#discussion_r1362537872 ## be/src/olap/rowset/segment_v2/bitshuffle_page.h: ## @@ -267,6 +267,7 @@ inline Status parse_bit_shuffle_header(const Slice& data, size_t& num_elements,

[PR] [feature](decimal) support decimal256 [doris]

2023-10-12 Thread via GitHub
jacktengg opened a new pull request, #25386: URL: https://github.com/apache/doris/pull/25386 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt