Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

ByteYue closed pull request #37537: [feature](Vault) Support alter s3 storage vault using http interface URL: https://github.com/apache/doris/pull/37537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

ByteYue commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2227236675 Included in #37606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

ByteYue commented on code in PR #37537: URL: https://github.com/apache/doris/pull/37537#discussion_r1676845465 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -509,6 +509,80 @@ static void set_default_vault_log_helper(const InstanceInfoPB& instance, LOG(INFO) <<

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

ByteYue commented on code in PR #37537: URL: https://github.com/apache/doris/pull/37537#discussion_r1676845357 ## cloud/src/meta-service/meta_service_http.cpp: ## @@ -449,6 +449,7 @@ void MetaServiceImpl::http(::google::protobuf::RpcController* controller, {"show_s

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

ByteYue commented on code in PR #37537: URL: https://github.com/apache/doris/pull/37537#discussion_r1676845509 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -575,22 +649,20 @@ void MetaServiceImpl::alter_obj_store_info(google::protobuf::RpcController* cont

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

ByteYue commented on code in PR #37537: URL: https://github.com/apache/doris/pull/37537#discussion_r1676845267 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -509,6 +509,80 @@ static void set_default_vault_log_helper(const InstanceInfoPB& instance, LOG(INFO) <<

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

gavinchou commented on code in PR #37537: URL: https://github.com/apache/doris/pull/37537#discussion_r1676840768 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -509,6 +509,80 @@ static void set_default_vault_log_helper(const InstanceInfoPB& instance, LOG(INFO)

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

doris-robot commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2220401768 ClickBench: Total hot run time: 30.68 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

doris-robot commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2220391438 TPC-DS: Total hot run time: 174169 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

doris-robot commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2220363828 TPC-H: Total hot run time: 40308 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

github-actions[bot] commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2220251742 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

ByteYue commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2220246933 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

doris-robot commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2219924790 ClickBench: Total hot run time: 30.89 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

doris-robot commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2219913210 TPC-DS: Total hot run time: 175032 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

doris-robot commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2219885769 TPC-H: Total hot run time: 42663 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feature](Vault) Support alter s3 storage vault using http interface [doris]

ByteYue commented on PR #37537: URL: https://github.com/apache/doris/pull/37537#issuecomment-2219739950 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu