morningman merged PR #42507:
URL: https://github.com/apache/doris/pull/42507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
github-actions[bot] commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2447445108
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2447444997
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439895651
ClickBench: Total hot run time: 32.78 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439894269
TPC-DS: Total hot run time: 191359 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439891427
TPC-H: Total hot run time: 41663 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439891944
TeamCity be ut coverage result:
Function Coverage: 37.46% (9715/25934)
Line Coverage: 28.72% (80573/280506)
Region Coverage: 28.05% (41665/148563)
Branch Coverage: 24.6
hubgeter commented on code in PR #42507:
URL: https://github.com/apache/doris/pull/42507#discussion_r1817990527
##
be/src/util/jvm_metrics.cpp:
##
@@ -90,9 +92,12 @@ JvmMetrics::JvmMetrics(MetricRegistry* registry, JNIEnv*
env) {
break;
}
try {
-
github-actions[bot] commented on code in PR #42507:
URL: https://github.com/apache/doris/pull/42507#discussion_r1817990380
##
be/src/util/jvm_metrics.cpp:
##
@@ -182,193 +189,257 @@ void JvmMetrics::update() {
}
}
-void JvmStats::init(JNIEnv* ENV) {
-env = ENV;
-
hubgeter commented on code in PR #42507:
URL: https://github.com/apache/doris/pull/42507#discussion_r1817989956
##
be/src/util/jvm_metrics.cpp:
##
@@ -182,193 +188,260 @@ void JvmMetrics::update() {
}
}
-void JvmStats::init(JNIEnv* ENV) {
-env = ENV;
-_management
hubgeter commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439869738
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
morningman commented on code in PR #42507:
URL: https://github.com/apache/doris/pull/42507#discussion_r1817974809
##
be/src/util/jvm_metrics.cpp:
##
@@ -90,9 +92,12 @@ JvmMetrics::JvmMetrics(MetricRegistry* registry, JNIEnv*
env) {
break;
}
try {
github-actions[bot] commented on code in PR #42507:
URL: https://github.com/apache/doris/pull/42507#discussion_r1817773962
##
be/src/util/jvm_metrics.cpp:
##
@@ -182,193 +188,260 @@ void JvmMetrics::update() {
}
}
-void JvmStats::init(JNIEnv* ENV) {
-env = ENV;
-
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439564281
TPC-DS: Total hot run time: 191880 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439557021
TPC-H: Total hot run time: 41624 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439568711
ClickBench: Total hot run time: 32.92 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439557691
TeamCity be ut coverage result:
Function Coverage: 37.46% (9714/25934)
Line Coverage: 28.73% (80581/280507)
Region Coverage: 28.04% (41652/148564)
Branch Coverage: 24.6
doris-robot commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439489107
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
hubgeter opened a new pull request, #42507:
URL: https://github.com/apache/doris/pull/42507
## Proposed changes
Because in jni, we need to manually check for exceptions thrown, and if we
do not handle the exception, the program will continue to execute, which is not
like the try catch lo
hubgeter commented on PR #42507:
URL: https://github.com/apache/doris/pull/42507#issuecomment-2439489153
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
20 matches
Mail list logo
