Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-17 Thread via GitHub
doris-robot commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2172543713 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 981a9e58e857e3aa2e2ff0c2927e9d1b04e1cbb4 with default session variables Stream

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-17 Thread via GitHub
doris-robot commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2172536642 ClickBench: Total hot run time: 30.52 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-17 Thread via GitHub
doris-robot commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2172526570 TPC-DS: Total hot run time: 203899 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-17 Thread via GitHub
doris-robot commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2172501237 TPC-H: Total hot run time: 49679 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-17 Thread via GitHub
doris-robot commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2172480218 TeamCity be ut coverage result: Function Coverage: 37.80% (8096/21416) Line Coverage: 29.45% (66143/224607) Region Coverage: 28.93% (34097/117872) Branch Coverage: 24.7

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-17 Thread via GitHub
github-actions[bot] commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2172445434 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-16 Thread via GitHub
zclllyybb commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2172435521 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-16 Thread via GitHub
github-actions[bot] commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2171568885 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-16 Thread via GitHub
github-actions[bot] commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2171560040 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-16 Thread via GitHub
zclllyybb commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2171527098 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-16 Thread via GitHub
doris-robot commented on PR #36357: URL: https://github.com/apache/doris/pull/36357#issuecomment-2171516916 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [branch-2.0](fix) Fix be crash about mark_first/last_n [doris]

2024-06-16 Thread via GitHub
zclllyybb opened a new pull request, #36357: URL: https://github.com/apache/doris/pull/36357 ## Proposed changes Issue Number: close #xxx fix crash when mark_first/last_n gets negative 2nd arg input. and make mark_first/last_n support literal only for 2nd arg i