Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-24 Thread via GitHub
HappenLee merged PR #38193: URL: https://github.com/apache/doris/pull/38193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-24 Thread via GitHub
github-actions[bot] commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2247198528 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-24 Thread via GitHub
github-actions[bot] commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2247198464 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-23 Thread via GitHub
doris-robot commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2246807554 ClickBench: Total hot run time: 30.63 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-23 Thread via GitHub
doris-robot commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2246803102 TPC-DS: Total hot run time: 173092 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-23 Thread via GitHub
doris-robot commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2246793737 TPC-H: Total hot run time: 40473 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-23 Thread via GitHub
HappenLee commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2246779702 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-23 Thread via GitHub
doris-robot commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2245762168 TPC-H: Total hot run time: 39543 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-23 Thread via GitHub
HappenLee commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2245678355 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-23 Thread via GitHub
doris-robot commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2244396663 TPC-H: Total hot run time: 39793 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-22 Thread via GitHub
HappenLee commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2244327635 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-22 Thread via GitHub
doris-robot commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2242464196 TPC-H: Total hot run time: 39843 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-22 Thread via GitHub
doris-robot commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2242262142 TPC-H: Total hot run time: 40225 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-21 Thread via GitHub
github-actions[bot] commented on code in PR #38193: URL: https://github.com/apache/doris/pull/38193#discussion_r1686021632 ## be/src/vec/aggregate_functions/aggregate_function_count_by_enum.h: ## @@ -14,24 +14,61 @@ // KIND, either express or implied. See the License for the

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-21 Thread via GitHub
HappenLee commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2242168847 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-21 Thread via GitHub
doris-robot commented on PR #38193: URL: https://github.com/apache/doris/pull/38193#issuecomment-2242168673 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Refactor](exec) remove the unless file and refactor the agg code [doris]

2024-07-21 Thread via GitHub
HappenLee opened a new pull request, #38193: URL: https://github.com/apache/doris/pull/38193 ## Proposed changes 1. delete the file:be/src/vec/utils/count_by_enum_helpers.hpp 2. move code to:be/src/vec/aggregate_functions/aggregate_function_count_by_enum.h --