Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
HappenLee merged PR #42183: URL: https://github.com/apache/doris/pull/42183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
doris-robot commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425904387 TPC-DS: Total hot run time: 192686 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
doris-robot commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425916263 ClickBench: Total hot run time: 31.92 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
doris-robot commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425889625 TeamCity be ut coverage result: Function Coverage: 37.48% (9709/25902) Line Coverage: 28.75% (80615/280437) Region Coverage: 28.19% (41717/147986) Branch Coverage: 24.7

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
doris-robot commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425878530 TPC-H: Total hot run time: 41377 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425816826 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425816775 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425802772 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
doris-robot commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425794016 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
HappenLee commented on PR #42183: URL: https://github.com/apache/doris/pull/42183#issuecomment-2425794131 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [Refactor](exec) change some unreasonable code in dependency [doris]

2024-10-21 Thread via GitHub
HappenLee opened a new pull request, #42183: URL: https://github.com/apache/doris/pull/42183 ## Proposed changes 1. change api dependency to counted finish dependency to reduce the unless cast 2. change `CountedFinishDependency` from struct to class -- This is an