Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-21 Thread via GitHub
HappenLee merged PR #38172: URL: https://github.com/apache/doris/pull/38172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-21 Thread via GitHub
github-actions[bot] commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241550920 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-21 Thread via GitHub
github-actions[bot] commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241550930 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
doris-robot commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241459779 ClickBench: Total hot run time: 30.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
doris-robot commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241458468 TPC-DS: Total hot run time: 173106 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
doris-robot commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241455243 TPC-H: Total hot run time: 39810 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
HappenLee commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241442019 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
doris-robot commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241259940 ClickBench: Total hot run time: 30.19 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
doris-robot commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241258631 TPC-DS: Total hot run time: 174304 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
doris-robot commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241255656 TPC-H: Total hot run time: 40036 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
github-actions[bot] commented on code in PR #38172: URL: https://github.com/apache/doris/pull/38172#discussion_r1685504197 ## be/src/common/exception.h: ## @@ -19,8 +19,8 @@ #include Review Comment: warning: 'fmt/format.h' file not found [clang-diagnostic-error] ```cp

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
HappenLee commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241210244 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
HappenLee opened a new pull request, #38172: URL: https://github.com/apache/doris/pull/38172 ## Proposed changes 1. Remove the useless code in Exception 2. Use fmt replace the streamstring for performance -- This is an automated message from the Apache Git Servic

Re: [PR] [Refactor](common) refactor the Exception code [doris]

2024-07-20 Thread via GitHub
doris-robot commented on PR #38172: URL: https://github.com/apache/doris/pull/38172#issuecomment-2241210092 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y