Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-20 Thread via GitHub
eldenmoon merged PR #45480: URL: https://github.com/apache/doris/pull/45480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-20 Thread via GitHub
github-actions[bot] commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2556519211 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-19 Thread via GitHub
github-actions[bot] commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2556277410 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-19 Thread via GitHub
eldenmoon commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2556275201 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-19 Thread via GitHub
eldenmoon commented on code in PR #45480: URL: https://github.com/apache/doris/pull/45480#discussion_r1893463441 ## be/src/olap/rowset_builder.cpp: ## @@ -414,19 +415,7 @@ void BaseRowsetBuilder::_build_current_tablet_schema(int64_t index_id,

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-19 Thread via GitHub
eldenmoon commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2556267857 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-19 Thread via GitHub
csun5285 commented on code in PR #45480: URL: https://github.com/apache/doris/pull/45480#discussion_r1893442368 ## be/src/olap/rowset_builder.cpp: ## @@ -414,19 +415,7 @@ void BaseRowsetBuilder::_build_current_tablet_schema(int64_t index_id,

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-17 Thread via GitHub
github-actions[bot] commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2547811047 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-17 Thread via GitHub
eldenmoon commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2547802008 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-16 Thread via GitHub
github-actions[bot] commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2547580969 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-16 Thread via GitHub
eldenmoon commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2547575927 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-16 Thread via GitHub
github-actions[bot] commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2545531309 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-16 Thread via GitHub
eldenmoon commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2545520861 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-16 Thread via GitHub
github-actions[bot] commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2545164019 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-16 Thread via GitHub
eldenmoon commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2545154101 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-16 Thread via GitHub
eldenmoon opened a new pull request, #45480: URL: https://github.com/apache/doris/pull/45480 When update schema with high concurrency, updaing schemas cost is expensive. 1. update schema only when rows is not 0 2. copy_from is expensive, use copy constructor ### What problem does

Re: [PR] [Optimize](Variant) optimize schema update performance [doris]

2024-12-16 Thread via GitHub
Thearas commented on PR #45480: URL: https://github.com/apache/doris/pull/45480#issuecomment-2545153997 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y