koarz commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2255098318
> > > @BiteThet Will the modifications be synchronized to 2.1.5
> >
> >
> > Already included
>
> The position of line 235 in the function_string. h file in 2.1.5 is
inc
BiteThet commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247436123
@koarz hi, could you help me answer the question? I'm not very get familiar
with new logic
--
This is an automated message from the Apache Git Service.
To respond to the message, p
yanyxin commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247427109
> > > The code 2.1.5 and master in this regard should be the same. Can you
provide a specific example to illustrate the problem of wrong results?
> >
> >
> > select substr('老人年轻
yanyxin commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247399654
> > > The code 2.1.5 and master in this regard should be the same. Can you
provide a specific example to illustrate the problem of wrong results?
> >
> >
> > select substr('老人年轻
BiteThet commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247362184
> > The code 2.1.5 and master in this regard should be the same. Can you
provide a specific example to illustrate the problem of wrong results?
>
> select substr('老人年轻并不等于动的金币第
yanyxin commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247334457
> The code 2.1.5 and master in this regard should be the same. Can you
provide a specific example to illustrate the problem of wrong results?
select substr('老人年轻并不等于动的金币第七十二',17);
BiteThet commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247287758
> > > @BiteThet Will the modifications be synchronized to 2.1.5
> >
> >
> > Already included
>
> The position of line 235 in the function_string. h file in 2.1.5
yanyxin commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247278581
> > @BiteThet Will the modifications be synchronized to 2.1.5
>
> Already included
The position of line 235 in the function_string. h file in 2.1.5 is
inconsi
BiteThet commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247227365
> @BiteThet Will the modifications be synchronized to 2.1.5
Already included
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
yanyxin commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-2247174047
@BiteThet Will the modifications be synchronized to 2.1.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
HappenLee merged PR #29799:
URL: https://github.com/apache/doris/pull/29799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
doris-robot commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1885014616
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 1aaebfa423e117854be6701404451afd7ea5f9a3 with
default session variables
Stream
doris-robot commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1885009293
TeamCity be ut coverage result:
Function Coverage: 36.69% (8654/23584)
Line Coverage: 28.73% (70472/245297)
Region Coverage: 27.67% (36432/131678)
Branch Coverage: 24.3
doris-robot commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1885008933
ClickBench: Total hot run time: 30.97 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1885004126
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.82 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1884998577
TPC-DS: Total hot run time: 178536 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1884976844
TPC-H: Total hot run time: 38933 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1884881514
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1884881437
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1884878309
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
BiteThet commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1884865782
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1884513909
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
BiteThet commented on PR #29799:
URL: https://github.com/apache/doris/pull/29799#issuecomment-1884501198
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
BiteThet opened a new pull request, #29799:
URL: https://github.com/apache/doris/pull/29799
## Proposed changes
optimization for substr with ascii string
select count(substr(l_comment, 1, 10)) from lineitem;
32s ->7s
## Further comments
If this is a relatively large
24 matches
Mail list logo