Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-12 Thread via GitHub
wangbo merged PR #45284: URL: https://github.com/apache/doris/pull/45284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-12 Thread via GitHub
github-actions[bot] commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2538958811 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-12 Thread via GitHub
github-actions[bot] commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2538958642 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-12 Thread via GitHub
wangbo commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2538355747 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-12 Thread via GitHub
github-actions[bot] commented on code in PR #45284: URL: https://github.com/apache/doris/pull/45284#discussion_r1881693680 ## be/test/util/cgroup_util_test.cpp: ## @@ -87,4 +87,94 @@ TEST_F(CGroupUtilTest, memlimit) { } } +TEST_F(CGroupUtilTest, readcpu) { Review Commen

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-11 Thread via GitHub
yiguolei commented on code in PR #45284: URL: https://github.com/apache/doris/pull/45284#discussion_r1881305428 ## be/test/util/cgroup_util_test.cpp: ## @@ -87,4 +87,35 @@ TEST_F(CGroupUtilTest, memlimit) { } } +TEST_F(CGroupUtilTest, readcpu) { +std::string dir_path

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-11 Thread via GitHub
yiguolei commented on code in PR #45284: URL: https://github.com/apache/doris/pull/45284#discussion_r1881305428 ## be/test/util/cgroup_util_test.cpp: ## @@ -87,4 +87,35 @@ TEST_F(CGroupUtilTest, memlimit) { } } +TEST_F(CGroupUtilTest, readcpu) { +std::string dir_path

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-11 Thread via GitHub
doris-robot commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2536060968 TeamCity be ut coverage result: Function Coverage: 38.75% (10105/26076) Line Coverage: 29.69% (84807/285601) Region Coverage: 28.76% (43531/151384) Branch Coverage: 25.

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-11 Thread via GitHub
wangbo commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2535824433 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-11 Thread via GitHub
github-actions[bot] commented on code in PR #45284: URL: https://github.com/apache/doris/pull/45284#discussion_r1880079008 ## be/src/util/cgroup_util.cpp: ## @@ -264,4 +268,136 @@ void CGroupUtil::read_int_metric_from_cgroup_file( } } +Status CGroupUtil::read_string_line

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-11 Thread via GitHub
github-actions[bot] commented on code in PR #45284: URL: https://github.com/apache/doris/pull/45284#discussion_r1880044835 ## be/src/util/cgroup_util.cpp: ## @@ -264,4 +268,136 @@ void CGroupUtil::read_int_metric_from_cgroup_file( } } +Status CGroupUtil::read_string_line

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-11 Thread via GitHub
doris-robot commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2535295989 TeamCity be ut coverage result: Function Coverage: 38.75% (10104/26072) Line Coverage: 29.69% (84747/285440) Region Coverage: 28.77% (43515/151267) Branch Coverage: 25.

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-10 Thread via GitHub
github-actions[bot] commented on code in PR #45284: URL: https://github.com/apache/doris/pull/45284#discussion_r1879503338 ## be/src/util/cgroup_util.cpp: ## @@ -264,4 +268,126 @@ void CGroupUtil::read_int_metric_from_cgroup_file( } } +Status CGroupUtil::read_string_line

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-10 Thread via GitHub
wangbo commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2534110849 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improment]add be avail cpu num metric [doris]

2024-12-10 Thread via GitHub
doris-robot commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2534102643 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce

[PR] [Improment]add be avail cpu num metric [doris]

2024-12-10 Thread via GitHub
wangbo opened a new pull request, #45284: URL: https://github.com/apache/doris/pull/45284 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note 1 Add doris_be_avail_cpu_num metric. 2 make be conf