Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-12 Thread via GitHub
gavinchou merged PR #43544: URL: https://github.com/apache/doris/pull/43544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-12 Thread via GitHub
github-actions[bot] commented on PR #43544: URL: https://github.com/apache/doris/pull/43544#issuecomment-2470753998 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-12 Thread via GitHub
github-actions[bot] commented on PR #43544: URL: https://github.com/apache/doris/pull/43544#issuecomment-2470753866 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-12 Thread via GitHub
github-actions[bot] commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1835711641 ## cloud/src/meta-service/meta_service_helper.h: ## @@ -19,7 +19,9 @@ #include Review Comment: warning: 'brpc/controller.h' file not found [clang-di

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-12 Thread via GitHub
github-actions[bot] commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1836907911 ## cloud/test/meta_service_http_test.cpp: ## @@ -1456,4 +1456,83 @@ } } +TEST(MetaServiceHttpTest, get_stage_response_sk) { +auto sp = SyncPoint

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-12 Thread via GitHub
github-actions[bot] commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1836856777 ## cloud/test/meta_service_http_test.cpp: ## @@ -1456,4 +1456,45 @@ TEST(MetaServiceHttpTest, TxnLazyCommit) { } } +TEST(MetaServiceHttpTest, stage_

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-12 Thread via GitHub
Yukang-Lian commented on PR #43544: URL: https://github.com/apache/doris/pull/43544#issuecomment-2470541008 run cloudut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-12 Thread via GitHub
Yukang-Lian commented on PR #43544: URL: https://github.com/apache/doris/pull/43544#issuecomment-2469850838 run cloudut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-11 Thread via GitHub
Yukang-Lian commented on PR #43544: URL: https://github.com/apache/doris/pull/43544#issuecomment-2468558653 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-11 Thread via GitHub
github-actions[bot] commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1836907911 ## cloud/test/meta_service_http_test.cpp: ## @@ -1456,4 +1456,83 @@ } } +TEST(MetaServiceHttpTest, get_stage_response_sk) { +auto sp = SyncPoint

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-11 Thread via GitHub
Yukang-Lian commented on PR #43544: URL: https://github.com/apache/doris/pull/43544#issuecomment-2468533593 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-11 Thread via GitHub
github-actions[bot] commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1836856777 ## cloud/test/meta_service_http_test.cpp: ## @@ -1456,4 +1456,45 @@ TEST(MetaServiceHttpTest, TxnLazyCommit) { } } +TEST(MetaServiceHttpTest, stage_

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-11 Thread via GitHub
gavinchou commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1836568283 ## cloud/src/meta-service/meta_service_helper.h: ## @@ -101,7 +116,25 @@ void finish_rpc(std::string_view func_name, brpc::Controller* ctrl, Response* re LO

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-11 Thread via GitHub
gavinchou commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1836568283 ## cloud/src/meta-service/meta_service_helper.h: ## @@ -101,7 +116,25 @@ void finish_rpc(std::string_view func_name, brpc::Controller* ctrl, Response* re LO

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-11 Thread via GitHub
gavinchou commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1836561937 ## cloud/src/meta-service/meta_service_helper.h: ## @@ -101,7 +116,25 @@ void finish_rpc(std::string_view func_name, brpc::Controller* ctrl, Response* re LO

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-10 Thread via GitHub
Yukang-Lian commented on PR #43544: URL: https://github.com/apache/doris/pull/43544#issuecomment-2467355112 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-10 Thread via GitHub
github-actions[bot] commented on code in PR #43544: URL: https://github.com/apache/doris/pull/43544#discussion_r1835711641 ## cloud/src/meta-service/meta_service_helper.h: ## @@ -19,7 +19,9 @@ #include Review Comment: warning: 'brpc/controller.h' file not found [clang-di

Re: [PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-10 Thread via GitHub
doris-robot commented on PR #43544: URL: https://github.com/apache/doris/pull/43544#issuecomment-2466759726 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce

[PR] [Fix](sk) All sk in log should be encrypted [doris]

2024-11-10 Thread via GitHub
Yukang-Lian opened a new pull request, #43544: URL: https://github.com/apache/doris/pull/43544 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author)