Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-22 Thread via GitHub
xiaokang commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1774368364 There is no DiskUtils.java in branch-2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-18 Thread via GitHub
JNSimba merged PR #25565: URL: https://github.com/apache/doris/pull/25565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apac

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1768673568 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.13 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-18 Thread via GitHub
CalvinKirs commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1768469071 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-18 Thread via GitHub
CalvinKirs commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1768063955 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
adonis0147 commented on code in PR #25565: URL: https://github.com/apache/doris/pull/25565#discussion_r136755 ## fe/fe-common/src/main/java/org/apache/doris/common/io/DiskUtils.java: ## @@ -46,52 +44,83 @@ public static Df df(String dir) { return df; }

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
github-actions[bot] commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1767779445 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
github-actions[bot] commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1767779531 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
CalvinKirs commented on code in PR #25565: URL: https://github.com/apache/doris/pull/25565#discussion_r1363331516 ## fe/fe-common/src/main/java/org/apache/doris/common/io/DiskUtils.java: ## @@ -46,52 +44,83 @@ public static Df df(String dir) { return df; }

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
adonis0147 commented on code in PR #25565: URL: https://github.com/apache/doris/pull/25565#discussion_r1363297791 ## fe/fe-common/src/main/java/org/apache/doris/common/io/DiskUtils.java: ## @@ -46,52 +44,83 @@ public static Df df(String dir) { return df; }

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
adonis0147 commented on code in PR #25565: URL: https://github.com/apache/doris/pull/25565#discussion_r1363286614 ## fe/fe-common/src/main/java/org/apache/doris/common/io/DiskUtils.java: ## @@ -46,52 +44,83 @@ public static Df df(String dir) { return df; }

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
adonis0147 commented on code in PR #25565: URL: https://github.com/apache/doris/pull/25565#discussion_r1363286614 ## fe/fe-common/src/main/java/org/apache/doris/common/io/DiskUtils.java: ## @@ -46,52 +44,83 @@ public static Df df(String dir) { return df; }

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
doris-robot commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1767691856 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 49.64 seconds stream load tsv: 556 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
CalvinKirs commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1767660974 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
CalvinKirs commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1767648318 run P0 FEUT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
doris-robot commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1767625830 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.18 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
CalvinKirs commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1767598263 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
CalvinKirs commented on PR #25565: URL: https://github.com/apache/doris/pull/25565#issuecomment-1767592777 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] [Fix](show-frontends-disk)Fix NPE and macOS compatibility [doris]

2023-10-17 Thread via GitHub
CalvinKirs opened a new pull request, #25565: URL: https://github.com/apache/doris/pull/25565 ## Proposed changes **env macOS** **SQL:** ``` show frontends disks``` **exception** ```log 2023-10-18 10:18:03,360 WARN (mysql-nio-pool-12|2513) [StmtExecutor