Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
airborne12 merged PR #41127: URL: https://github.com/apache/doris/pull/41127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
github-actions[bot] commented on PR #41127: URL: https://github.com/apache/doris/pull/41127#issuecomment-2367762974 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
github-actions[bot] commented on PR #41127: URL: https://github.com/apache/doris/pull/41127#issuecomment-2367763078 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
doris-robot commented on PR #41127: URL: https://github.com/apache/doris/pull/41127#issuecomment-2367477162 ClickBench: Total hot run time: 32.93 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
doris-robot commented on PR #41127: URL: https://github.com/apache/doris/pull/41127#issuecomment-2367465165 TPC-DS: Total hot run time: 195263 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
doris-robot commented on PR #41127: URL: https://github.com/apache/doris/pull/41127#issuecomment-2367440199 TPC-H: Total hot run time: 41651 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
airborne12 commented on code in PR #41127: URL: https://github.com/apache/doris/pull/41127#discussion_r1770892332 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java: ## @@ -136,7 +137,8 @@ public List buildRules() {

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
englefly commented on code in PR #41127: URL: https://github.com/apache/doris/pull/41127#discussion_r1770870663 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java: ## @@ -136,7 +137,8 @@ public List buildRules() {

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
englefly commented on code in PR #41127: URL: https://github.com/apache/doris/pull/41127#discussion_r1770870663 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java: ## @@ -136,7 +137,8 @@ public List buildRules() {

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-23 Thread via GitHub
englefly commented on code in PR #41127: URL: https://github.com/apache/doris/pull/41127#discussion_r1770870663 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java: ## @@ -136,7 +137,8 @@ public List buildRules() {

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-22 Thread via GitHub
airborne12 commented on PR #41127: URL: https://github.com/apache/doris/pull/41127#issuecomment-2367369034 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-22 Thread via GitHub
doris-robot commented on PR #41127: URL: https://github.com/apache/doris/pull/41127#issuecomment-2367368905 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Fix](inverted index) fix wrong opt for count_on_index [doris]

2024-09-22 Thread via GitHub
airborne12 opened a new pull request, #41127: URL: https://github.com/apache/doris/pull/41127 ## Proposed changes The pushdownCountOnIndex optimization rule in AggregateStrategies was incorrectly applied to COUNT functions with complex child expressions, such as COUNT(CASE WHEN ...).