morrySnow merged PR #37616:
URL: https://github.com/apache/doris/pull/37616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
github-actions[bot] commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2227837764
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2227837717
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
LiBinfeng-01 commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2227591094
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224987950
ClickBench: Total hot run time: 31.01 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224980214
TPC-DS: Total hot run time: 174231 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224964023
TPC-H: Total hot run time: 39953 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
LiBinfeng-01 commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224935744
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
xzj7019 commented on code in PR #37616:
URL: https://github.com/apache/doris/pull/37616#discussion_r1675388337
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java:
##
@@ -405,6 +405,11 @@ public Expression visitOr(Or or, Expressi
doris-robot commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224847141
ClickBench: Total hot run time: 30.22 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224832291
TPC-DS: Total hot run time: 174432 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224802739
TPC-H: Total hot run time: 39787 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
LiBinfeng-01 commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224679066
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
LiBinfeng-01 commented on code in PR #37616:
URL: https://github.com/apache/doris/pull/37616#discussion_r1675200592
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java:
##
@@ -405,6 +405,11 @@ public Expression visitOr(Or or, Exp
LiBinfeng-01 commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2224418750
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
LiBinfeng-01 commented on code in PR #37616:
URL: https://github.com/apache/doris/pull/37616#discussion_r1675195770
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##
Review Comment:
it was a mistake, fixed
##
fe/fe-core
xzj7019 commented on code in PR #37616:
URL: https://github.com/apache/doris/pull/37616#discussion_r1674823220
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java:
##
@@ -405,6 +405,11 @@ public Expression visitOr(Or or, Expressi
morrySnow commented on code in PR #37616:
URL: https://github.com/apache/doris/pull/37616#discussion_r1674232666
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java:
##
@@ -405,6 +405,11 @@ public Expression visitOr(Or or, Expres
morrySnow commented on code in PR #37616:
URL: https://github.com/apache/doris/pull/37616#discussion_r1674229715
##
regression-test/data/nereids_hint_tpcds_p0/shape/query2.out:
##
@@ -0,0 +1,39 @@
+-- This file is automatically generated. You should know what you did if you
wan
LiBinfeng-01 commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2220077101
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
LiBinfeng-01 opened a new pull request, #37616:
URL: https://github.com/apache/doris/pull/37616
Problem:
When evaluating like function using fe, it can not evaluating nullliteral
correctly
Reason:
Fe fold constant does not deal with like function
Solved:
Add fe fold constant o
doris-robot commented on PR #37616:
URL: https://github.com/apache/doris/pull/37616#issuecomment-2220077029
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
22 matches
Mail list logo
