Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-08 Thread via GitHub
eldenmoon commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2277012607 not merge 2.0, reason 1. behavior change 2. no user encountered only in variant cases -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-07 Thread via GitHub
xiaokang merged PR #38683: URL: https://github.com/apache/doris/pull/38683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-07 Thread via GitHub
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2272762274 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2271582467 ClickBench: Total hot run time: 30.01 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2271571115 TPC-DS: Total hot run time: 169697 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2271547832 TPC-H: Total hot run time: 41467 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2271514659 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
eldenmoon commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2271499000 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2270860220 ClickBench: Total hot run time: 30.02 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2270848994 TPC-DS: Total hot run time: 169965 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2270826844 TPC-H: Total hot run time: 42098 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2270757955 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2270731832 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
eldenmoon commented on code in PR #38683: URL: https://github.com/apache/doris/pull/38683#discussion_r1705147644 ## be/src/vec/functions/function_cast.h: ## @@ -856,12 +856,19 @@ struct ConvertImplFromJsonb { res[i] = 0; continue;

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
eldenmoon commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2270716564 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-06 Thread via GitHub
xiaokang commented on code in PR #38683: URL: https://github.com/apache/doris/pull/38683#discussion_r1705106872 ## be/src/vec/functions/function_cast.h: ## @@ -856,12 +856,19 @@ struct ConvertImplFromJsonb { res[i] = 0; continue;

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262930763 ClickBench: Total hot run time: 30.53 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262919792 TPC-DS: Total hot run time: 168113 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262899453 TPC-H: Total hot run time: 41588 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262870781 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
eldenmoon commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262859510 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262598204 ClickBench: Total hot run time: 30.63 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262587483 TPC-DS: Total hot run time: 169230 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262561938 TPC-H: Total hot run time: 41358 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262395994 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
eldenmoon commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262370842 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262248651 ClickBench: Total hot run time: 30.2 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262239111 TPC-DS: Total hot run time: 169501 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262220483 TPC-H: Total hot run time: 41330 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-07-31 Thread via GitHub
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262169765 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-07-31 Thread via GitHub
eldenmoon commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262161734 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](Json) fix some cast issue [doris]

2024-07-31 Thread via GitHub
doris-robot commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2262160427 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Fix](Json) fix some cast issue [doris]

2024-07-31 Thread via GitHub
eldenmoon opened a new pull request, #38683: URL: https://github.com/apache/doris/pull/38683 1. casting to boolean/double type should consider all numeric types including int , double and boolean 2. casting to floating point type should consisder boolean types and int types ## Pro