yiguolei merged PR #38746:
URL: https://github.com/apache/doris/pull/38746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
github-actions[bot] commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2287628774
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2286723758
ClickBench: Total hot run time: 30.54 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2286714588
TPC-DS: Total hot run time: 191288 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2286691732
TPC-H: Total hot run time: 40337 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2286493406
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
wangbo commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2285195689
@Vallishp please resolve conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2282228258
ClickBench: Total hot run time: 30.24 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2282226635
TPC-DS: Total hot run time: 201740 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-228767
TPC-H: Total hot run time: 39633 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2282196109
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2275124568
TPC-H: Total hot run time: 39597 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2275090601
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2275056886
> what's the difference between table_options and table_properties? #34384
we have moved properties to new table table_properties and print each
property and its value in a new ro
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2275044255
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Vallishp commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1708726773
##
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##
@@ -1084,18 +1103,62 @@ private static TFetchSchemaTableDataResult
tableOptionsM
Vallishp commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1708726095
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -184,6 +177,41 @@ suite("test_table_options") {
);
"""
-qt_select """sel
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2275010378
TPC-H: Total hot run time: 40037 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
yiguolei commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1708627297
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -184,6 +177,41 @@ suite("test_table_options") {
);
"""
-qt_select """sel
yiguolei commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1708625294
##
be/src/exec/schema_scanner/schema_table_options_scanner.cpp:
##
@@ -103,6 +126,17 @@ Status SchemaTableOptionsScanner::get_block_from_fe() {
return Status::OK(
yiguolei commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1708623441
##
be/src/exec/schema_scanner/schema_table_options_scanner.cpp:
##
@@ -103,6 +126,17 @@ Status SchemaTableOptionsScanner::get_block_from_fe() {
return Status::OK(
github-actions[bot] commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1708600444
##
be/src/exec/schema_scanner/schema_table_options_scanner.cpp:
##
@@ -127,7 +164,9 @@
RETURN_IF_ERROR(mblock.add_rows(_tableoptions_block.get(), _row_
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2274935720
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
yiguolei commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2270996551
what's the difference between table_options and table_properties?
https://github.com/apache/doris/pull/34384
--
This is an automated message from the Apache Git Service.
To respond to
morningman commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1704999698
##
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##
@@ -1084,18 +1103,62 @@ private static TFetchSchemaTableDataResult
tableOption
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2269847101
ClickBench: Total hot run time: 30.65 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2269837800
TPC-DS: Total hot run time: 169421 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2269818987
TPC-H: Total hot run time: 41944 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
dataroaring commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2269639132
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2268577369
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2268527581
run build all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Vallishp commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1703771258
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -185,5 +178,32 @@ suite("test_table_options") {
"""
qt_select """select * from i
Vallishp commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1703719129
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -185,5 +178,32 @@ suite("test_table_options") {
"""
qt_select """select * from i
wangbo commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1703707073
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -185,5 +178,32 @@ suite("test_table_options") {
"""
qt_select """select * from inf
wangbo commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1703706188
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -185,5 +178,32 @@ suite("test_table_options") {
"""
qt_select """select * from inf
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2268414821
> please add auth check: 1 create user without any tables's priv, then it
can see no table. 2 grant select priv to this user, then it can see the table's
prop. 3 revoke select priv to th
wangbo commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2268087327
please add auth check:
1 create user without any tables's priv, then it can see no table.
2 grant select priv to this user, then it can see the table's prop.
3 revoke select priv to
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267414099
ClickBench: Total hot run time: 30.17 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267410696
TPC-DS: Total hot run time: 169794 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267404647
TPC-H: Total hot run time: 41485 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267373450
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267300143
ClickBench: Total hot run time: 30.52 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267298485
TPC-DS: Total hot run time: 170316 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267294865
TPC-H: Total hot run time: 41965 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267260141
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267260137
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
dataroaring commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2267259872
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2266047103
> 1 column order should be
`TABLE_CATALOG,TABLE_SCHEMA,TABLE_NAME,PROPERTY_NAME,PROPERTY_VALUE`, just like
mysql. 2 A user can only see the table properties which he has priv to visit,
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2266046350
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
dataroaring commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2265410452
Please add doc in apache/doris-websites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
wangbo commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2264742964
1 column order should be
```TABLE_CATALOG,TABLE_SCHEMA,TABLE_NAME,PROPERTY_NAME,PROPERTY_VALUE```, just
like mysql.
2 A user can only see the table properties which he has priv to visit
wangbo commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1701406517
##
regression-test/suites/query_p0/system/test_table_properties.groovy:
##
@@ -0,0 +1,190 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
wangbo commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1701405586
##
regression-test/suites/query_p0/system/test_table_properties.groovy:
##
@@ -0,0 +1,190 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2264127102
ClickBench: Total hot run time: 30.36 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2264120927
TPC-DS: Total hot run time: 168548 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2264107225
TPC-H: Total hot run time: 41911 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1700813082
##
be/src/exec/schema_scanner/schema_table_properties_scanner.cpp:
##
@@ -0,0 +1,129 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// o
Vallishp commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2263930647
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #38746:
URL: https://github.com/apache/doris/pull/38746#issuecomment-2263928111
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
Vallishp opened a new pull request, #38746:
URL: https://github.com/apache/doris/pull/38746
## Proposed changes
Issue Number: close #38745
added table_properties schema table, with displaying property info in
multiple rows.
