Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
doris-robot commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1923175291 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 60f26053dabd2d1d885e6015be869c29130e0afb with default session variables Stream

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
doris-robot commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1923166678 ClickBench: Total hot run time: 30.04 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
doris-robot commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1923145698 TPC-DS: Total hot run time: 174309 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
doris-robot commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1923098585 TPC-H: Total hot run time: 36492 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
doris-robot commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1923086314 TeamCity be ut coverage result: Function Coverage: 36.15% (8624/23859) Line Coverage: 28.19% (70506/250150) Region Coverage: 27.19% (36383/133788) Branch Coverage: 23.9

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
koarz commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1922986976 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
github-actions[bot] commented on code in PR #30743: URL: https://github.com/apache/doris/pull/30743#discussion_r1475591824 ## be/src/vec/functions/function_string.h: ## @@ -1431,6 +1430,103 @@ class FunctionStringRepeat : public IFunction { String get_name() const override

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
koarz commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1922937064 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
github-actions[bot] commented on code in PR #30743: URL: https://github.com/apache/doris/pull/30743#discussion_r1475565247 ## be/src/vec/functions/function_string.h: ## @@ -1431,6 +1431,103 @@ String get_name() const override { return name; } size_t get_number_of_argum

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
github-actions[bot] commented on code in PR #30743: URL: https://github.com/apache/doris/pull/30743#discussion_r1475540302 ## be/src/vec/functions/function_string.h: ## @@ -2166,6 +2166,257 @@ static constexpr auto name = "split_by_string"; static FunctionPtr create(

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
koarz commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1922817066 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
doris-robot commented on PR #30743: URL: https://github.com/apache/doris/pull/30743#issuecomment-1922816798 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Enhancement](fuction) change some string function nullable mode [doris]

2024-02-01 Thread via GitHub
koarz opened a new pull request, #30743: URL: https://github.com/apache/doris/pull/30743 ## Proposed changes Issue Number: #27435 change some string function nullable mode ## Further comments If this is a relatively large or complex change, kick off the d