Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-22 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2429028300 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-21 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2428380206 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on code in PR #42046: URL: https://github.com/apache/doris/pull/42046#discussion_r1808993196 ## be/src/vec/common/hash_table/ph_hash_set.h: ## @@ -0,0 +1,111 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on code in PR #42046: URL: https://github.com/apache/doris/pull/42046#discussion_r1808984313 ## be/src/vec/common/hash_table/ph_hash_set.h: ## @@ -0,0 +1,111 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-21 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2426916062 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on code in PR #42046: URL: https://github.com/apache/doris/pull/42046#discussion_r1808494078 ## be/src/vec/common/hash_table/ph_hash_set.h: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-21 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2426235584 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-18 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2421858956 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-18 Thread via GitHub
github-actions[bot] commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2421872771 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
github-actions[bot] commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2421450538 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2421443951 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
github-actions[bot] commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419922039 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419907135 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
github-actions[bot] commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419669070 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419651219 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
github-actions[bot] commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419484611 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419468224 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
github-actions[bot] commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419175119 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
github-actions[bot] commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419174860 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
BiteThet commented on PR #42046: URL: https://github.com/apache/doris/pull/42046#issuecomment-2419162760 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Chore](hash-table) unify initialization of HashTableVariants [doris]

2024-10-17 Thread via GitHub
BiteThet opened a new pull request, #42046: URL: https://github.com/apache/doris/pull/42046 ## Proposed changes use init_hash_method to initialize agg/partition_sort/join/set's HashTableVariants -- This is an automated message from the Apache Git Service. To respond to the message,