Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109418827 TeamCity be ut coverage result: Function Coverage: 35.67% (8981/25180) Line Coverage: 27.33% (74259/271737) Region Coverage: 26.56% (38362/18) Branch Coverage: 23.3

(doris) branch branch-2.1 updated: [faultinjection](test) add some fault injection in pipeline task method

2024-05-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 27d88b39834 [faultinjection](test) add

[I] [Bug] notify new FE type transfer: UNKNOWN [doris]

2024-05-13 Thread via GitHub
huangzhengshun opened a new issue, #34821: URL: https://github.com/apache/doris/issues/34821 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.1.2 ###

Re: [PR] [Enhancement](function) Support Overlay function [doris]

2024-05-13 Thread via GitHub
koarz commented on PR #33243: URL: https://github.com/apache/doris/pull/33243#issuecomment-2109412576 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(doris) branch branch-3.0 updated: Pick "[fix](SegComp) Don't call file writer close multi times for segcompaction #34818" (#34820)

2024-05-13 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new cf5c666b949 Pick "[fix](SegComp) Don

Re: [PR] [Fix] Fix clang-18 and libc++ compile problems [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34715: URL: https://github.com/apache/doris/pull/34715#issuecomment-2109411338 TPC-H: Total hot run time: 40660 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] Pick "[fix](SegComp) Don't call file writer close multi times for segcompaction #34818" [doris]

2024-05-13 Thread via GitHub
dataroaring merged PR #34820: URL: https://github.com/apache/doris/pull/34820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] Pick "[fix](SegComp) Don't call file writer close multi times for segcompaction #34818" [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34820: URL: https://github.com/apache/doris/pull/34820#issuecomment-2109409989 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] Pick "[fix](SegComp) Don't call file writer close multi times for segcompaction #34818" [doris]

2024-05-13 Thread via GitHub
ByteYue opened a new pull request, #34820: URL: https://github.com/apache/doris/pull/34820 ## Proposed changes Issue Number: close #xxx same as master #34818 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d

Re: [PR] [feature](compaction) support vertical_compaction & ordered_data_compaction [doris]

2024-05-13 Thread via GitHub
zhangm365 commented on PR #14524: URL: https://github.com/apache/doris/pull/14524#issuecomment-2109409220 Hello, is the param `enable_vertical_compaction` default setting to true? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109406469 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [opt](Nereids) do not do precision merge, when not use wildcard decimalV3 in signature [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34819: URL: https://github.com/apache/doris/pull/34819#issuecomment-2109402282 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [opt](Nereids) do not do precision merge, when not use wildcard decimalV3 in signature [doris]

2024-05-13 Thread via GitHub
morrySnow commented on PR #34819: URL: https://github.com/apache/doris/pull/34819#issuecomment-2109402302 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhancement](profile) Store profile on disk so that we can hold more profile in memory [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on PR #33690: URL: https://github.com/apache/doris/pull/33690#issuecomment-2109397183 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [fix](SegComp) Don't call file writer close multi times for segcompaction [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34818: URL: https://github.com/apache/doris/pull/34818#issuecomment-2109397669 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](exec-version) set min_be_exec_version from 0 to 3 [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on code in PR #34653: URL: https://github.com/apache/doris/pull/34653#discussion_r1599456694 ## be/src/agent/be_exec_version_manager.h: ## @@ -20,23 +20,23 @@ #include Review Comment: warning: 'fmt/format.h' file not found [clang-diagnostic-er

Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-13 Thread via GitHub
BePPPower commented on PR #34422: URL: https://github.com/apache/doris/pull/34422#issuecomment-2109395623 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-13 Thread via GitHub
BePPPower commented on code in PR #34422: URL: https://github.com/apache/doris/pull/34422#discussion_r1599456341 ## fe/fe-core/src/main/java/org/apache/doris/datasource/trinoconnector/source/TrinoConnectorScanNode.java: ## @@ -137,17 +151,65 @@ public List getSplits() throws Use

Re: [PR] [feat](Nereids): lazy get expression map [doris]

2024-05-13 Thread via GitHub
XieJiann commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2109395111 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34799: URL: https://github.com/apache/doris/pull/34799#issuecomment-2109394294 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.33% (74264/271748) Region Coverage: 26.56% (38372/19) Branch Coverage: 23.3

Re: [PR] [fix](SegComp) Don't call file writer close multi times for segcompaction [doris]

2024-05-13 Thread via GitHub
ByteYue commented on PR #34818: URL: https://github.com/apache/doris/pull/34818#issuecomment-2109392333 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](SegComp) Don't call file writer close multi times for segcompaction [doris]

2024-05-13 Thread via GitHub
dataroaring commented on PR #34818: URL: https://github.com/apache/doris/pull/34818#issuecomment-2109392229 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](SegComp) Don't call file writer close multi times for segcompaction [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34818: URL: https://github.com/apache/doris/pull/34818#issuecomment-2109388963 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Chore](exec-version) set min_be_exec_version from 0 to 3 [doris]

2024-05-13 Thread via GitHub
BiteThet commented on PR #34653: URL: https://github.com/apache/doris/pull/34653#issuecomment-2109388171 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
yiguolei commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109388097 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109384466 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [bump](fe)upgrade dependencies [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34800: URL: https://github.com/apache/doris/pull/34800#issuecomment-2109382525 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [bump](fe)upgrade dependencies [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34800: URL: https://github.com/apache/doris/pull/34800#issuecomment-2109382478 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109382229 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [regression-test](framework) fix trino connector download bug in multi be [doris]

2024-05-13 Thread via GitHub
shuke987 commented on PR #34806: URL: https://github.com/apache/doris/pull/34806#issuecomment-2109382205 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](SegComp) Don't call file writer close multi times for segcompaction [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34818: URL: https://github.com/apache/doris/pull/34818#issuecomment-2109382068 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](SegComp) Don't call file writer close multi times for segcompaction [doris]

2024-05-13 Thread via GitHub
ByteYue opened a new pull request, #34818: URL: https://github.com/apache/doris/pull/34818 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:

Re: [PR] [debug](thrift rpc) debug thrift rpc [doris]

2024-05-13 Thread via GitHub
dataroaring commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2109380845 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](case) move test_ctas_mv,test_mv_case to single directory [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34801: URL: https://github.com/apache/doris/pull/34801#issuecomment-2109379024 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Chore](case) move test_ctas_mv,test_mv_case to single directory [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34801: URL: https://github.com/apache/doris/pull/34801#issuecomment-2109378972 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
morningman commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109375179 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](function) money format [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2109371845 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [bugfix](fecancel) should release lock before throw exception [doris]

2024-05-13 Thread via GitHub
yiguolei opened a new pull request, #34817: URL: https://github.com/apache/doris/pull/34817 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto

Re: [PR] [fix](iceberg) prevent coredump if read position delete file failed [doris]

2024-05-13 Thread via GitHub
yiguolei merged PR #34797: URL: https://github.com/apache/doris/pull/34797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

(doris) branch master updated (d9bbd21010a -> 82596e63bf1)

2024-05-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from d9bbd21010a [feature](storage-vault) Implement privilege management for storage vault (#34638) add 82596e63bf1

Re: [PR] [bugfix](fecancel) should release lock before throw exception [doris]

2024-05-13 Thread via GitHub
yiguolei commented on PR #34817: URL: https://github.com/apache/doris/pull/34817#issuecomment-2109367182 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [bugfix](fecancel) should release lock before throw exception [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34817: URL: https://github.com/apache/doris/pull/34817#issuecomment-2109367115 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109364884 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109363662 run cloud_p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109363560 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [feature](storage-vault) Implement privilege management for storage vault [doris]

2024-05-13 Thread via GitHub
dataroaring merged PR #34638: URL: https://github.com/apache/doris/pull/34638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated (76868dbb9fb -> d9bbd21010a)

2024-05-13 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 76868dbb9fb [fix](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node_ids going into old

Re: [PR] [opt](nereids) support topn-filter for external table [doris]

2024-05-13 Thread via GitHub
englefly commented on PR #34674: URL: https://github.com/apache/doris/pull/34674#issuecomment-2109361611 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_nodeā€¦ [doris]

2024-05-13 Thread via GitHub
dataroaring merged PR #34808: URL: https://github.com/apache/doris/pull/34808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated (8cf7ac94191 -> 76868dbb9fb)

2024-05-13 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 8cf7ac94191 [Bug](regression) Fix occasional timeout issues (#34691) add 76868dbb9fb [fix](topn) fix dcheck f

(doris) branch branch-3.0 updated: Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" (#34815)

2024-05-13 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 2658914bc6e Pick "[fix](IO) Fix asyn

Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]

2024-05-13 Thread via GitHub
dataroaring merged PR #34815: URL: https://github.com/apache/doris/pull/34815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109358015 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109357692 run cloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [Fix] Fix clang-18 and libc++ compile problems [doris]

2024-05-13 Thread via GitHub
biohazard4321 commented on PR #34715: URL: https://github.com/apache/doris/pull/34715#issuecomment-2109355749 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109355249 TPC-DS: Total hot run time: 188508 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

(doris) branch branch-2.1 updated: [fix](iceberg) prevent coredump if read position delete file failed (#34802)

2024-05-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 9491b7d4224 [fix](iceberg) prevent core

Re: [PR] [fix](iceberg) prevent coredump if read position delete file failed [doris]

2024-05-13 Thread via GitHub
yiguolei merged PR #34802: URL: https://github.com/apache/doris/pull/34802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

(doris) branch master updated (fc5cde42eea -> 8cf7ac94191)

2024-05-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from fc5cde42eea [fix](jdbc catalog) fix jdbc table checksum and query jdbc tvf (#34779) add 8cf7ac94191 [Bug](regre

Re: [PR] [Bug](regression) Fix occasional timeout issues [doris]

2024-05-13 Thread via GitHub
yiguolei merged PR #34691: URL: https://github.com/apache/doris/pull/34691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [exec](thrift) add agg limit opt thrift interface [doris]

2024-05-13 Thread via GitHub
englefly commented on code in PR #33691: URL: https://github.com/apache/doris/pull/33691#discussion_r1599424032 ## gensrc/thrift/PlanNodes.thrift: ## @@ -892,7 +892,7 @@ struct TAggregationNode { 7: optional list agg_sort_infos 8: optional bool is_first_phase 9: optiona

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109349345 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109348200 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109341666 TPC-H: Total hot run time: 41995 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109337745 TPC-DS: Total hot run time: 187790 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109334381 TeamCity be ut coverage result: Function Coverage: 35.66% (8980/25180) Line Coverage: 27.32% (74237/271751) Region Coverage: 26.55% (38348/144451) Branch Coverage: 23.3

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109333158 TPC-DS: Total hot run time: 187183 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109325705 TPC-H: Total hot run time: 40226 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
xzj7019 commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109323649 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109321613 TPC-H: Total hot run time: 40164 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]

2024-05-13 Thread via GitHub
zhangstar333 commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2109319409 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2109318366 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/9074264655";) output. shellcheck err

Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on code in PR #34799: URL: https://github.com/apache/doris/pull/34799#discussion_r1599399596 ## be/src/io/fs/s3_file_writer.cpp: ## @@ -242,7 +242,7 @@ Status S3FileWriter::_close_impl() { } Status S3FileWriter::appendv(const Slice* data, size_t

Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]

2024-05-13 Thread via GitHub
ByteYue commented on PR #34799: URL: https://github.com/apache/doris/pull/34799#issuecomment-2109310370 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109307177 TPC-DS: Total hot run time: 187526 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109303684 TPC-DS: Total hot run time: 186868 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109301537 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
starocean999 commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109301596 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
starocean999 opened a new pull request, #34816: URL: https://github.com/apache/doris/pull/34816 ## Proposed changes The last param of AggregateExpression's constructor should be agg function in phase 3 or 4-phase agg ## Further comments If this is a relatively la

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109296292 TPC-H: Total hot run time: 39923 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]

2024-05-13 Thread via GitHub
eldenmoon commented on code in PR #34662: URL: https://github.com/apache/doris/pull/34662#discussion_r1599385168 ## fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlSerializer.java: ## @@ -298,6 +298,8 @@ public int getMysqlDecimals(Type type) { case DECIMAL64:

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109293028 TPC-H: Total hot run time: 40653 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feat](Nereids): lazy get expression map [doris]

2024-05-13 Thread via GitHub
XieJiann commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2109288060 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [bump](fe)upgrade dependencies [doris]

2024-05-13 Thread via GitHub
CalvinKirs commented on PR #34800: URL: https://github.com/apache/doris/pull/34800#issuecomment-2109285402 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Enhancement] FE/BE print the node start time at startup [doris]

2024-05-13 Thread via GitHub
rohitrs1983 commented on PR #34499: URL: https://github.com/apache/doris/pull/34499#issuecomment-2109285442 @LemonLiTree can u please review my PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109285271 TPC-DS: Total hot run time: 188082 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [regression-test](framework) fix trino connector download bug in multi be [doris]

2024-05-13 Thread via GitHub
shuke987 commented on PR #34806: URL: https://github.com/apache/doris/pull/34806#issuecomment-2109283634 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34815: URL: https://github.com/apache/doris/pull/34815#issuecomment-2109279430 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34815: URL: https://github.com/apache/doris/pull/34815#issuecomment-2109279404 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on code in PR #34370: URL: https://github.com/apache/doris/pull/34370#discussion_r1599375169 ## fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java: ## @@ -1466,23 +1469,27 @@ public boolean shouldCancel(List currentBackends) { // fragment

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
XieJiann commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109275454 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109274831 TPC-H: Total hot run time: 40233 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109272821 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.32% (74256/271756) Region Coverage: 26.56% (38371/144460) Branch Coverage: 23.3

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109271182 TPC-DS: Total hot run time: 185826 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109266195 TPC-DS: Total hot run time: 186951 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109263094 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
yiguolei commented on code in PR #34812: URL: https://github.com/apache/doris/pull/34812#discussion_r1599364710 ## be/src/runtime/fragment_mgr.cpp: ## @@ -505,6 +505,7 @@ void FragmentMgr::_exec_actual(std::shared_ptr fragment_ex } Status FragmentMgr::exec_plan_fragment(con

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109260892 TPC-H: Total hot run time: 40244 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feature](block) add check type in block data type and column [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2109260591 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
hubgeter commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109257886 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

  1   2   3   4   5   6   7   8   >