[GitHub] [doris] wangbo commented on a diff in pull request #18635: [improvement](executor) Priority Queue support vruntime

2023-04-13 Thread via GitHub
wangbo commented on code in PR #18635: URL: https://github.com/apache/doris/pull/18635#discussion_r1166365625 ## be/src/pipeline/pipeline_task.h: ## @@ -174,14 +174,26 @@ class PipelineTask { std::string debug_string() const; -uint32_t total_schedule_time() const {

[GitHub] [doris] wangbo commented on a diff in pull request #18635: [improvement](executor) Priority Queue support vruntime

2023-04-13 Thread via GitHub
wangbo commented on code in PR #18635: URL: https://github.com/apache/doris/pull/18635#discussion_r1166365625 ## be/src/pipeline/pipeline_task.h: ## @@ -174,14 +174,26 @@ class PipelineTask { std::string debug_string() const; -uint32_t total_schedule_time() const {

[GitHub] [doris] yiguolei commented on pull request #18625: [chore] Download apache orc source code from github if git does not work in build.sh.

2023-04-13 Thread via GitHub
yiguolei commented on PR #18625: URL: https://github.com/apache/doris/pull/18625#issuecomment-1508012630 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #18625: [chore] Download apache orc source code from github if git does not work in build.sh.

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18625: URL: https://github.com/apache/doris/pull/18625#issuecomment-1508011835 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18625: [chore] Download apache orc source code from github if git does not work in build.sh.

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18625: URL: https://github.com/apache/doris/pull/18625#issuecomment-1508011793 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] ByteYue commented on pull request #17585: [feature](io) enable s3 file writer with multi part uploading concurrently

2023-04-13 Thread via GitHub
ByteYue commented on PR #17585: URL: https://github.com/apache/doris/pull/17585#issuecomment-1508010919 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #17585: [feature](io) enable s3 file writer with multi part uploading concurrently

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #17585: URL: https://github.com/apache/doris/pull/17585#issuecomment-1508010857 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] bigben0204 opened a new issue, #18668: [Feature] Add a new rest api to query instance host and ip information for query profile action

2023-04-13 Thread via GitHub
bigben0204 opened a new issue, #18668: URL: https://github.com/apache/doris/issues/18668 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Currently the api

[GitHub] [doris] hello-stephen commented on pull request #18607: [opt](nereids) optimze aggregation estimation

2023-04-13 Thread via GitHub
hello-stephen commented on PR #18607: URL: https://github.com/apache/doris/pull/18607#issuecomment-1508007212 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.07 seconds stream load tsv: 434 seconds loaded 74807831229 Bytes, about 164 MB/s

[doris] branch master updated (db5ec6f6b0 -> 9634d21a28)

2023-04-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from db5ec6f6b0 [FIX](thrift)Fix with 1.2 version for thrift #18658 add 9634d21a28 [fix](info_db) avoid infodb query

[GitHub] [doris] yiguolei merged pull request #18662: [fix](info_db) avoid infodb query timeout when external catalog info is too large or is not reachable

2023-04-13 Thread via GitHub
yiguolei merged PR #18662: URL: https://github.com/apache/doris/pull/18662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] luozenglin commented on pull request #18575: [improvement](resource-group) add test for resource group

2023-04-13 Thread via GitHub
luozenglin commented on PR #18575: URL: https://github.com/apache/doris/pull/18575#issuecomment-1508001347 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #18576: [feature](segcompaction) enable segcompaction by default

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18576: URL: https://github.com/apache/doris/pull/18576#issuecomment-1507999729 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yixiutt commented on pull request #18643: [improvement](merge-on-write) move segment check to delta writer

2023-04-13 Thread via GitHub
yixiutt commented on PR #18643: URL: https://github.com/apache/doris/pull/18643#issuecomment-1507998334 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] yiguolei closed pull request #18664: [fix](limit) fix bug of limit without order by

2023-04-13 Thread via GitHub
yiguolei closed pull request #18664: [fix](limit) fix bug of limit without order by URL: https://github.com/apache/doris/pull/18664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [doris] yiguolei commented on pull request #18664: [fix](limit) fix bug of limit without order by

2023-04-13 Thread via GitHub
yiguolei commented on PR #18664: URL: https://github.com/apache/doris/pull/18664#issuecomment-1507996996 it seems useless to modify it because the result is not stable without order by clause. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [doris] sohardforaname commented on pull request #18209: [Feature](Nereids)add executable function to support fold constant for functions.

2023-04-13 Thread via GitHub
sohardforaname commented on PR #18209: URL: https://github.com/apache/doris/pull/18209#issuecomment-1507990272 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] luozenglin commented on pull request #18249: [refactor](fe): Remove resource group which is useless

2023-04-13 Thread via GitHub
luozenglin commented on PR #18249: URL: https://github.com/apache/doris/pull/18249#issuecomment-1507985694 PTAL @morningman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] Jibing-Li commented on pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode

2023-04-13 Thread via GitHub
Jibing-Li commented on PR #18636: URL: https://github.com/apache/doris/pull/18636#issuecomment-1507980046 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] englefly commented on a diff in pull request #18596: [enhancement](Nereids) optimize bloom filter size reducing strategy

2023-04-13 Thread via GitHub
englefly commented on code in PR #18596: URL: https://github.com/apache/doris/pull/18596#discussion_r1166324139 ## fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsMathUtil.java: ## @@ -59,4 +64,21 @@ public static double divide(double a, double b) { return

[GitHub] [doris] github-actions[bot] commented on pull request #18596: [enhancement](Nereids) optimize bloom filter size reducing strategy

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18596: URL: https://github.com/apache/doris/pull/18596#issuecomment-1507976133 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18596: [enhancement](Nereids) optimize bloom filter size reducing strategy

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18596: URL: https://github.com/apache/doris/pull/18596#issuecomment-1507976140 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18596: [enhancement](Nereids) optimize bloom filter size reducing strategy

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18596: URL: https://github.com/apache/doris/pull/18596#issuecomment-1507976106 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18596: [enhancement](Nereids) optimize bloom filter size reducing strategy

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18596: URL: https://github.com/apache/doris/pull/18596#issuecomment-1507976107 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] englefly commented on a diff in pull request #18596: [enhancement](Nereids) optimize bloom filter size reducing strategy

2023-04-13 Thread via GitHub
englefly commented on code in PR #18596: URL: https://github.com/apache/doris/pull/18596#discussion_r1166322983 ## fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsMathUtil.java: ## @@ -59,4 +64,21 @@ public static double divide(double a, double b) { return

[GitHub] [doris] englefly commented on a diff in pull request #18596: [enhancement](Nereids) optimize bloom filter size reducing strategy

2023-04-13 Thread via GitHub
englefly commented on code in PR #18596: URL: https://github.com/apache/doris/pull/18596#discussion_r1166320661 ## fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java: ## @@ -111,8 +114,21 @@ public PhysicalPlan visitPhysicalHashJoin(Phy

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18667: [test](bufferedreader) add ut for buffered reader

2023-04-13 Thread via GitHub
github-actions[bot] commented on code in PR #18667: URL: https://github.com/apache/doris/pull/18667#discussion_r1166317874 ## be/test/io/fs/buffered_reader_test.cpp: ## @@ -0,0 +1,225 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

[doris] branch master updated: [FIX](thrift)Fix with 1.2 version for thrift #18658

2023-04-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new db5ec6f6b0 [FIX](thrift)Fix with 1.2 version fo

[GitHub] [doris] yiguolei merged pull request #18658: [FIX](thrift)Fix with 1.2 version for thrift

2023-04-13 Thread via GitHub
yiguolei merged PR #18658: URL: https://github.com/apache/doris/pull/18658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] ByteYue commented on pull request #18667: [test](bufferedreader) add ut for buffered reader

2023-04-13 Thread via GitHub
ByteYue commented on PR #18667: URL: https://github.com/apache/doris/pull/18667#issuecomment-1507968439 run buildadd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] ByteYue opened a new pull request, #18667: [test](bufferedreader) add ut for buffered reader

2023-04-13 Thread via GitHub
ByteYue opened a new pull request, #18667: URL: https://github.com/apache/doris/pull/18667 # Proposed changes Issue Number: close #xxx Add one ut source file for buffered reader to check correctness of implementation. ## Problem summary Describe your changes. ## Ch

[doris-thirdparty] branch clucene updated: [Update] add ram balance for SDocumentWriter (#54)

2023-04-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch clucene in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git The following commit(s) were added to refs/heads/clucene by this push: new 58b692c [Update] add ram balanc

[GitHub] [doris-thirdparty] morningman merged pull request #54: [Update] add ram balance for SDocumentWriter

2023-04-13 Thread via GitHub
morningman merged PR #54: URL: https://github.com/apache/doris-thirdparty/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@do

[GitHub] [doris] CalvinKirs commented on pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern

2023-04-13 Thread via GitHub
CalvinKirs commented on PR #18666: URL: https://github.com/apache/doris/pull/18666#issuecomment-1507965740 todo add UT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] morrySnow merged pull request #18593: [enhancement](planner) remove date function if its child's type is date

2023-04-13 Thread via GitHub
morrySnow merged PR #18593: URL: https://github.com/apache/doris/pull/18593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated (81799d614e -> e009c459bf)

2023-04-13 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 81799d614e [feature-wip](resource-group) support resource group interface in be. (#18588) add e009c459bf [enha

[doris] branch master updated (e009c459bf -> 4d18ea30f4)

2023-04-13 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from e009c459bf [enhancement](planner) remove date function if its child's type is date (#18593) add 4d18ea30f4 [fi

[GitHub] [doris] morrySnow merged pull request #18626: [fix](Nereids) get_json_bigint should return bigint type

2023-04-13 Thread via GitHub
morrySnow merged PR #18626: URL: https://github.com/apache/doris/pull/18626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated: [feature-wip](resource-group) support resource group interface in be. (#18588)

2023-04-13 Thread luozenglin
This is an automated email from the ASF dual-hosted git repository. luozenglin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 81799d614e [feature-wip](resource-group) supp

[GitHub] [doris] luozenglin merged pull request #18588: [feature-wip](resource-group) support resource group interface in be.

2023-04-13 Thread via GitHub
luozenglin merged PR #18588: URL: https://github.com/apache/doris/pull/18588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] CalvinKirs opened a new pull request, #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern

2023-04-13 Thread via GitHub
CalvinKirs opened a new pull request, #18666: URL: https://github.com/apache/doris/pull/18666 # Proposed changes Issue Number: close #xxx ## Problem summary `commons-lang `(1and2) is no longer maintained since 2011, and the official recommendation is `commons-lang3`, which c

[GitHub] [doris] waywtdcc commented on issue #18621: [Enhancement] duplicate table without key

2023-04-13 Thread via GitHub
waywtdcc commented on issue #18621: URL: https://github.com/apache/doris/issues/18621#issuecomment-1507955686 Does this mean that duplicate tables can be created in the following way? CREATE TABLE cc_test.cc32 ( id int NULL, name varchar(200) default 'cc' ) DUPLICATE D

[GitHub] [doris] hello-stephen commented on pull request #18665: [regression-test](prepared statement) Fix connection error when test framework used lower jdbc version

2023-04-13 Thread via GitHub
hello-stephen commented on PR #18665: URL: https://github.com/apache/doris/pull/18665#issuecomment-1507955300 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.75 seconds stream load tsv: 430 seconds loaded 74807831229 Bytes, about 165 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #18336: [Bug](DECIMALV3) report failure if a decimal value is overflow

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18336: URL: https://github.com/apache/doris/pull/18336#issuecomment-1507954975 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Gabriel39 commented on pull request #18336: [Bug](DECIMALV3) report failure if a decimal value is overflow

2023-04-13 Thread via GitHub
Gabriel39 commented on PR #18336: URL: https://github.com/apache/doris/pull/18336#issuecomment-1507952154 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #18580: [feature](function) Add new parameters to 'trim'.

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18580: URL: https://github.com/apache/doris/pull/18580#issuecomment-1507942217 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] eldenmoon commented on pull request #18665: [regression-test](prepared statement) Fix connection error when test framework used lower jdbc version

2023-04-13 Thread via GitHub
eldenmoon commented on PR #18665: URL: https://github.com/apache/doris/pull/18665#issuecomment-1507942128 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] eldenmoon opened a new pull request, #18665: [regression-test](prepared statement) Fix connection error when test framework used lower jdbc version

2023-04-13 Thread via GitHub
eldenmoon opened a new pull request, #18665: URL: https://github.com/apache/doris/pull/18665 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] Mryange commented on pull request #18580: [feature](function) Add new parameters to 'trim'.

2023-04-13 Thread via GitHub
Mryange commented on PR #18580: URL: https://github.com/apache/doris/pull/18580#issuecomment-1507941546 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #18605: [Bugfix](Mtmv)Fix mtmv meta load failed

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18605: URL: https://github.com/apache/doris/pull/18605#issuecomment-1507941076 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18605: [Bugfix](Mtmv)Fix mtmv meta load failed

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18605: URL: https://github.com/apache/doris/pull/18605#issuecomment-1507940995 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] morningman commented on pull request #18605: [Bugfix](Mtmv)Fix mtmv meta load failed

2023-04-13 Thread via GitHub
morningman commented on PR #18605: URL: https://github.com/apache/doris/pull/18605#issuecomment-1507940517 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] amorynan commented on pull request #18658: [FIX](thrift)Fix with 1.2 version for thrift

2023-04-13 Thread via GitHub
amorynan commented on PR #18658: URL: https://github.com/apache/doris/pull/18658#issuecomment-1507938593 run arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] jacktengg opened a new pull request, #18664: [fix](limit) fix bug of limit without order by

2023-04-13 Thread via GitHub
jacktengg opened a new pull request, #18664: URL: https://github.com/apache/doris/pull/18664 # Proposed changes Issue Number: close #xxx ## Problem summary Limit without order by did not skip rows of offset. ## Checklist(Required) * [ ] Does it affect the o

[GitHub] [doris] zy-kkk commented on pull request #18623: [improve](postgresql catalog) support postgresql bytea type to doris string

2023-04-13 Thread via GitHub
zy-kkk commented on PR #18623: URL: https://github.com/apache/doris/pull/18623#issuecomment-1507928321 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] jackwener commented on pull request #18316: [feature](Nereids): when cost time > 10s, throw timeout Exception

2023-04-13 Thread via GitHub
jackwener commented on PR #18316: URL: https://github.com/apache/doris/pull/18316#issuecomment-1507913357 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[doris] branch branch-1.2-lts updated: [chore](third-party) Configure the search paths for pkg-config and cmake (#18624) (#18661)

2023-04-13 Thread adonisling
This is an automated email from the ASF dual-hosted git repository. adonisling pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new 3632c4e27a [chore](third-part

[GitHub] [doris] adonis0147 merged pull request #18661: [chore](third-party) Configure the search paths for pkg-config and cmake

2023-04-13 Thread via GitHub
adonis0147 merged PR #18661: URL: https://github.com/apache/doris/pull/18661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] hello-stephen commented on pull request #18617: [feature](nereids) forbid unknown col stats

2023-04-13 Thread via GitHub
hello-stephen commented on PR #18617: URL: https://github.com/apache/doris/pull/18617#issuecomment-1507905798 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.34 seconds stream load tsv: 432 seconds loaded 74807831229 Bytes, about 165 MB/s

[GitHub] [doris] myfjdthink commented on pull request #18616: support read iceberg data on gcs

2023-04-13 Thread via GitHub
myfjdthink commented on PR #18616: URL: https://github.com/apache/doris/pull/18616#issuecomment-1507899787 > should be LogManager.getLogger(S3Util.class) fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] yiguolei commented on a diff in pull request #18503: [enhancement](exception) Column filter/replicate supports exception safety

2023-04-13 Thread via GitHub
yiguolei commented on code in PR #18503: URL: https://github.com/apache/doris/pull/18503#discussion_r1166258703 ## be/src/vec/core/block.h: ## @@ -264,9 +265,11 @@ class Block { void append_block_by_selector(MutableBlock* dst, const IColumn::Selector& selector) const;

[GitHub] [doris] myfjdthink commented on pull request #18616: support read iceberg data on gcs

2023-04-13 Thread via GitHub
myfjdthink commented on PR #18616: URL: https://github.com/apache/doris/pull/18616#issuecomment-1507899338 在 master 分支上跑通,测试可以读取 gcs iceberg 数据,我后面再补充一个文档的 PR,描述何如配置 gcs iceberg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [doris] github-actions[bot] commented on pull request #18663: [fix](build.sh) Remove the excessive space of apache-orc path

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18663: URL: https://github.com/apache/doris/pull/18663#issuecomment-1507895519 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18663: [fix](build.sh) Remove the excessive space of apache-orc path

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18663: URL: https://github.com/apache/doris/pull/18663#issuecomment-1507895488 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] yiguolei commented on a diff in pull request #18627: [Refact](type system) refact serde for type system and pb serde impl

2023-04-13 Thread via GitHub
yiguolei commented on code in PR #18627: URL: https://github.com/apache/doris/pull/18627#discussion_r1166254665 ## be/src/vec/functions/function_rpc.cpp: ## @@ -316,6 +317,7 @@ void RPCFnImpl::convert_col_to_pvalue(const ColumnPtr& column, const DataTypePtr } } +// (Tod

[GitHub] [doris] yiguolei commented on a diff in pull request #18627: [Refact](type system) refact serde for type system and pb serde impl

2023-04-13 Thread via GitHub
yiguolei commented on code in PR #18627: URL: https://github.com/apache/doris/pull/18627#discussion_r1166168681 ## be/src/vec/data_types/data_type_struct.h: ## @@ -99,6 +100,14 @@ class DataTypeStruct final : public IDataType { std::string to_string(const IColumn& column, s

[GitHub] [doris] yiguolei commented on a diff in pull request #18627: [Refact](type system) refact serde for type system and pb serde impl

2023-04-13 Thread via GitHub
yiguolei commented on code in PR #18627: URL: https://github.com/apache/doris/pull/18627#discussion_r1166167349 ## be/src/vec/data_types/data_type_nullable.h: ## @@ -98,6 +99,10 @@ class DataTypeNullable final : public IDataType { const DataTypePtr& get_nested_type() const

[GitHub] [doris] yiguolei commented on a diff in pull request #18627: [Refact](type system) refact serde for type system and pb serde impl

2023-04-13 Thread via GitHub
yiguolei commented on code in PR #18627: URL: https://github.com/apache/doris/pull/18627#discussion_r1166253167 ## be/src/vec/data_types/serde/data_type_hll_serde.cpp: ## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

[GitHub] [doris] yiguolei commented on a diff in pull request #18627: [Refact](type system) refact serde for type system and pb serde impl

2023-04-13 Thread via GitHub
yiguolei commented on code in PR #18627: URL: https://github.com/apache/doris/pull/18627#discussion_r1166252568 ## be/src/vec/data_types/serde/data_type_decimal_serde.h: ## @@ -0,0 +1,64 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

[GitHub] [doris] mrhhsg opened a new pull request, #18663: [fix](build.sh) Remove the excessive space of apache-orc path

2023-04-13 Thread via GitHub
mrhhsg opened a new pull request, #18663: URL: https://github.com/apache/doris/pull/18663 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has uni

[GitHub] [doris] hello-stephen commented on pull request #18647: [Fix](thrift) add SCH_BACKENDS in TSchemaTableType

2023-04-13 Thread via GitHub
hello-stephen commented on PR #18647: URL: https://github.com/apache/doris/pull/18647#issuecomment-1507887415 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.36 seconds stream load tsv: 433 seconds loaded 74807831229 Bytes, about 164 MB/s

[GitHub] [doris] yiguolei commented on a diff in pull request #18627: [Refact](type system) refact serde for type system and pb serde impl

2023-04-13 Thread via GitHub
yiguolei commented on code in PR #18627: URL: https://github.com/apache/doris/pull/18627#discussion_r1166250291 ## be/src/vec/data_types/serde/data_type_bitmap_serde.cpp: ## @@ -0,0 +1,40 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

[GitHub] [doris] github-actions[bot] commented on pull request #17485: [log](fe) add more detail log for master transfer (#17350)

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #17485: URL: https://github.com/apache/doris/pull/17485#issuecomment-1507883882 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18593: [enhancement](planner) remove date function if its child's type is date

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18593: URL: https://github.com/apache/doris/pull/18593#issuecomment-1507879386 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18593: [enhancement](planner) remove date function if its child's type is date

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18593: URL: https://github.com/apache/doris/pull/18593#issuecomment-1507879368 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #18653: [Optimization](statistics) optimize the problem of slow deletion of statistics .

2023-04-13 Thread via GitHub
Kikyou1997 commented on code in PR #18653: URL: https://github.com/apache/doris/pull/18653#discussion_r1166242504 ## fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisManager.java: ## @@ -100,16 +98,24 @@ public void createAnalysisJob(AnalyzeStmt analyzeStmt) throws

[GitHub] [doris] amorynan commented on pull request #18658: [FIX](thrift)Fix with 1.2 version for thrift

2023-04-13 Thread via GitHub
amorynan commented on PR #18658: URL: https://github.com/apache/doris/pull/18658#issuecomment-1507876964 run arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] Jibing-Li commented on pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode

2023-04-13 Thread via GitHub
Jibing-Li commented on PR #18636: URL: https://github.com/apache/doris/pull/18636#issuecomment-1507876739 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #18626: [fix](Nereids) get_json_bigint should return bigint type

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18626: URL: https://github.com/apache/doris/pull/18626#issuecomment-1507874913 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18626: [fix](Nereids) get_json_bigint should return bigint type

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18626: URL: https://github.com/apache/doris/pull/18626#issuecomment-1507874894 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] yixiutt commented on pull request #18643: [improvement](merge-on-write) move segment check to delta writer

2023-04-13 Thread via GitHub
yixiutt commented on PR #18643: URL: https://github.com/apache/doris/pull/18643#issuecomment-1507874819 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[doris] branch master updated (e6b0e05840 -> 008ae4984b)

2023-04-13 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from e6b0e05840 [fix](Nerieds) Fix some bugs in binding and type coercion (#18548) add 008ae4984b [feature](Nereids):

[GitHub] [doris] jackwener merged pull request #18648: [feature](Nereids): convert rightSemi to leftSemi for matching more rules

2023-04-13 Thread via GitHub
jackwener merged PR #18648: URL: https://github.com/apache/doris/pull/18648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] morrySnow commented on pull request #18639: [fix](Nereids) fix signature precision round for decimalv3

2023-04-13 Thread via GitHub
morrySnow commented on PR #18639: URL: https://github.com/apache/doris/pull/18639#issuecomment-1507873509 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] HappenLee commented on a diff in pull request #18580: [feature](function) Add new parameters to 'trim'.

2023-04-13 Thread via GitHub
HappenLee commented on code in PR #18580: URL: https://github.com/apache/doris/pull/18580#discussion_r1166238988 ## be/src/util/simd/vstring_function.h: ## @@ -125,6 +125,101 @@ class VStringFunctions { return rtrim(ltrim(str)); } +static StringRef rtrim(cons

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #18653: [Optimization](statistics) optimize the problem of slow deletion of statistics .

2023-04-13 Thread via GitHub
Kikyou1997 commented on code in PR #18653: URL: https://github.com/apache/doris/pull/18653#discussion_r1166238028 ## fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsRepository.java: ## @@ -179,15 +205,7 @@ private static void dropStatistics(Long dbId, M

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #18653: [Optimization](statistics) optimize the problem of slow deletion of statistics .

2023-04-13 Thread via GitHub
Kikyou1997 commented on code in PR #18653: URL: https://github.com/apache/doris/pull/18653#discussion_r1166233812 ## fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisHelper.java: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #18653: [Optimization](statistics) optimize the problem of slow deletion of statistics .

2023-04-13 Thread via GitHub
Kikyou1997 commented on code in PR #18653: URL: https://github.com/apache/doris/pull/18653#discussion_r1166232376 ## fe/fe-common/src/main/java/org/apache/doris/common/Config.java: ## @@ -1695,6 +1695,24 @@ public class Config extends ConfigBase { @ConfField(mutable = true,

[GitHub] [doris] morningman commented on pull request #18662: [fix](info_db) avoid infodb query timeout when external catalog info is too large or is not reachable

2023-04-13 Thread via GitHub
morningman commented on PR #18662: URL: https://github.com/apache/doris/pull/18662#issuecomment-1507863142 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #18525: [vectorized](profile) fix pipeline profile can't get result under more instances

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18525: URL: https://github.com/apache/doris/pull/18525#issuecomment-1507862712 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18525: [vectorized](profile) fix pipeline profile can't get result under more instances

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18525: URL: https://github.com/apache/doris/pull/18525#issuecomment-1507862671 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] zy-kkk commented on pull request #18623: [improve](postgresql catalog) support postgresql bytea type to doris string

2023-04-13 Thread via GitHub
zy-kkk commented on PR #18623: URL: https://github.com/apache/doris/pull/18623#issuecomment-1507862612 > please add test case done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [doris] morningman opened a new pull request, #18662: [fix](info_db) avoid infodb query timeout when external catalog info …

2023-04-13 Thread via GitHub
morningman opened a new pull request, #18662: URL: https://github.com/apache/doris/pull/18662 …is too large or is not reachable # Proposed changes Issue Number: close #xxx When query tables in `information_schema` databases, it may timeout due to: 1. There are exte

[GitHub] [doris] englefly commented on pull request #18617: [feature](nereids) forbid unknown col stats

2023-04-13 Thread via GitHub
englefly commented on PR #18617: URL: https://github.com/apache/doris/pull/18617#issuecomment-1507862144 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[doris] branch master updated (c704351273 -> e6b0e05840)

2023-04-13 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from c704351273 [enhancement](memory) Refactor memory limit exceeded behavior (#18590) add e6b0e05840 [fix](Nerieds

[GitHub] [doris] zy-kkk commented on pull request #18623: [improve](postgresql catalog) support postgresql bytea type to doris string

2023-04-13 Thread via GitHub
zy-kkk commented on PR #18623: URL: https://github.com/apache/doris/pull/18623#issuecomment-1507862016 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] morrySnow merged pull request #18548: [fix](Nerieds) Fix some bugs

2023-04-13 Thread via GitHub
morrySnow merged PR #18548: URL: https://github.com/apache/doris/pull/18548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] github-actions[bot] commented on pull request #18548: [fix](Nerieds) Fix some bugs

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #18548: URL: https://github.com/apache/doris/pull/18548#issuecomment-1507861171 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] englefly commented on pull request #18607: [opt](nereids) optimze aggregation estimation

2023-04-13 Thread via GitHub
englefly commented on PR #18607: URL: https://github.com/apache/doris/pull/18607#issuecomment-1507861104 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #18653: [Optimization](statistics) optimize the problem of slow deletion of statistics .

2023-04-13 Thread via GitHub
Kikyou1997 commented on code in PR #18653: URL: https://github.com/apache/doris/pull/18653#discussion_r1166228540 ## fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisHelper.java: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

  1   2   3   4   >