[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1084840982 ## be/src/olap/types.cpp: ## @@ -218,6 +233,11 @@ TypeInfoPtr get_type_info(const TabletColumn* col) { TypeInfoPtr clone_type_info(const TypeInfo* type_info) { i

[GitHub] [doris] hello-stephen commented on pull request #16137: [refactor](remove unused code) remove storage buffer and orc reader

hello-stephen commented on PR #16137: URL: https://github.com/apache/doris/pull/16137#issuecomment-1401390539 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.45 seconds load time: 533 seconds storage size: 17122754338 Bytes https://doris-co

[GitHub] [doris] morningman commented on pull request #15839: [Feature] support segment builder tool

morningman commented on PR #15839: URL: https://github.com/apache/doris/pull/15839#issuecomment-1401381547 Some questions and suggestions: 1. `builder_scanner` doesn't seem to be used? Only `builder_scanner_memtable` is used? 2. Need to unify the inputs and outputs:

[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1084803369 ## be/src/olap/rowset/segment_v2/column_writer.cpp: ## @@ -173,6 +173,119 @@ Status ColumnWriter::create(const ColumnWriterOptions& opts, const TabletColumn*

[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1084803369 ## be/src/olap/rowset/segment_v2/column_writer.cpp: ## @@ -173,6 +173,119 @@ Status ColumnWriter::create(const ColumnWriterOptions& opts, const TabletColumn*

[GitHub] [doris] github-actions[bot] commented on pull request #16137: [refactor](remove unused code) remove storage buffer and orc reader

github-actions[bot] commented on PR #16137: URL: https://github.com/apache/doris/pull/16137#issuecomment-1401372367 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16137: [refactor](remove unused code) remove storage buffer and orc reader

github-actions[bot] commented on PR #16137: URL: https://github.com/apache/doris/pull/16137#issuecomment-1401364312 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yiguolei opened a new pull request, #16137: [refactor](remove unused code) remove storage buffer and orc reader

yiguolei opened a new pull request, #16137: URL: https://github.com/apache/doris/pull/16137 # Proposed changes 1. remove olap storage byte buffer 2. remove orc reader 3. remove time operator 4. remove read_write_util 5. remove aggregate funcs 6. remove compress.h and cpp

[GitHub] [doris] yiguolei merged pull request #16136: [refactor](remove expr) remove non vectorized Expr and ExprContext related codes

yiguolei merged PR #16136: URL: https://github.com/apache/doris/pull/16136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated (23edb3de5a -> 79ad74637d)

This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 23edb3de5a [fix](icebergv2) fix bug that delete file reader is not opened (#16133) add 79ad74637d [refactor](re

[doris] branch master updated: [fix](icebergv2) fix bug that delete file reader is not opened (#16133)

This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 23edb3de5a [fix](icebergv2) fix bug that delete

[GitHub] [doris] yiguolei merged pull request #16133: [fix](icebergv2) fix bug that delete file reader is not opened

yiguolei merged PR #16133: URL: https://github.com/apache/doris/pull/16133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #16136: [refactor](remove expr) remove non vectorized Expr and ExprContext related codes

github-actions[bot] commented on PR #16136: URL: https://github.com/apache/doris/pull/16136#issuecomment-1401301888 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16136: [refactor](remove expr) remove non vectorized Expr and ExprContext related codes

github-actions[bot] commented on PR #16136: URL: https://github.com/apache/doris/pull/16136#issuecomment-1401301852 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] hello-stephen commented on pull request #16136: [refactor](remove expr) remove non vectorized Expr and ExprContext related codes

hello-stephen commented on PR #16136: URL: https://github.com/apache/doris/pull/16136#issuecomment-1400534522 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.05 seconds load time: 491 seconds storage size: 17122202122 Bytes https://doris-co

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16136: [refactor](remove expr) remove non vectorized Expr and ExprContext related codes

github-actions[bot] commented on code in PR #16136: URL: https://github.com/apache/doris/pull/16136#discussion_r1084169844 ## be/src/exprs/cast_functions.h: ## @@ -24,6 +24,20 @@ namespace doris { +using doris_udf::FunctionContext; +using doris_udf::BooleanVal; +using doris

[doris] 06/06: [vectorized](analytic) fix analytic node of window function get wrong… (#16074)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit c61be0cb8a85cda1b61b1bc0535020488207b46c Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com>

[doris] 05/06: [debug](ParquetReader) print file path if failed to read parquet file (#16118)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 82f923ee1f44dc1538c4f8446cbaec5493bd2d50 Author: Ashin Gau AuthorDate: Sat Jan 21 08:05:17 2023 +0800 [d

[doris] branch branch-1.2-lts updated (d078112585 -> c61be0cb8a)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git from d078112585 (improvement)[bucket] Add auto bucket implement (#15250) new d016aef2bc [fix](planner) fix

[doris] 04/06: [vectorzied](jdbc) fix jdbc executor for get result by batch and memo… (#15843)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit a071827534cca966b87d1ea412ceb1c3f11058bb Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com>

[doris] 02/06: [fix](daemon) should use GetMonoTimeMicros() (#16070)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 7095f4db3997964a825fc58f493dcf2dca83c8ef Author: Xin Huang <57054352+ishuang...@users.noreply.github.com> Auth

[doris] 01/06: [fix](planner) fix bugs in uncheckedCastChild (#15905)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit d016aef2bc44f20242e1a9561e5f9fb352b8f653 Author: minghong AuthorDate: Thu Jan 19 15:51:08 2023 +0800 [fi

[doris] 03/06: [fix](privilege)fix grant resource bug (#16045)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 42ab0c39de0a87f14d0860dc32a3c38a40231aec Author: zhangdong <493738...@qq.com> AuthorDate: Fri Jan 20 19:00:44

[GitHub] [doris] yiguolei opened a new pull request, #16136: [refactor](remove expr) remove unused Expr and ExprContext related codes

yiguolei opened a new pull request, #16136: URL: https://github.com/apache/doris/pull/16136 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Ye

[doris] branch branch-1.2-lts updated (768ff43c65 -> d078112585)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git from 768ff43c65 [Compile](lzo) fix lzo decompressor compiler error (#15956) new 5d5c2e9541 [fix](planner)wr

[doris] branch branch-1.2-lts updated (a23773393e -> e23788e0a7)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git from a23773393e [regression](external p2) cherry pick external table p2 case from master (#16134) new fce3

[doris] 02/05: [fix](fe)fix anti join bug (#15955)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 5e97bce8c01ff98118c7625074aa4a9be5882d60 Author: starocean999 <40539150+starocean...@users.noreply.github.com>

[doris] 01/05: [fix](planner)wrong result when has order by under join (#15974)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 5d5c2e95415feb34f7af30d0482af1c3ad8cb73a Author: morrySnow <101034200+morrys...@users.noreply.github.com> Auth

[doris] 05/05: (improvement)[bucket] Add auto bucket implement (#15250)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit d07811258500093691f020d0c92966cdc26e4e27 Author: Drogon AuthorDate: Wed Jan 18 19:50:18 2023 +0800 (impr

[doris] 03/05: [fix](regression-test) Fix the build for Java UDF Case (#15851)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 784e8d03312cbebe66e19385088246dda0f44ae6 Author: Adonis Ling AuthorDate: Tue Jan 17 20:25:53 2023 +0800

[GitHub] [doris] morningman commented on a diff in pull request #15511: [feature](Load)Suppot MySQL Load Data

morningman commented on code in PR #15511: URL: https://github.com/apache/doris/pull/15511#discussion_r1084074726 ## fe/fe-core/src/main/cup/sql_parser.cup: ## @@ -618,9 +618,13 @@ terminal String KW_MTMV, KW_TYPECAST, KW_HISTOGRAM, +<<< HEAD Review Comment:

[doris] 04/05: [enhance](planner)convert 'or' into 'in-predicate' (#15737)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 6ec00a340caa1f77876472bc5d18e6ca540b8153 Author: minghong AuthorDate: Wed Jan 18 12:33:20 2023 +0800 [en

[doris] 04/05: [enhancement](load) change the publish version log to VLOG_CRITICAL (#15673)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 521bed9ca122447baef4b61cdd7003f57f1b61c9 Author: zhannngchen <48427519+zhannngc...@users.noreply.github.com> A

[doris] 02/05: [refactor](rpc fn) decouple vectorized remote function from row-based one (#15871)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 776255018e49de42f6c9d5d003076903880ee7ba Author: Gabriel AuthorDate: Fri Jan 13 09:21:33 2023 +0800 [ref

[doris] 05/05: [Compile](lzo) fix lzo decompressor compiler error (#15956)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 768ff43c65226a966a2734a37b74de7ff9a33d85 Author: HappenLee AuthorDate: Tue Jan 17 09:56:07 2023 +0800 [C

[doris] branch branch-1.2-lts updated (e23788e0a7 -> 768ff43c65)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git from e23788e0a7 [Chore](build) enable -Wextra and remove some -Wno (#15760) new f59626a32e [opt](planner) r

[doris] 03/03: [Chore](build) enable -Wextra and remove some -Wno (#15760)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit e23788e0a7dd9464fd85902c39663d0a83b7e5d1 Author: Pxl AuthorDate: Sun Jan 15 10:40:35 2023 +0800 [Chore](

[doris] 01/03: [Bug](predicate) add double predicate creator (#15762)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit fce353ddaae31b2d3cb41bcdc021b87084614fd5 Author: AlexYue AuthorDate: Fri Jan 13 18:34:09 2023 +0800 [Bug

[doris] 01/05: [opt](planner) return bigint literal when cast date literal to bigint type (#15613)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit f59626a32ebd9f60207a2daa358e7948a93e2a01 Author: minghong AuthorDate: Fri Jan 13 12:58:04 2023 +0800 [op

[doris] 03/05: [Bug](function) catch function calculation error on aggregate node to avoid core dump (#15903)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 12faf8a99ded291deae17e9cdb5c6ff1104b5f9a Author: Pxl AuthorDate: Mon Jan 16 11:21:28 2023 +0800 [Bug](fu

[doris] 02/03: [fix](planner) move join reorder to the single node planner (#15817)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git commit 2001689b1d6bf467c7cefce409487e62eeebfa8a Author: AKIRA <33112463+kikyou1...@users.noreply.github.com> AuthorDa

[doris] branch branch-1.2-lts updated (bfc414ee53 -> a23773393e)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git from bfc414ee53 [refactor](fe) refactor and upgrade dependency tree of FE and support AWS glue catalog (#16046)

[GitHub] [doris] morningman opened a new pull request, #16134: [regression](external p2) cherry pick external table p2 case from master

morningman opened a new pull request, #16134: URL: https://github.com/apache/doris/pull/16134 # Proposed changes Issue Number: close #xxx ## Problem summary Cherry pick p2 case of external table from master ## Checklist(Required) 1. Does it affect the origin

[GitHub] [doris] morningman merged pull request #16134: [regression](external p2) cherry pick external table p2 case from master

morningman merged PR #16134: URL: https://github.com/apache/doris/pull/16134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] github-actions[bot] commented on pull request #16133: [fix](icebergv2) fix bug that delete file reader is not opened

github-actions[bot] commented on PR #16133: URL: https://github.com/apache/doris/pull/16133#issuecomment-1400279976 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman opened a new pull request, #16135: [fix](icebergv2) fix icebergv2 delete file open bug and column case insensitive

morningman opened a new pull request, #16135: URL: https://github.com/apache/doris/pull/16135 # Proposed changes Issue Number: close #xxx ## Problem summary cherry-pick #16133 and #15156 ## Checklist(Required) 1. Does it affect the original behavior:

[GitHub] [doris] hello-stephen commented on pull request #16133: [fix](icebergv2) fix bug that delete file reader is not opened

hello-stephen commented on PR #16133: URL: https://github.com/apache/doris/pull/16133#issuecomment-1400271675 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.74 seconds load time: 494 seconds storage size: 17122798066 Bytes https://doris-co

[GitHub] [doris] github-actions[bot] commented on pull request #16133: [fix](icebergv2) fix bug that delete file reader is not opened

github-actions[bot] commented on PR #16133: URL: https://github.com/apache/doris/pull/16133#issuecomment-1400250921 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman opened a new pull request, #16133: [fix](icebergv2) fix bug that delete file reader is not opened

morningman opened a new pull request, #16133: URL: https://github.com/apache/doris/pull/16133 # Proposed changes Issue Number: close #xxx ## Problem summary This pr #15836 change the way to use parquet reader by first `open()` then `init_reader()`. But we forgot to ca

[GitHub] [doris] github-actions[bot] commented on pull request #16128: [refactor](remove broker scan node) it is not useful any more

github-actions[bot] commented on PR #16128: URL: https://github.com/apache/doris/pull/16128#issuecomment-1400198243 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[doris] branch master updated (61fccc88d7 -> a3cd0ddbdc)

This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 61fccc88d7 [vectorized](analytic) fix analytic node of window function get wrong… (#16074) add a3cd0ddbdc [refa

[GitHub] [doris] yiguolei merged pull request #16128: [refactor](remove broker scan node) it is not useful any more

yiguolei merged PR #16128: URL: https://github.com/apache/doris/pull/16128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #16128: [refactor](remove broker scan node) it is not useful any more

github-actions[bot] commented on PR #16128: URL: https://github.com/apache/doris/pull/16128#issuecomment-1400198191 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16132: [fix](datetimev2) fix cast to datetimev2 return wrong result

github-actions[bot] commented on PR #16132: URL: https://github.com/apache/doris/pull/16132#issuecomment-1400104063 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [feature-wip](aggregate-function) support funtion group_uniq_array

github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1400092876 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16132: [fix](datetimev2) fix cast to datetimev2 return wrong result

github-actions[bot] commented on PR #16132: URL: https://github.com/apache/doris/pull/16132#issuecomment-1400054961 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman closed pull request #16017: Revert "[enhancement](rewrite) Remove unused wide common factors to improve scan performance in ExtractCommonFactorsRule"

morningman closed pull request #16017: Revert "[enhancement](rewrite) Remove unused wide common factors to improve scan performance in ExtractCommonFactorsRule" URL: https://github.com/apache/doris/pull/16017 -- This is an automated message from the Apache Git Service. To respond to the mess

[doris] branch master updated (ab04a458aa -> 61fccc88d7)

This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from ab04a458aa [Enhancement](export) cancel all running coordinators when execute cancel-export statement. (#15801)

[GitHub] [doris] chenlinzhong closed pull request #15544: [mtmv](ut) add mtmv ut

chenlinzhong closed pull request #15544: [mtmv](ut) add mtmv ut URL: https://github.com/apache/doris/pull/15544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [doris] github-actions[bot] commented on pull request #16132: [fix](datetimev2) fix cast to datetimev2 return wrong result

github-actions[bot] commented on PR #16132: URL: https://github.com/apache/doris/pull/16132#issuecomment-1399989371 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16128: [refactor](remove broker scan node) it is not useful any more

github-actions[bot] commented on PR #16128: URL: https://github.com/apache/doris/pull/16128#issuecomment-1399951668 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yiguolei closed issue #15951: [Bug] 基础函数rank()开窗排序结果错误

yiguolei closed issue #15951: [Bug] 基础函数rank()开窗排序结果错误 URL: https://github.com/apache/doris/issues/15951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [doris] yiguolei merged pull request #16074: [vectorized](analytic) fix analytic node of window function get wrong…

yiguolei merged PR #16074: URL: https://github.com/apache/doris/pull/16074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa