[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9736: [bugfix] fix memleaks reported by ASAN

2022-05-22 Thread GitBox
HappenLee commented on code in PR #9736: URL: https://github.com/apache/incubator-doris/pull/9736#discussion_r879079416 ## be/src/vec/exprs/vexpr.h: ## @@ -108,7 +108,13 @@ class VExpr { VExpr* parent, int* node_idx, VExpr** root_expr,

[GitHub] [incubator-doris] morningman commented on pull request #9694: [Bug] Fix create table like when having hidden columns

2022-05-22 Thread GitBox
morningman commented on PR #9694: URL: https://github.com/apache/incubator-doris/pull/9694#issuecomment-1134250748 Please rebase the master to solve the BE format check error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9734: [Bug] [Vectorized] add padding when load char type data

2022-05-22 Thread GitBox
cambyzju commented on code in PR #9734: URL: https://github.com/apache/incubator-doris/pull/9734#discussion_r879076822 ## be/src/vec/olap/olap_data_convertor.cpp: ## @@ -372,6 +372,21 @@ Status OlapBlockDataConvertor::OlapColumnDataConvertorChar::convert_to_olap() { asse

[GitHub] [incubator-doris] jackwener commented on a diff in pull request #8513: [Bug] fix don't rewrite nested union statement bug

2022-05-22 Thread GitBox
jackwener commented on code in PR #8513: URL: https://github.com/apache/incubator-doris/pull/8513#discussion_r879075198 ## fe/fe-core/src/main/java/org/apache/doris/analysis/StmtRewriter.java: ## @@ -320,11 +320,16 @@ private static SelectList addMissingAggregationColumns(Selec

[GitHub] [incubator-doris] nextdreamblue commented on pull request #9694: [Bug] Fix create table like when having hidden columns

2022-05-22 Thread GitBox
nextdreamblue commented on PR #9694: URL: https://github.com/apache/incubator-doris/pull/9694#issuecomment-1134247889 @yiguolei i reproduce this bug like this : MySQL [abc]> ADMIN SET FRONTEND CONFIG ("enable_batch_delete_by_default" = "true"); Query OK, 0 rows affected

[GitHub] [incubator-doris] yiguolei commented on pull request #9735: [vec][opt] opt hash join build resize hash table before insert data

2022-05-22 Thread GitBox
yiguolei commented on PR #9735: URL: https://github.com/apache/incubator-doris/pull/9735#issuecomment-1134241699 #9069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [incubator-doris] yym12 closed issue #9504: [Feature] Doris data Export

2022-05-22 Thread GitBox
yym12 closed issue #9504: [Feature] Doris data Export URL: https://github.com/apache/incubator-doris/issues/9504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [incubator-doris] jacktengg opened a new pull request, #9736: [bugfix] fix memleaks reported by ASAN

2022-05-22 Thread GitBox
jacktengg opened a new pull request, #9736: URL: https://github.com/apache/incubator-doris/pull/9736 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav

[incubator-doris] branch master updated: [doc]Add SQL Select usage help documentation (#9729)

2022-05-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new fdd5bc07a9 [doc]Add SQL Select usage

[GitHub] [incubator-doris] yiguolei merged pull request #9729: [doc]Add SQL Select usage help documentation

2022-05-22 Thread GitBox
yiguolei merged PR #9729: URL: https://github.com/apache/incubator-doris/pull/9729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] yiguolei commented on pull request #9717: Bump gson from 2.8.6 to 2.8.9 in /fe

2022-05-22 Thread GitBox
yiguolei commented on PR #9717: URL: https://github.com/apache/incubator-doris/pull/9717#issuecomment-1134199713 Not need, close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] yiguolei closed pull request #9717: Bump gson from 2.8.6 to 2.8.9 in /fe

2022-05-22 Thread GitBox
yiguolei closed pull request #9717: Bump gson from 2.8.6 to 2.8.9 in /fe URL: https://github.com/apache/incubator-doris/pull/9717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-doris] dependabot[bot] commented on pull request #9717: Bump gson from 2.8.6 to 2.8.9 in /fe

2022-05-22 Thread GitBox
dependabot[bot] commented on PR #9717: URL: https://github.com/apache/incubator-doris/pull/9717#issuecomment-1134199734 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor vers

[GitHub] [incubator-doris] yiguolei commented on pull request #9735: [vec][opt] opt hash join build resize hash table before insert data

2022-05-22 Thread GitBox
yiguolei commented on PR #9735: URL: https://github.com/apache/incubator-doris/pull/9735#issuecomment-1134199505 #9732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[incubator-doris] branch master updated: [Bug-Fix][Vectorized] Full join return error result (#9690)

2022-05-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 500c36717d [Bug-Fix][Vectorized] Full

[GitHub] [incubator-doris] yiguolei closed issue #9687: [Bug] [Vectorized] Full join get error result

2022-05-22 Thread GitBox
yiguolei closed issue #9687: [Bug] [Vectorized] Full join get error result URL: https://github.com/apache/incubator-doris/issues/9687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [incubator-doris] yiguolei merged pull request #9690: [Bug-Fix][Vectorized] Full join return error result

2022-05-22 Thread GitBox
yiguolei merged PR #9690: URL: https://github.com/apache/incubator-doris/pull/9690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9735: [vec][opt] opt hash join build resize hash table before insert data

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9735: URL: https://github.com/apache/incubator-doris/pull/9735#issuecomment-1134198718 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9735: [vec][opt] opt hash join build resize hash table before insert data

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9735: URL: https://github.com/apache/incubator-doris/pull/9735#issuecomment-1134198738 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] HappenLee opened a new pull request, #9735: [vec][opt] opt hash join build resize hash table before insert data

2022-05-22 Thread GitBox
HappenLee opened a new pull request, #9735: URL: https://github.com/apache/incubator-doris/pull/9735 # Proposed changes Issue Number: close #9069 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] ccoffline commented on a diff in pull request #9705: [Bug] Fix disk used pct only consider the data that used by Doris

2022-05-22 Thread GitBox
ccoffline commented on code in PR #9705: URL: https://github.com/apache/incubator-doris/pull/9705#discussion_r879019111 ## fe/fe-core/src/main/java/org/apache/doris/clone/BackendLoadStatistic.java: ## @@ -187,7 +187,7 @@ public void init() throws LoadBalanceException {

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request, #9734: [Bug] [Vectorized] add padding when load char type data

2022-05-22 Thread GitBox
BiteThet opened a new pull request, #9734: URL: https://github.com/apache/incubator-doris/pull/9734 # Proposed changes Issue Number: close #9733 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original b

[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue, #9733: [Bug] [Vectorized] add padding when load char type data

2022-05-22 Thread GitBox
BiteThet opened a new issue, #9733: URL: https://github.com/apache/incubator-doris/issues/9733 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version m

[GitHub] [incubator-doris] stalary commented on a diff in pull request #9728: [Bug] If function adds type inference

2022-05-22 Thread GitBox
stalary commented on code in PR #9728: URL: https://github.com/apache/incubator-doris/pull/9728#discussion_r879009771 ## fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java: ## @@ -869,6 +869,11 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisE

[incubator-doris] branch master updated: Fix some typos in fe/. (#9682)

2022-05-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 77297bb7ee Fix some typos in fe/. (#9

[GitHub] [incubator-doris] yiguolei merged pull request #9682: Fix some typos in fe/.

2022-05-22 Thread GitBox
yiguolei merged PR #9682: URL: https://github.com/apache/incubator-doris/pull/9682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] yiguolei merged pull request #9710: [typo] Fix typos in comments

2022-05-22 Thread GitBox
yiguolei merged PR #9710: URL: https://github.com/apache/incubator-doris/pull/9710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [typo] Fix typos in comments (#9710)

2022-05-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 5b13fa2b15 [typo] Fix typos in commen

[GitHub] [incubator-doris] englefly opened a new pull request, #9732: [optimize] init join hash table size by rows before hash table building

2022-05-22 Thread GitBox
englefly opened a new pull request, #9732: URL: https://github.com/apache/incubator-doris/pull/9732 # Proposed changes Initialize hash table size by the tuple number instead of fixed number 1024 to reduce BuildTableExpanseTime. test result: After initialize table size, the total bui

[incubator-doris] branch master updated: [doc] Update dev image (#9721)

2022-05-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ddda91c89d [doc] Update dev image (#9

[GitHub] [incubator-doris] yiguolei merged pull request #9721: [doc] Update dev image

2022-05-22 Thread GitBox
yiguolei merged PR #9721: URL: https://github.com/apache/incubator-doris/pull/9721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] yiguolei commented on pull request #9726: [feature](function) Add nvl function

2022-05-22 Thread GitBox
yiguolei commented on PR #9726: URL: https://github.com/apache/incubator-doris/pull/9726#issuecomment-1134147139 Please add regression test。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r879005535 ## be/src/util/faststring.h: ## @@ -82,7 +82,7 @@ class faststring { OwnedSlice build() { uint8_t* ret = data_; if (ret == initial_data_)

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r879004925 ## be/src/util/faststring.cc: ## @@ -37,18 +37,20 @@ void faststring::GrowToAtLeast(size_t newcapacity) { void faststring::GrowArray(size_t newcapacity) {

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r878998363 ## be/src/util/faststring.cc: ## @@ -37,18 +37,20 @@ void faststring::GrowToAtLeast(size_t newcapacity) { void faststring::GrowArray(size_t newcapacity) {

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r878995037 ## be/src/util/faststring.cc: ## @@ -37,18 +37,20 @@ void faststring::GrowToAtLeast(size_t newcapacity) { void faststring::GrowArray(size_t newcapacity) {

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r87996 ## be/src/util/faststring.cc: ## @@ -57,14 +59,14 @@ void faststring::ShrinkToFitInternal() { if (len_ <= kInitialCapacity) { ASAN_UNPOISON_MEMORY

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r87824 ## be/src/util/faststring.cc: ## @@ -57,14 +59,14 @@ void faststring::ShrinkToFitInternal() { if (len_ <= kInitialCapacity) { ASAN_UNPOISON_MEMORY

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r878998363 ## be/src/util/faststring.cc: ## @@ -37,18 +37,20 @@ void faststring::GrowToAtLeast(size_t newcapacity) { void faststring::GrowArray(size_t newcapacity) {

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r878995037 ## be/src/util/faststring.cc: ## @@ -37,18 +37,20 @@ void faststring::GrowToAtLeast(size_t newcapacity) { void faststring::GrowArray(size_t newcapacity) {

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9290: [Enhancement](Vectorized)build hash table with new thread, as non-vec…

2022-05-22 Thread GitBox
yiguolei commented on code in PR #9290: URL: https://github.com/apache/incubator-doris/pull/9290#discussion_r878991830 ## be/src/vec/exec/join/vhash_join_node.cpp: ## @@ -956,10 +956,44 @@ Status HashJoinNode::open(RuntimeState* state) { RETURN_IF_ERROR((*_vother_join_c

[GitHub] [incubator-doris] zhengshengjun commented on issue #9711: [Bug] time_round function calculated wrong timestamp

2022-05-22 Thread GitBox
zhengshengjun commented on issue #9711: URL: https://github.com/apache/incubator-doris/issues/9711#issuecomment-1134113894 @BiteThet Thanks for pointing out this mistake, I'd thought the second parameter was something like "time shift". So the above cases are all right. And I lo

[GitHub] [incubator-doris] SaintBacchus commented on a diff in pull request #9725: [Enhancement] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-22 Thread GitBox
SaintBacchus commented on code in PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#discussion_r878984613 ## fe/fe-core/src/main/java/org/apache/doris/common/profile/InMemoryProfileStorage.java: ## @@ -0,0 +1,159 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] SaintBacchus commented on a diff in pull request #9725: [Enhancement] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-22 Thread GitBox
SaintBacchus commented on code in PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#discussion_r878981108 ## fe/fe-core/src/main/java/org/apache/doris/common/util/ProfileManager.java: ## @@ -104,160 +90,60 @@ public static ProfileManager getInstance() { }

[GitHub] [incubator-doris] SaintBacchus commented on a diff in pull request #9725: [Enhancement] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-22 Thread GitBox
SaintBacchus commented on code in PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#discussion_r878979650 ## fe/fe-core/src/main/java/org/apache/doris/common/Pair.java: ## @@ -22,14 +22,15 @@ import com.google.gson.annotations.SerializedName; +import java.i

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9069: resize hash table before building

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9069: URL: https://github.com/apache/incubator-doris/pull/9069#issuecomment-1134096252 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9069: resize hash table before building

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9069: URL: https://github.com/apache/incubator-doris/pull/9069#issuecomment-1134096229 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] hf200012 opened a new issue, #9731: [Bug] Query export exception after enabling vectorization

2022-05-22 Thread GitBox
hf200012 opened a new issue, #9731: URL: https://github.com/apache/incubator-doris/issues/9731 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.0

[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9728: [Bug] If function adds type inference

2022-05-22 Thread GitBox
cambyzju commented on code in PR #9728: URL: https://github.com/apache/incubator-doris/pull/9728#discussion_r878971202 ## fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java: ## @@ -869,6 +869,11 @@ public void analyzeImpl(Analyzer analyzer) throws Analysis

[GitHub] [incubator-doris] hf200012 opened a new pull request, #9729: [doc]Add SQL Select usage help documentation

2022-05-22 Thread GitBox
hf200012 opened a new pull request, #9729: URL: https://github.com/apache/incubator-doris/pull/9729 Add SQL Select usage help documentation # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Require

[GitHub] [incubator-doris] pengxiangyu closed pull request #9678: add tablet erros when close_wait return error

2022-05-22 Thread GitBox
pengxiangyu closed pull request #9678: add tablet erros when close_wait return error URL: https://github.com/apache/incubator-doris/pull/9678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-doris] starocean999 commented on issue #9606: [Bug] "insert into TABLE select ..." failed when enable_vectorized_engine=true

2022-05-22 Thread GitBox
starocean999 commented on issue #9606: URL: https://github.com/apache/incubator-doris/issues/9606#issuecomment-1134064738 same root cause and already fixed by https://github.com/apache/incubator-doris/pull/9569 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile

2022-05-22 Thread GitBox
xinyiZzz commented on code in PR #9661: URL: https://github.com/apache/incubator-doris/pull/9661#discussion_r878959916 ## build.sh: ## @@ -212,6 +212,9 @@ fi if [[ -z ${STRIP_DEBUG_INFO} ]]; then STRIP_DEBUG_INFO=OFF fi +if [[ -z ${USE_MEM_TRACKER} ]]; then Review Commen

[GitHub] [incubator-doris] stalary commented on a diff in pull request #9725: [Enhancement] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-22 Thread GitBox
stalary commented on code in PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#discussion_r878959299 ## fe/fe-core/src/main/java/org/apache/doris/common/util/ProfileManager.java: ## @@ -104,160 +90,60 @@ public static ProfileManager getInstance() { }

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9728: [Bug] If function adds type inference

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9728: URL: https://github.com/apache/incubator-doris/pull/9728#issuecomment-1134046031 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9728: [Bug] If function adds type inference

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9728: URL: https://github.com/apache/incubator-doris/pull/9728#issuecomment-1134046006 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] stalary opened a new pull request, #9728: [Bug] If function adds type inference

2022-05-22 Thread GitBox
stalary opened a new pull request, #9728: URL: https://github.com/apache/incubator-doris/pull/9728 # Proposed changes Issue Number: close https://github.com/apache/incubator-doris/issues/9662 ## Problem Summary: Describe the overview of changes. ## Checklist(Requir

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9700: [doc] Add manual for Array data type and functions

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9700: URL: https://github.com/apache/incubator-doris/pull/9700#issuecomment-1134017554 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9700: [doc] Add manual for Array data type and functions

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9700: URL: https://github.com/apache/incubator-doris/pull/9700#issuecomment-1134017565 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] hf200012 commented on pull request #9726: [feature](function) Add nvl function

2022-05-22 Thread GitBox
hf200012 commented on PR #9726: URL: https://github.com/apache/incubator-doris/pull/9726#issuecomment-1134016046 Add the function documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9721: [doc] Update dev image

2022-05-22 Thread GitBox
github-actions[bot] commented on PR #9721: URL: https://github.com/apache/incubator-doris/pull/9721#issuecomment-1134015550 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] dataroaring opened a new pull request, #9727: [opt] avoid memcpy when building page

2022-05-22 Thread GitBox
dataroaring opened a new pull request, #9727: URL: https://github.com/apache/incubator-doris/pull/9727 PageBuilder finishes a page when the page is full, when the page is full, its size is greater than page size, so the last row would trigger an memcpy due to there is not enough space i

[GitHub] [incubator-doris] dataalive commented on issue #9603: [Bug] doris version 0.15.0 help broker load command demo bug

2022-05-22 Thread GitBox
dataalive commented on issue #9603: URL: https://github.com/apache/incubator-doris/issues/9603#issuecomment-1133919130 the latest doc has fixed the comma that left on 'hdfs_user' but change ```hdfs_user``` to `username` is not correct. with broker we use `username` and `passwo

[GitHub] [incubator-doris] morningman commented on issue #9032: [Bug] Compaction leads to schema change error

2022-05-22 Thread GitBox
morningman commented on issue #9032: URL: https://github.com/apache/incubator-doris/issues/9032#issuecomment-1133917452 I think can do this to fix the issue: When the compaction finished, check if the input rowset still available in tablet, if not, the compaction will be failed. --

[GitHub] [incubator-doris] morningman commented on a diff in pull request #9065: [fix](storage) Disable compaction before schema change is actually executed(#9032)

2022-05-22 Thread GitBox
morningman commented on code in PR #9065: URL: https://github.com/apache/incubator-doris/pull/9065#discussion_r878881881 ## be/src/olap/compaction.cpp: ## @@ -114,7 +114,7 @@ Status Compaction::do_compaction_impl(int64_t permits) { TRACE("check correctness finished");

[incubator-doris] 02/13: [fix](broker-scan-node) Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior. (#9190)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 131a0ac56e5cb4c06122b99be63021199f9a72e4 Author: Jibing-Li <64681310+jibing...@users.noreply.github.com>

[incubator-doris] 13/13: [improvement](planner) Backfill the original predicate pushdown code (#9703)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 25ee329f52dbe0d5d11f561d3838f917529e8f81 Author: zhengshiJ <32082872+zhengs...@users.noreply.github.com>

[incubator-doris] 04/13: [fix] UT MathFunctionTest.round_test fix (#9447)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 2cc31df3c53071226f1c2d5bce9c702c3f744bfa Author: camby <104178...@qq.com> AuthorDate: Mon May 9 09:37:27

[incubator-doris] 11/13: [config](checksum) Disable consistency checker by default (#9699)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit c4c436453495d293c700e10bd0aced53b38f86be Author: Mingyu Chen AuthorDate: Sun May 22 21:31:43 2022 +0800

[incubator-doris] 07/13: [deps] libhdfs3 build enable kerberos support (#9524)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 8a375dcafb27e962e73fe757484a24286e38c515 Author: gtchaos AuthorDate: Sun May 22 20:58:19 2022 +0800

[incubator-doris] 01/13: [improvement](stream-load) adjust read unit of http to optimize stream load (#9154)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit b6489024a0e7dd837e5dbc3736d03fdbe446f160 Author: Yongqiang YANG <98214048+dataroar...@users.noreply.githu

[incubator-doris] 12/13: [refactor](fe): remove unused code (#8986)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 05bd5c82f9dc9ef092610e5bd3507d263111ef09 Author: jakevin <30525741+jackwe...@users.noreply.github.com> Au

[incubator-doris] 09/13: [FeConfig](Project) Project optimization is enabled by default (#9667)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit b28b77a32f506e06491ed2a74814809665e2b0c3 Author: EmmyMiao87 <522274...@qq.com> AuthorDate: Thu May 19 14:

[incubator-doris] 05/13: [Enhancement] improve parquet reader via arrow's prefetch and multi thread (#9472)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 571608dee59742811864ccc9bc161c6ae4fabd67 Author: Lightman <31928846+lchangli...@users.noreply.github.com>

[incubator-doris] 03/13: [Feature] CTAS support insert data (#9271)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 733fb3a92af8b0180e8e52f49d7a390479c608d7 Author: Stalary <452024...@qq.com> AuthorDate: Sat May 7 08:51:5

[incubator-doris] 08/13: [refactor](load) add tablet errors when close_wait return error (#9619)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 0e38fa4e9d4b18746987560d84f8b44c59501fa0 Author: pengxiangyu AuthorDate: Sun May 22 21:27:42 2022 +0800

[incubator-doris] 06/13: [Bug][Vectorized] fix schema change add varchar type column default value get wrong result (#9523)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 8490c3890662ff9d108533446138cec2e4050857 Author: Pxl AuthorDate: Thu May 19 23:38:57 2022 +0800 [Bu

[incubator-doris] branch dev-1.0.1 updated (727f08ca5b -> 25ee329f52)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git from 727f08ca5b [fix](planner) unnecessary cast will be added on children in CaseExpr sometimes (#9600)

[incubator-doris] 10/13: [fix] NullPredicate should implement evaluate_vec (#9689)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit e52e27ba6636640931abf97b69cc3d646e642795 Author: Yongqiang YANG <98214048+dataroar...@users.noreply.githu

[GitHub] [incubator-doris] nextdreamblue commented on issue #9539: [Bug] CREATE TABLE LIKE Exception

2022-05-22 Thread GitBox
nextdreamblue commented on issue #9539: URL: https://github.com/apache/incubator-doris/issues/9539#issuecomment-1133909959 @stalary i think it is a bug, please check it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[incubator-doris] branch master updated (d8f1b77cc1 -> d97e2b1eb2)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git from d8f1b77cc1 [improvement](planner) Backfill the original predicate pushdown code (#9703) add d97e2b1

[GitHub] [incubator-doris] morningman merged pull request #9718: [DOCS] update docs for FE UT

2022-05-22 Thread GitBox
morningman merged PR #9718: URL: https://github.com/apache/incubator-doris/pull/9718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-doris] branch master updated: [improvement](planner) Backfill the original predicate pushdown code (#9703)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new d8f1b77cc1 [improvement](planner) B

[GitHub] [incubator-doris] morningman merged pull request #9703: [improvement](planner) Backfill the original predicate pushdown code

2022-05-22 Thread GitBox
morningman merged PR #9703: URL: https://github.com/apache/incubator-doris/pull/9703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-doris] branch master updated: [doc] Add trim_tailing_spaces_for_external_table_query variable to the docs. (#9701)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 3768fdd3f8 [doc] Add trim_tailing_s

[GitHub] [incubator-doris] morningman merged pull request #9701: [doc] Add trim_tailing_spaces_for_external_table_query variable to the docs.

2022-05-22 Thread GitBox
morningman merged PR #9701: URL: https://github.com/apache/incubator-doris/pull/9701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-doris] branch master updated (ad4da4aa8f -> d270f4f2d4)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git from ad4da4aa8f [doc] Fix typos in documentation (#9692) add d270f4f2d4 [config](checksum) Disable consis

[GitHub] [incubator-doris] morningman merged pull request #9699: [config](checksum) Disable consistency checker by default

2022-05-22 Thread GitBox
morningman merged PR #9699: URL: https://github.com/apache/incubator-doris/pull/9699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [incubator-doris] morningman commented on pull request #9697: [fix]Documentation fixes

2022-05-22 Thread GitBox
morningman commented on PR #9697: URL: https://github.com/apache/incubator-doris/pull/9697#issuecomment-1133897338 @hf200012 Please rebase the master to see if the BE code formatter check can pass -- This is an automated message from the Apache Git Service. To respond to the message, plea

[incubator-doris] branch master updated: [doc] Fix typos in documentation (#9692)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ad4da4aa8f [doc] Fix typos in docum

[GitHub] [incubator-doris] morningman merged pull request #9692: [Docs]Fix typos in documentation

2022-05-22 Thread GitBox
morningman merged PR #9692: URL: https://github.com/apache/incubator-doris/pull/9692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-doris] branch master updated (75b3707a28 -> c13a6a1d8a)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git from 75b3707a28 [refactor](load) add tablet errors when close_wait return error (#9619) add c13a6a1d8a [

[GitHub] [incubator-doris] morningman merged pull request #9689: [fix] NullPredicate should implement evaluate_vec

2022-05-22 Thread GitBox
morningman merged PR #9689: URL: https://github.com/apache/incubator-doris/pull/9689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [incubator-doris] morningman merged pull request #9619: add tablet erros when close_wait return error

2022-05-22 Thread GitBox
morningman merged PR #9619: URL: https://github.com/apache/incubator-doris/pull/9619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-doris] branch master updated: [refactor](load) add tablet errors when close_wait return error (#9619)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 75b3707a28 [refactor](load) add tab

[incubator-doris] branch master updated: [Refactor] simplify some code in routine load (#9532)

2022-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 3391de482b [Refactor] simplify some

[GitHub] [incubator-doris] morningman merged pull request #9532: [Refactor] simplify some code in routine load

2022-05-22 Thread GitBox
morningman merged PR #9532: URL: https://github.com/apache/incubator-doris/pull/9532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [incubator-doris] morningman commented on a diff in pull request #9485: [Tiny-fix] Add show user stmt impl.

2022-05-22 Thread GitBox
morningman commented on code in PR #9485: URL: https://github.com/apache/incubator-doris/pull/9485#discussion_r878861603 ## docs/zh-CN/sql-manual/sql-reference/Show-Statements/SHOW-USER.md: ## @@ -31,9 +31,19 @@ under the License. SHOW USER ### Description +该语句用于展示当前登录用户的用户名

[GitHub] [incubator-doris] morningman commented on a diff in pull request #9459: [stream-load-vec]: memtable flush only if necessary after aggregated

2022-05-22 Thread GitBox
morningman commented on code in PR #9459: URL: https://github.com/apache/incubator-doris/pull/9459#discussion_r878861395 ## be/src/common/config.h: ## @@ -464,6 +464,8 @@ CONF_Int32(memory_max_alignment, "16"); // write buffer size before flush CONF_mInt64(write_buffer_size, "

[GitHub] [incubator-doris] sumtumn opened a new pull request, #9726: [feature](function) Add nvl function

2022-05-22 Thread GitBox
sumtumn opened a new pull request, #9726: URL: https://github.com/apache/incubator-doris/pull/9726 # Proposed changes Add nvl function support. ## Problem Summary: Add nvl function support: just make ifnull alias. ## Checklist(Required) 1. Does it affect the

  1   2   >