[GitHub] [incubator-doris] hf200012 opened a new pull request, #9723: [typo][Doc]Add insert best practices

2022-05-21 Thread GitBox
hf200012 opened a new pull request, #9723: URL: https://github.com/apache/incubator-doris/pull/9723 Add insert best practices # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. D

[incubator-doris-website] branch master updated: 1

2022-05-21 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git The following commit(s) were added to refs/heads/master by this push: new 4f5bf50440 1 4f5bf50440 i

[GitHub] [incubator-doris] dataroaring opened a new pull request, #9722: teach BufferedBlockMgr2 track memory right

2022-05-21 Thread GitBox
dataroaring opened a new pull request, #9722: URL: https://github.com/apache/incubator-doris/pull/9722 The problem was introduced by e2d3d0134eee5d50b6619fd9194a2e5f9cb557dc. # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of c

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9716: [Bug] [Bitmap] change to_bitmap to always_not_nullable

2022-05-21 Thread GitBox
HappenLee commented on code in PR #9716: URL: https://github.com/apache/incubator-doris/pull/9716#discussion_r878789019 ## be/src/vec/functions/function_bitmap.cpp: ## @@ -45,17 +45,16 @@ struct ToBitmap { auto size = offsets.size(); res.reserve(size);

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9700: [doc] Add manual for Array data type and functions

2022-05-21 Thread GitBox
HappenLee commented on code in PR #9700: URL: https://github.com/apache/incubator-doris/pull/9700#discussion_r878788787 ## docs/zh-CN/sql-manual/sql-functions/array-functions/array_position.md: ## @@ -0,0 +1,65 @@ +--- +{ +"title": "array_position", +"language": "zh-CN"

[incubator-doris] branch master updated: [Refactor] add vpre_filter_expr for vectorized to improve performance (#9508)

2022-05-21 Thread lihaopeng
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 31e40191a8 [Refactor] add vpre_filte

[GitHub] [incubator-doris] HappenLee merged pull request #9508: [Refactor] add vpre_filter_expr for vectorized to improve performance

2022-05-21 Thread GitBox
HappenLee merged PR #9508: URL: https://github.com/apache/incubator-doris/pull/9508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [incubator-doris] adonis0147 commented on pull request #9708: [refactor][be] Optimize headers

2022-05-21 Thread GitBox
adonis0147 commented on PR #9708: URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1133809871 Hi @BiteThet , thank you for reminding me and I fixed the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9721: [doc] Update dev image

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9721: URL: https://github.com/apache/incubator-doris/pull/9721#issuecomment-1133796951 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9721: [doc] Update dev image

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9721: URL: https://github.com/apache/incubator-doris/pull/9721#issuecomment-1133796945 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9485: [Tiny-fix] Add show user stmt impl.

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9485: URL: https://github.com/apache/incubator-doris/pull/9485#issuecomment-1133796821 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman opened a new pull request, #9721: [doc] Update dev image

2022-05-21 Thread GitBox
morningman opened a new pull request, #9721: URL: https://github.com/apache/incubator-doris/pull/9721 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] morningman opened a new pull request, #9720: [improvement] Optimize send fragment logic to reduce send fragment timeout error

2022-05-21 Thread GitBox
morningman opened a new pull request, #9720: URL: https://github.com/apache/incubator-doris/pull/9720 # Proposed changes Issue Number: close #xxx ## Problem Summary: This CL mainly changes: 1. Merge multiple fragment instances on the same BE to send requests to reduce

[GitHub] [incubator-doris] jackwener commented on pull request #3912: [Code Refactor]Remove some redundant code

2022-05-21 Thread GitBox
jackwener commented on PR #3912: URL: https://github.com/apache/incubator-doris/pull/3912#issuecomment-1133647258 Very sorry for that it's a little late.😭 I find this PR is still valid. If you are willing to promote this PR. I'd like to review it and push it to be merged. BTW, Thanks

[GitHub] [incubator-doris] jackwener closed pull request #1627: fix backends disk error statistics issue

2022-05-21 Thread GitBox
jackwener closed pull request #1627: fix backends disk error statistics issue URL: https://github.com/apache/incubator-doris/pull/1627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [incubator-doris] jackwener commented on pull request #1627: fix backends disk error statistics issue

2022-05-21 Thread GitBox
jackwener commented on PR #1627: URL: https://github.com/apache/incubator-doris/pull/1627#issuecomment-1133645435 It's expired PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9485: [Tiny-fix] Add show user stmt impl.

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9485: URL: https://github.com/apache/incubator-doris/pull/9485#issuecomment-1133645012 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9508: [Refactor] add vpre_filter_expr for vectorized to improve performance

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9508: URL: https://github.com/apache/incubator-doris/pull/9508#issuecomment-1133641353 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9508: [Refactor] add vpre_filter_expr for vectorized to improve performance

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9508: URL: https://github.com/apache/incubator-doris/pull/9508#issuecomment-1133641348 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] BiteTheDDDDt commented on issue #9711: [Bug] time_round function calculated wrong timestamp

2022-05-21 Thread GitBox
BiteThet commented on issue #9711: URL: https://github.com/apache/incubator-doris/issues/9711#issuecomment-1133607520 > > > > > > > > > Isn't the floor rounded down? like floor(0.6)=0 > > @BiteThet Yes, floor meas rounded down, and the second parameter in `day_flo

[GitHub] [incubator-doris] zhengshengjun commented on issue #9711: [Bug] time_round function calculated wrong timestamp

2022-05-21 Thread GitBox
zhengshengjun commented on issue #9711: URL: https://github.com/apache/incubator-doris/issues/9711#issuecomment-1133605961 > > > > Isn't the floor rounded down? like floor(0.6)=0 @BiteThet Yes, floor meas rounded down, and the second parameter in `day_floor('2022-05-03 13

[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9708: [refactor][be] Optimize headers

2022-05-21 Thread GitBox
BiteThet commented on PR #9708: URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1133597520 ```cpp [18:27:13] [Step 1/1] FAILED: test/CMakeFiles/doris_be_test.dir/runtime/collection_value_test.cpp.o [18:27:13] [Step 1/1] ccache /var/local/ldb-toolchain/b

[GitHub] [incubator-doris] liaoxin01 commented on pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-21 Thread GitBox
liaoxin01 commented on PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#issuecomment-1133588679 > We should support schema change on decimal column between different precision and scale which is not done in this PR. Yes, we should support it. I plan to write the sch

[GitHub] [incubator-doris] liaoxin01 commented on a diff in pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-21 Thread GitBox
liaoxin01 commented on code in PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r878672704 ## be/src/vec/columns/column.h: ## @@ -183,6 +183,11 @@ class IColumn : public COW { /// All data will be inserted as single element virtual void ins

[GitHub] [incubator-doris] liaoxin01 commented on a diff in pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-21 Thread GitBox
liaoxin01 commented on code in PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r878672704 ## be/src/vec/columns/column.h: ## @@ -183,6 +183,11 @@ class IColumn : public COW { /// All data will be inserted as single element virtual void ins

[GitHub] [incubator-doris] Gabriel39 opened a new issue, #9719: [Bug] core dump when select from table

2022-05-21 Thread GitBox
Gabriel39 opened a new issue, #9719: URL: https://github.com/apache/incubator-doris/issues/9719 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version trun

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9697: [fix]Documentation fixes

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9697: URL: https://github.com/apache/incubator-doris/pull/9697#issuecomment-1133563776 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9697: [fix]Documentation fixes

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9697: URL: https://github.com/apache/incubator-doris/pull/9697#issuecomment-1133563781 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9718: [DOCS] update docs for FE UT

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9718: URL: https://github.com/apache/incubator-doris/pull/9718#issuecomment-1133558212 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9718: [DOCS] update docs for FE UT

2022-05-21 Thread GitBox
github-actions[bot] commented on PR #9718: URL: https://github.com/apache/incubator-doris/pull/9718#issuecomment-1133558207 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] Gabriel39 opened a new pull request, #9718: [DOCS] update docs for FE UT

2022-05-21 Thread GitBox
Gabriel39 opened a new pull request, #9718: URL: https://github.com/apache/incubator-doris/pull/9718 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav