[GitHub] [incubator-doris] caiconghui commented on a change in pull request #6384: [Optimize] Speed up converting the data of other type to string in mysql_result_writer

2021-08-16 Thread GitBox
caiconghui commented on a change in pull request #6384: URL: https://github.com/apache/incubator-doris/pull/6384#discussion_r690086354 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/Planner.java ## @@ -101,9 +101,7 @@ private void setResultExprScale(Analyzer an

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6436: Fix the problem that there may be redundant retries when the query result export fails

2021-08-16 Thread GitBox
github-actions[bot] commented on pull request #6436: URL: https://github.com/apache/incubator-doris/pull/6436#issuecomment-900042296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] morningman commented on a change in pull request #6384: [Optimize] Speed up converting the data of other type to string in mysql_result_writer

2021-08-16 Thread GitBox
morningman commented on a change in pull request #6384: URL: https://github.com/apache/incubator-doris/pull/6384#discussion_r690084612 ## File path: be/test/util/date_func_test.cpp ## @@ -0,0 +1,59 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [incubator-doris] morningman commented on a change in pull request #6384: [Optimize] Speed up converting the data of other type to string in mysql_result_writer

2021-08-16 Thread GitBox
morningman commented on a change in pull request #6384: URL: https://github.com/apache/incubator-doris/pull/6384#discussion_r690071874 ## File path: be/src/util/date_func.cpp ## @@ -55,11 +55,55 @@ uint24_t timestamp_from_date(const std::string& date_str) { } std::string ti

[GitHub] [incubator-doris] rufeng97 commented on a change in pull request #6356: Support bitmap(binary) type in hive to import doris

2021-08-16 Thread GitBox
rufeng97 commented on a change in pull request #6356: URL: https://github.com/apache/incubator-doris/pull/6356#discussion_r690078211 ## File path: fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/DppUtils.java ## @@ -90,6 +91,8 @@ public static Class getClassFromCol

[GitHub] [incubator-doris] wangbo commented on pull request #6356: Support bitmap(binary) type in hive to import doris

2021-08-16 Thread GitBox
wangbo commented on pull request #6356: URL: https://github.com/apache/incubator-doris/pull/6356#issuecomment-899988634 Please add ```User Manual``` for this feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6459: [Bug]fix `Wrong use on SCOPED_RAW_TIMER`

2021-08-16 Thread GitBox
github-actions[bot] commented on pull request #6459: URL: https://github.com/apache/incubator-doris/pull/6459#issuecomment-899968569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] spaces-X commented on a change in pull request #6356: Support bitmap(binary) type in hive to import doris

2021-08-16 Thread GitBox
spaces-X commented on a change in pull request #6356: URL: https://github.com/apache/incubator-doris/pull/6356#discussion_r689552040 ## File path: fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/ColumnParser.java ## @@ -71,14 +71,25 @@ public static ColumnParser cr

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6391: Support long text type STRING with a maximum length of 2GB

2021-08-16 Thread GitBox
github-actions[bot] commented on pull request #6391: URL: https://github.com/apache/incubator-doris/pull/6391#issuecomment-899959869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] spaces-X commented on pull request #6453: [Bug] fix(sparkload): bitmap value in `or` operator in spark load should be deep copied

2021-08-16 Thread GitBox
spaces-X commented on pull request #6453: URL: https://github.com/apache/incubator-doris/pull/6453#issuecomment-899950492 > Please add some ut for the `multi-rollups` case. > You can add it to `BitmapValueTest` Done -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] morningman commented on a change in pull request #6391: Support long text type STRING with a maximum length of 2GB

2021-08-16 Thread GitBox
morningman commented on a change in pull request #6391: URL: https://github.com/apache/incubator-doris/pull/6391#discussion_r689987389 ## File path: be/src/exec/olap_rewrite_node.cpp ## @@ -135,18 +135,17 @@ bool OlapRewriteNode::copy_one_row(TupleRow* src_row, Tuple* tuple, M

[GitHub] [incubator-doris] morningman commented on a change in pull request #6457: [enhancement] push down conditions on unique table value columns to base rowset

2021-08-16 Thread GitBox
morningman commented on a change in pull request #6457: URL: https://github.com/apache/incubator-doris/pull/6457#discussion_r689683646 ## File path: be/src/olap/reader.h ## @@ -196,6 +199,7 @@ class Reader { std::vector _is_lower_keys_included; std::vector _is_upper_k

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6449: [Improve]The connector supports spark 3.0, flink 1.13

2021-08-16 Thread GitBox
github-actions[bot] commented on pull request #6449: URL: https://github.com/apache/incubator-doris/pull/6449#issuecomment-899571953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] morningman commented on a change in pull request #6443: [ResourceLimit] Limit CPU resource usage of each query

2021-08-16 Thread GitBox
morningman commented on a change in pull request #6443: URL: https://github.com/apache/incubator-doris/pull/6443#discussion_r689600907 ## File path: gensrc/thrift/PaloInternalService.thrift ## @@ -77,6 +77,10 @@ struct TLoadErrorHubInfo { 3: optional TBrokerErrorHubInfo br

[incubator-doris] branch master updated (b13e512 -> 2f90aaa)

2021-08-16 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from b13e512 [Feature] Support spark connector sink data to Doris (#6256) add 2f90aaa [Doc] flink/spar

[incubator-doris] branch master updated (63a0d9d -> b13e512)

2021-08-16 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 63a0d9d Add statistics struct and Support manually inject statistics (#6420) add b13e512 [Featur

[GitHub] [incubator-doris] morningman merged pull request #6435: [Improvement]flink/spark connector: add sources/javadoc plugins

2021-08-16 Thread GitBox
morningman merged pull request #6435: URL: https://github.com/apache/incubator-doris/pull/6435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman merged pull request #6256: [feature]:support spark connector sink data to doris

2021-08-16 Thread GitBox
morningman merged pull request #6256: URL: https://github.com/apache/incubator-doris/pull/6256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6410: [Feature] Support exact percentile aggregate function

2021-08-16 Thread GitBox
github-actions[bot] commented on pull request #6410: URL: https://github.com/apache/incubator-doris/pull/6410#issuecomment-899565303 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] wangbo commented on a change in pull request #6356: Support bitmap(binary) type in hive to import doris

2021-08-16 Thread GitBox
wangbo commented on a change in pull request #6356: URL: https://github.com/apache/incubator-doris/pull/6356#discussion_r689556140 ## File path: fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/DppUtils.java ## @@ -90,6 +91,8 @@ public static Class getClassFromColum

[GitHub] [incubator-doris] spaces-X commented on a change in pull request #6356: Support bitmap(binary) type in hive to import doris

2021-08-16 Thread GitBox
spaces-X commented on a change in pull request #6356: URL: https://github.com/apache/incubator-doris/pull/6356#discussion_r689552040 ## File path: fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/ColumnParser.java ## @@ -71,14 +71,25 @@ public static ColumnParser cr

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #6459: fix `Wrong use on SCOPED_RAW_TIMER`

2021-08-16 Thread GitBox
BiteThet opened a new pull request #6459: URL: https://github.com/apache/incubator-doris/pull/6459 ## Proposed changes fix https://github.com/apache/incubator-doris/issues/6458 ## Types of changes - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New f

[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #6458: [Bug]Wrong use on SCOPED_RAW_TIMER

2021-08-16 Thread GitBox
BiteThet opened a new issue #6458: URL: https://github.com/apache/incubator-doris/issues/6458 **Describe the bug** `SCOPED_RAW_TIMER` can be used to calculate the time usage in the life cycle. It will only update the time when it is destruct. I found it was used incorrectly in

[GitHub] [incubator-doris] wangbo commented on pull request #6453: [Bug] fix(sparkload): bitmap value in `or` operator in spark load should be deep copied

2021-08-16 Thread GitBox
wangbo commented on pull request #6453: URL: https://github.com/apache/incubator-doris/pull/6453#issuecomment-899459432 Please add some ut for the ```multi-rollups``` case. You can add it to ```BitmapValueTest``` -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] wangbo removed a comment on issue #6452: [Bug] incorrect value in bitmap when spark load with multi-rollup

2021-08-16 Thread GitBox
wangbo removed a comment on issue #6452: URL: https://github.com/apache/incubator-doris/issues/6452#issuecomment-899418712 Please add some ut for the ```multi-rollups``` case. You can add it to ```BitmapValueTest``` -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] yangzhg opened a new pull request #6457: [enhancement] push down conditions on unique table value columns to base rowset

2021-08-16 Thread GitBox
yangzhg opened a new pull request #6457: URL: https://github.com/apache/incubator-doris/pull/6457 ## Proposed changes push down conditions on unique table value columns to base rowset ## Types of changes What types of changes does your code introduce to Doris? _Put an

[GitHub] [incubator-doris] e0c9 opened a new issue #6456: [Proposal] Support prepared statement in doris

2021-08-16 Thread GitBox
e0c9 opened a new issue #6456: URL: https://github.com/apache/incubator-doris/issues/6456 Currently doris does not support prepared statements. For some reason we need to support it: 1. Improve performance when re-using the same statement that you prepared. 2. More importantly, it ef

[GitHub] [incubator-doris] wangbo commented on issue #6452: [Bug] incorrect value in bitmap when spark load with multi-rollup

2021-08-16 Thread GitBox
wangbo commented on issue #6452: URL: https://github.com/apache/incubator-doris/issues/6452#issuecomment-899418712 Please add some ut for the ```multi-rollups``` case. You can add it to ```BitmapValueTest``` -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] wangbo opened a new pull request #6455: (#6454) Remove useless code for Segment V2

2021-08-16 Thread GitBox
wangbo opened a new pull request #6455: URL: https://github.com/apache/incubator-doris/pull/6455 see #6454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [incubator-doris] wangbo opened a new issue #6454: Remove useless code for Segment V2

2021-08-16 Thread GitBox
wangbo opened a new issue #6454: URL: https://github.com/apache/incubator-doris/issues/6454 For segment v2, ```RowBlock2``` 's ```_delete_state``` is useless, ```Delete Logic``` actually works in ```SegmentIterator::next_batch```; In ```BetaRowsetReader::next_block```, when ```RowBloc

[incubator-doris] branch master updated: Add statistics struct and Support manually inject statistics (#6420)

2021-08-16 Thread lingmiao
This is an automated email from the ASF dual-hosted git repository. lingmiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 63a0d9d Add statistics struct and Su

[GitHub] [incubator-doris] EmmyMiao87 merged pull request #6420: Add statistics struct and Support manually inject statistics

2021-08-16 Thread GitBox
EmmyMiao87 merged pull request #6420: URL: https://github.com/apache/incubator-doris/pull/6420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] wuyunfeng commented on pull request #6449: [Improve]The connector supports spark 3.0, flink 1.13

2021-08-16 Thread GitBox
wuyunfeng commented on pull request #6449: URL: https://github.com/apache/incubator-doris/pull/6449#issuecomment-899348972 This is so great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [incubator-doris] spaces-X commented on pull request #6453: [Bug] fix(sparkload): bitmap value in `or` operator in spark load should be deep copied

2021-08-16 Thread GitBox
spaces-X commented on pull request #6453: URL: https://github.com/apache/incubator-doris/pull/6453#issuecomment-899298551 @wangbo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [incubator-doris] spaces-X opened a new pull request #6453: fix(sparkload): bitmap deep copy in `or` operator

2021-08-16 Thread GitBox
spaces-X opened a new pull request #6453: URL: https://github.com/apache/incubator-doris/pull/6453 fix multi rollup hold the same Ref of bitmapvalue which may be updated repeatedly. fix #6452 ## Proposed changes Describe the big picture of your changes here to communicate

[GitHub] [incubator-doris] spaces-X opened a new issue #6452: [Bug] incorrect value in bitmap when spark load with multi-rollup

2021-08-16 Thread GitBox
spaces-X opened a new issue #6452: URL: https://github.com/apache/incubator-doris/issues/6452 Multi-rollups may hold the same Ref of bitmap_value object in spark load etl job, which will cause the bitmap to be updated repeatedly. For example, the baseIndex and Rollups are as