[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #4893: [Metrics][LOG] Add metrics for compaction permits and log for merge rowsets

2020-11-23 Thread GitBox
weizuo93 commented on a change in pull request #4893: URL: https://github.com/apache/incubator-doris/pull/4893#discussion_r529253273 ## File path: be/src/olap/merger.cpp ## @@ -65,6 +65,11 @@ OLAPStatus Merger::merge_rowsets(TabletSharedPtr tablet, RETURN_NOT_OK_LOG(ds

[GitHub] [incubator-doris] gengjun-git commented on issue #4935: Colocate table stays unstable when a large number of be restarts frequently

2020-11-23 Thread GitBox
gengjun-git commented on issue #4935: URL: https://github.com/apache/incubator-doris/issues/4935#issuecomment-732691148 fix in #4936 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] gengjun-git closed issue #4935: Colocate table stays unstable when a large number of be restarts frequently

2020-11-23 Thread GitBox
gengjun-git closed issue #4935: URL: https://github.com/apache/incubator-doris/issues/4935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated: [Refactor] Short circuit return to avoid meaningless loop (#4933)

2020-11-23 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new b7b1d5e [Refactor] Short circuit r

[GitHub] [incubator-doris] chaoyli merged pull request #4933: [Refactor] Short circuit return to avoid meaningless loop

2020-11-23 Thread GitBox
chaoyli merged pull request #4933: URL: https://github.com/apache/incubator-doris/pull/4933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #4938: [Schema change] Support More column type in schema change

2020-11-23 Thread GitBox
HappenLee commented on a change in pull request #4938: URL: https://github.com/apache/incubator-doris/pull/4938#discussion_r529199676 ## File path: be/src/olap/types.h ## @@ -509,98 +530,55 @@ OLAPStatus convert_int_from_varchar(void* dest, const void* src) { } template -

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #4938: [Schema change] Support More column type in schema change

2020-11-23 Thread GitBox
HappenLee commented on a change in pull request #4938: URL: https://github.com/apache/incubator-doris/pull/4938#discussion_r529198744 ## File path: be/src/olap/types.h ## @@ -509,98 +530,55 @@ OLAPStatus convert_int_from_varchar(void* dest, const void* src) { } template -

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #4938: [Schema change] Support More column type in schema change

2020-11-23 Thread GitBox
chaoyli commented on a change in pull request #4938: URL: https://github.com/apache/incubator-doris/pull/4938#discussion_r529182465 ## File path: be/src/olap/types.h ## @@ -509,98 +530,55 @@ OLAPStatus convert_int_from_varchar(void* dest, const void* src) { } template -OL

[GitHub] [incubator-doris] 4396clearlove7 commented on issue #4942: BUILD FAILURE

2020-11-23 Thread GitBox
4396clearlove7 commented on issue #4942: URL: https://github.com/apache/incubator-doris/issues/4942#issuecomment-732581443 > You can use `fe/pom.xml` from trunk code base to replace that file in 0.13-rc03. > You can can just use 0.13.11 from `https://github.com/baidu-doris/incubator-do

[GitHub] [incubator-doris] morningman commented on issue #4942: BUILD FAILURE

2020-11-23 Thread GitBox
morningman commented on issue #4942: URL: https://github.com/apache/incubator-doris/issues/4942#issuecomment-732570289 You can use `fe/pom.xml` from trunk code base to replace that file in 0.13-rc03. You can can just use 0.13.11 from `https://github.com/baidu-doris/incubator-doris`, wh

[GitHub] [incubator-doris] 4396clearlove7 commented on issue #4942: BUILD FAILURE

2020-11-23 Thread GitBox
4396clearlove7 commented on issue #4942: URL: https://github.com/apache/incubator-doris/issues/4942#issuecomment-732567329 release 0.13 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] 4396clearlove7 commented on issue #4942: BUILD FAILURE

2020-11-23 Thread GitBox
4396clearlove7 commented on issue #4942: URL: https://github.com/apache/incubator-doris/issues/4942#issuecomment-732563683 apachedoris/doris-dev:build-env-1.2 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] 4396clearlove7 opened a new issue #4942: BUILD FAILURE

2020-11-23 Thread GitBox
4396clearlove7 opened a new issue #4942: URL: https://github.com/apache/incubator-doris/issues/4942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] HappenLee opened a new pull request #4941: [Bug] Fix be ut compile failed and core in delta_writer_test when unlimit < 60000.

2020-11-23 Thread GitBox
HappenLee opened a new pull request #4941: URL: https://github.com/apache/incubator-doris/pull/4941 ## Proposed changes fix issue:#4940 ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the boxes that apply_ - [x] Bugfi

[GitHub] [incubator-doris] HappenLee opened a new issue #4940: [Bug] BE ut compile failed and core in delta_writer_test when ulimit < 60000

2020-11-23 Thread GitBox
HappenLee opened a new issue #4940: URL: https://github.com/apache/incubator-doris/issues/4940 **Describe the bug** RT delta_writer_test core because of ``` 1. Wild pointer of StorageEngine::~StorageEngine()::_compaction_thread_pool->shutdown() 2. nullptr call for k_engi

[GitHub] [incubator-doris] yangzhg closed issue #3321: [Delete] Support delete on non-key column in duplicate-key table

2020-11-23 Thread GitBox
yangzhg closed issue #3321: URL: https://github.com/apache/incubator-doris/issues/3321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] yangzhg opened a new issue #4939: Improve the start and stop script of doris

2020-11-23 Thread GitBox
yangzhg opened a new issue #4939: URL: https://github.com/apache/incubator-doris/issues/4939 The start-stop script has the following problems 1. does not support restart 2. does not check whether it is successful after starting 3. the --daemon parameter should be the default when

[GitHub] [incubator-doris] HappenLee opened a new pull request #4938: [Schema change] Support More column type in schema change

2020-11-23 Thread GitBox
HappenLee opened a new pull request #4938: URL: https://github.com/apache/incubator-doris/pull/4938 1. Support modify column type CHAR to TINYINT/SMALLINT/INT/BIGINT/LARGEINT/FLOAT/DOUBLE/DATE and TINYINT/SMALLINT/INT/BIGINT/LARGEINT/FLOAT/DOUBLE convert to a wider range of numeric type