HappenLee opened a new pull request #4052:
URL: https://github.com/apache/incubator-doris/pull/4052
Resource release should be done by dest RowBatch. When we call method
transfer_resource_ownership. if we don't clear the corresponding resources,
which will cause the core problem of double
caiconghui commented on a change in pull request #4049:
URL: https://github.com/apache/incubator-doris/pull/4049#discussion_r451318966
##
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##
@@ -458,10 +459,10 @@ public DynamicPartitionScheduler
getDynamicParti
yangzhg edited a comment on issue #4051:
URL:
https://github.com/apache/incubator-doris/issues/4051#issuecomment-655317768
# Doris 支持批量删除设计文档
## 背景
目前Doris 支持broker load， routine load， stream load
等多种导入方式，对于数据的删除目前只能通过delete 语句进行删除，使用delete 语句的方式删除时，每执行一次delete
yangzhg commented on issue #4051:
URL:
https://github.com/apache/incubator-doris/issues/4051#issuecomment-655317768
# Doris 支持批量删除设计文档
## 背景
目前Doris 支持broker load， routine load， stream load
等多种导入方式，对于数据的删除目前只能通过delete 语句进行删除，使用delete 语句的方式删除时，每执行一次delete
都会生成一个新
yangzhg opened a new issue #4051:
URL: https://github.com/apache/incubator-doris/issues/4051
# Doris supports batch delete
## BACKGROUND
At present, Doris supports multiple import methods such as broker load,
routine load, stream load, etc. For the deletion of data, it can on
WingsGo commented on a change in pull request #4049:
URL: https://github.com/apache/incubator-doris/pull/4049#discussion_r451308462
##
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##
@@ -458,10 +459,10 @@ public DynamicPartitionScheduler
getDynamicPartitio
WingsGo commented on a change in pull request #4049:
URL: https://github.com/apache/incubator-doris/pull/4049#discussion_r451308462
##
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##
@@ -458,10 +459,10 @@ public DynamicPartitionScheduler
getDynamicPartitio
caiconghui commented on pull request #4022:
URL: https://github.com/apache/incubator-doris/pull/4022#issuecomment-655308540
> UT failed on ThreadPoolManagerTest.java.
> Can you pass it in your local env?
@morningman
I test in with "mvn test -Dtest=ThreadPoolManagerTest", and it pa
caiconghui edited a comment on pull request #4022:
URL: https://github.com/apache/incubator-doris/pull/4022#issuecomment-655308540
> UT failed on ThreadPoolManagerTest.java.
> Can you pass it in your local env?
@morningman
I test it with "mvn test -Dtest=ThreadPoolManagerTest", an
chaoyli commented on issue #3930:
URL:
https://github.com/apache/incubator-doris/issues/3930#issuecomment-655289846
I think it's better to handle the problem in load.
If you want to preserve the ordering, you can speculate the behavior in the
load command.
CreateTable should not catc
vagetablechicken closed issue #4027:
URL: https://github.com/apache/incubator-doris/issues/4027
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
vagetablechicken commented on issue #4027:
URL:
https://github.com/apache/incubator-doris/issues/4027#issuecomment-655275835
MemTable flush count & time already have BE level stats, sorry, I didn't see
it before create this issue. But no tablet level. It's better to add tablet
monitoring
xy720 commented on a change in pull request #3981:
URL: https://github.com/apache/incubator-doris/pull/3981#discussion_r451273362
##
File path: fe/src/main/java/org/apache/doris/analysis/ModifyPartitionClause.java
##
@@ -48,27 +61,80 @@ public ModifyPartitionClause(String parti
wutiangan commented on a change in pull request #4014:
URL: https://github.com/apache/incubator-doris/pull/4014#discussion_r451257912
##
File path:
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
##
@@ -50,7 +53,21 @@
* [PROPERTIES ("key" = "value"
This is an automated email from the ASF dual-hosted git repository.
lichaoyong pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 6d4fd25 [shell] Fix BE unit test directory not match bug (#4028)
add 413d6d2 [Bug] Fix core when
chaoyli merged pull request #4042:
URL: https://github.com/apache/incubator-doris/pull/4042
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chaoyli closed issue #4044:
URL: https://github.com/apache/incubator-doris/issues/4044
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chaoyli closed issue #4043:
URL: https://github.com/apache/incubator-doris/issues/4043
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
caiconghui commented on a change in pull request #4049:
URL: https://github.com/apache/incubator-doris/pull/4049#discussion_r451250664
##
File path:
fe/src/main/java/org/apache/doris/common/publish/FixedTimePublisher.java
##
@@ -28,7 +28,7 @@
public class FixedTimePublisher {
wutiangan commented on a change in pull request #4014:
URL: https://github.com/apache/incubator-doris/pull/4014#discussion_r451249418
##
File path:
fe/src/main/java/org/apache/doris/analysis/MVColumnOneChildPattern.java
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software F
acelyc111 commented on pull request #4050:
URL: https://github.com/apache/incubator-doris/pull/4050#issuecomment-655238887
Now BE's website looks like:
---
morningman commented on pull request #4022:
URL: https://github.com/apache/incubator-doris/pull/4022#issuecomment-655237182
UT failed on ThreadPoolManagerTest.java.
Can you pass it in your local env?
This is an automated m
morningman commented on a change in pull request #4014:
URL: https://github.com/apache/incubator-doris/pull/4014#discussion_r450258546
##
File path:
fe/src/main/java/org/apache/doris/rewrite/mvrewrite/SlotRefEqualRule.java
##
@@ -0,0 +1,39 @@
+// Licensed to the Apache Softwar
morningman commented on a change in pull request #4014:
URL: https://github.com/apache/incubator-doris/pull/4014#discussion_r451239890
##
File path: fe/src/main/java/org/apache/doris/analysis/QueryStmt.java
##
@@ -113,6 +113,40 @@
// represent the "INTO OUTFILE" clause
morningman merged pull request #4028:
URL: https://github.com/apache/incubator-doris/pull/4028
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman commented on pull request #4028:
URL: https://github.com/apache/incubator-doris/pull/4028#issuecomment-655235433
I merged this PR so that following UT can run normally.
This is an automated message from the Apache
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 7715a84 [Config] Enable some features by default (#4031)
add 6d4fd25 [shell] Fix BE unit test dir
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 7715a84 [Config] Enable some featu
morningman merged pull request #4031:
URL: https://github.com/apache/incubator-doris/pull/4031
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman commented on a change in pull request #4049:
URL: https://github.com/apache/incubator-doris/pull/4049#discussion_r451232425
##
File path:
fe/src/main/java/org/apache/doris/common/publish/FixedTimePublisher.java
##
@@ -28,7 +28,7 @@
public class FixedTimePublisher {
morningman commented on a change in pull request #4050:
URL: https://github.com/apache/incubator-doris/pull/4050#discussion_r451230720
##
File path: webroot/be/index.html
##
@@ -0,0 +1,24 @@
+
+
+
+Doris Webserver
Review comment:
How about:
`Doris Backend`
?
acelyc111 opened a new pull request #4050:
URL: https://github.com/apache/incubator-doris/pull/4050
Add some CSS and js files, and use boost-table framework to make BE's
website more pretty
This is an automated message from
caiconghui commented on pull request #4049:
URL: https://github.com/apache/incubator-doris/pull/4049#issuecomment-654973560
for #4046
This is an automated message from the Apache Git Service.
To respond to the message, pleas
caiconghui opened a new pull request #4049:
URL: https://github.com/apache/incubator-doris/pull/4049
This PR is mainly to fix thread resource leak, and then add some notice to
use newDaemonScheduledThreadPool api in ThreadPoolManager .
-
acelyc111 closed pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
caiconghui edited a comment on issue #4046:
URL:
https://github.com/apache/incubator-doris/issues/4046#issuecomment-654852287
Here, we start the thread in MasterTaskExecutor
https://github.com/apache/incubator-doris/blob/1fc82cd6e48ef5fed4d29b7e5cb4df63c3130027/fe/src/main/java/org/
Youngwb commented on issue #3930:
URL:
https://github.com/apache/incubator-doris/issues/3930#issuecomment-654940291
> If user create `sequence_visible` column in table, does it still has a
hidden sequence column?
> In my point, it should has.
yes, it has.
morningman commented on a change in pull request #3981:
URL: https://github.com/apache/incubator-doris/pull/3981#discussion_r450944928
##
File path: fe/src/main/java/org/apache/doris/analysis/ModifyPartitionClause.java
##
@@ -17,28 +17,41 @@
package org.apache.doris.analysis
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from ab8851f [webserver] Make BE webserver handle static files (#4021)
add b7051d0 [Config]Make it eas
morningman merged pull request #3957:
URL: https://github.com/apache/incubator-doris/pull/3957
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new ab8851f [webserver] Make BE webser
morningman merged pull request #4021:
URL: https://github.com/apache/incubator-doris/pull/4021
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman merged pull request #4020:
URL: https://github.com/apache/incubator-doris/pull/4020
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman merged pull request #4026:
URL: https://github.com/apache/incubator-doris/pull/4026
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1aa148d [Bug]Fix mini load NPE (#4
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 5c42514 [Bug][SQL]Fix except node child not order correctly (#4003)
add c3d9fee [Load][Json] Refa
morningman merged pull request #4003:
URL: https://github.com/apache/incubator-doris/pull/4003
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 5c42514 [Bug][SQL]Fix except node
morningman closed issue #3995:
URL: https://github.com/apache/incubator-doris/issues/3995
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1cc9e16 [Doris On ES] Add UT test
morningman merged pull request #4035:
URL: https://github.com/apache/incubator-doris/pull/4035
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman commented on a change in pull request #4039:
URL: https://github.com/apache/incubator-doris/pull/4039#discussion_r450879095
##
File path: be/src/olap/rowset_graph.h
##
@@ -23,16 +23,32 @@
#include "olap/rowset/rowset_meta.h"
namespace doris {
-
+/// RowsetGraph c
morningman commented on issue #3930:
URL:
https://github.com/apache/incubator-doris/issues/3930#issuecomment-654919279
If user create `sequence_visible` column in table, does it still has a
hidden sequence column?
In my point, it should has.
---
wutiangan opened a new pull request #4048:
URL: https://github.com/apache/incubator-doris/pull/4048
fix #4047
#3886 has certain relevance to this case。
the sql : bigtable t1 join mysqltable t2 join mysqltable t3 on t1.k1 = t3.k1
1、after reorder:
t1, t2, t3
2、cho
wutiangan opened a new issue #4047:
URL: https://github.com/apache/incubator-doris/issues/4047
**Describe the bug**
a big olap table join two small mysql table, I want to the join method use
broadcast join, but the doris choose shuffer join,.
**To Reproduce**
select * from
caiconghui edited a comment on issue #4046:
URL:
https://github.com/apache/incubator-doris/issues/4046#issuecomment-654852287
Here, we start the thread in MasterTaskExecutor
https://github.com/apache/incubator-doris/blob/1fc82cd6e48ef5fed4d29b7e5cb4df63c3130027/fe/src/main/java/org/
caiconghui edited a comment on issue #4046:
URL:
https://github.com/apache/incubator-doris/issues/4046#issuecomment-654852287
Here, we start the thread in MasterTaskExecutor
public MasterTaskExecutor(int threadNum) {
executor = ThreadPoolManager.newScheduledThreadPool(
Youngwb commented on issue #3930:
URL:
https://github.com/apache/incubator-doris/issues/3930#issuecomment-654853902
According to @morningman @yangzhg 's suggest, I made some corrections
## name
use `sequence` column instead of `version` column for user understand easy.
## Crea
caiconghui edited a comment on issue #4046:
URL:
https://github.com/apache/incubator-doris/issues/4046#issuecomment-654852287
https://github.com/apache/incubator-doris/blob/master/fe/src/main/java/org/apache/doris/task/MasterTaskExecutor.java#L39~#L43
caiconghui edited a comment on issue #4046:
URL:
https://github.com/apache/incubator-doris/issues/4046#issuecomment-654852287
https://github.com/apache/incubator-doris/blob/master/fe/src/main/java/org/apache/doris/task/MasterTaskExecutor.java#L39
-
caiconghui commented on issue #4046:
URL:
https://github.com/apache/incubator-doris/issues/4046#issuecomment-654852287
https://github.com/apache/incubator-doris/blob/master/fe/src/main/java/org/apache/doris/task/MasterTaskExecutor.java#L39-#L43
---
caiconghui commented on issue #4046:
URL:
https://github.com/apache/incubator-doris/issues/4046#issuecomment-654849459
I get the thread snapshot of fe process, and find there are many schduler
thread.
grep "ScheduledThreadPoolExecutor.java:899" temp | wc -l
3826
--
caiconghui opened a new issue #4046:
URL: https://github.com/apache/incubator-doris/issues/4046
This is an au
wangbo commented on issue #4027:
URL:
https://github.com/apache/incubator-doris/issues/4027#issuecomment-654838945
Thanks for the answer
This is an automated message from the Apache Git Service.
To respond to the message, pl
wangbo opened a new pull request #4045:
URL: https://github.com/apache/incubator-doris/pull/4045
(#4030) Fix mem_pool npe in column reader
This is an automated message from the Apache Git Service.
To respond to the message, p
chaoyli commented on issue #4044:
URL:
https://github.com/apache/incubator-doris/issues/4044#issuecomment-654824077
-
chaoyli commented on issue #4044:
URL:
https://github.com/apache/incubator-doris/issues/4044#issuecomment-654823774
```
2020-06-23 1
2020-06-25 1
2020-06-24 0
```
This is an automated message from the Apach
chaoyli opened a new issue #4044:
URL: https://github.com/apache/incubator-doris/issues/4044
```
CREATE TABLE aggregate_table_with_null (
k1 date NULL COMMENT "",
k2 datetime NULL COMMENT "",
k3 char(20) NULL COMMENT "",
k4 varchar(20) NULL COMMENT "",
k5 boolean NULL COMME
chaoyli commented on issue #4043:
URL:
https://github.com/apache/incubator-doris/issues/4043#issuecomment-654821207
-
chaoyli commented on issue #4043:
URL:
https://github.com/apache/incubator-doris/issues/4043#issuecomment-654820839
```
2020-06-23 2020-06-23 00:00:00 beijing haidian 1 -128
-32768 -2147483648 -9223372036854775808-18446744073709551616 -3.1
-3.14 -3.141
chaoyli opened a new issue #4043:
URL: https://github.com/apache/incubator-doris/issues/4043
```
CREATE TABLE duplicate_table_with_null (k1 date,k2 datetime,k3
char(20),k4 varchar(20),k5 boolean,k6 tinyint,k7 smallint,k8 int,k9
bigint,k10 largeint,k11 float,k12 double,k13 decim
chaoyli opened a new pull request #4042:
URL: https://github.com/apache/incubator-doris/pull/4042
1. Doris support modify char to varchar. There is a bug when use two-level
pointer when converting the date.
2. Boolean can be used as metric value with REPLACE and REPLACE_IF_NOT_NULL
aggr
This is an automated email from the ASF dual-hosted git repository.
lichaoyong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new c9a7c37 [Bug] Return actual json f
chaoyli merged pull request #4016:
URL: https://github.com/apache/incubator-doris/pull/4016
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
yangzhg opened a new pull request #4041:
URL: https://github.com/apache/incubator-doris/pull/4041
Fixes #4040
Fix predicate pushdown amy incorrect when groupby with grouping sets
This is an automated message from the Apac
yangzhg opened a new issue #4040:
URL: https://github.com/apache/incubator-doris/issues/4040
with sql like
```
SELECT
IF(col2 IS NULL, 'ALL', col2) AS col2,
IF(col3 IS NULL, 'ALL', col3) AS col3,
pv
FROM
(
SELECT
col1,
col2,
xy720 commented on a change in pull request #4039:
URL: https://github.com/apache/incubator-doris/pull/4039#discussion_r450727522
##
File path: be/src/olap/rowset_graph.h
##
@@ -47,6 +50,86 @@ class RowsetGraph {
std::unordered_map _vertex_index_map;
};
-} // namespace
vagetablechicken commented on issue #4027:
URL:
https://github.com/apache/incubator-doris/issues/4027#issuecomment-654714129
> I see.
> I am curious about detail of `some reason the flush time or count in one
BE is always longer/higher than others`.
> Under what circumstances will th
wuyunfeng commented on a change in pull request #4039:
URL: https://github.com/apache/incubator-doris/pull/4039#discussion_r450711406
##
File path: be/src/olap/rowset_graph.cpp
##
@@ -17,14 +17,247 @@
#include "olap/rowset_graph.h"
-#include
#include
+#include
#incl
ZhangYu0123 opened a new pull request #4039:
URL: https://github.com/apache/incubator-doris/pull/4039
Related issue #4017, main changes as follows:
(1) Add expired_snapshot_rs_version_map，_expired_snapshot_rs_metas，(2) Add
VersionedRowsetTracker record compacted path version， (3) Record
morningman commented on a change in pull request #4028:
URL: https://github.com/apache/incubator-doris/pull/4028#discussion_r450694715
##
File path: run-ut.sh
##
@@ -105,7 +105,7 @@ echo "Running PaloBe Unittest"
echo "**"
cd ${DORIS_HOME
morningman commented on pull request #4038:
URL: https://github.com/apache/incubator-doris/pull/4038#issuecomment-654686400
Duplicated with #4028 ,closed
This is an automated message from the Apache Git Service.
To respond to
morningman closed pull request #4038:
URL: https://github.com/apache/incubator-doris/pull/4038
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman opened a new pull request #4038:
URL: https://github.com/apache/incubator-doris/pull/4038
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
mnloveyx opened a new issue #4037:
URL: https://github.com/apache/incubator-doris/issues/4037
PreparedStatement preparedStatement = null;
try {
preparedStatement =
connection.prepareStatement( databaseMeta.stripCR( sql ),
ResultSet.TYPE_FORWARD_ONLY,
acelyc111 opened a new pull request #4036:
URL: https://github.com/apache/incubator-doris/pull/4036
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
WingsGo commented on pull request #4009:
URL: https://github.com/apache/incubator-doris/pull/4009#issuecomment-654643098
> > > It's better add more discrete message in commit info like you issue.
> >
> >
> > Ok, done, and I tested the schema change supported in doc, but I found
t
WingsGo commented on pull request #3912:
URL: https://github.com/apache/incubator-doris/pull/3912#issuecomment-654642718
> Hi @WingsGo ， could you please rebase the code to solve the conflict? And
I will review it later.
Sorry for reply later, done.
88 matches
Mail list logo
