[GitHub] [incubator-doris] blackfox1983 commented on a change in pull request #3985: [Doris On ES] [Bug-Fix][Refactor] Fix potential null pointer exception and refactor function process logic

2020-06-29 Thread GitBox
blackfox1983 commented on a change in pull request #3985: URL: https://github.com/apache/incubator-doris/pull/3985#discussion_r447429719 ## File path: be/src/exec/es/es_predicate.cpp ## @@ -283,93 +283,91 @@ Status EsPredicate::build_disjuncts_list(const Expr* conjunct) {

[GitHub] [incubator-doris] wuyunfeng commented on issue #3984: [Bug of DOE]be accidental crashed

2020-06-29 Thread GitBox
wuyunfeng commented on issue #3984: URL: https://github.com/apache/incubator-doris/issues/3984#issuecomment-651556405 I guess we should add the checking nullptr logic for `slot_desc` This is an automated message from the Apa

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3985: [Doris On ES] fix potential null pointer exception and refactor function process logic

2020-06-29 Thread GitBox
wuyunfeng opened a new pull request #3985: URL: https://github.com/apache/incubator-doris/pull/3985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] blackfox1983 opened a new issue #3984: [Bug of DOE]be accidental crashed

2020-06-29 Thread GitBox
blackfox1983 opened a new issue #3984: URL: https://github.com/apache/incubator-doris/issues/3984 **Describe the bug** be.out shows as below (But it did not recur) ``` *** Aborted at 1593418720 (unix time) try "date -d @1593418720" if you are using GNU date *** PC: @

[GitHub] [incubator-doris] francisoliverlee commented on issue #3963: [DOC-ERROR, Images can't be seen, cause of 404 in the urls]

2020-06-29 Thread GitBox
francisoliverlee commented on issue #3963: URL: https://github.com/apache/incubator-doris/issues/3963#issuecomment-651507975 @yangzhg i made a summary for how to build FE on mac, if it OK i can give out a PR for this. http://demoworld.tech/c/%E5%9C%A8Mac%E4%B8%8A%E7%BC%96%E8%AF%91FEWin

[GitHub] [incubator-doris] chaoyli commented on issue #3976: Lost data when load data to partitions created by old version doris

2020-06-29 Thread GitBox
chaoyli commented on issue #3976: URL: https://github.com/apache/incubator-doris/issues/3976#issuecomment-651505901 Now Doris-0.13 is only exist in master and not be published, how to do you upgrade to it? This is an automa

[GitHub] [incubator-doris] morningman opened a new pull request #3983: [Bug] Fix bug that linked schema change for alpha rowset will case BE crash

2020-06-29 Thread GitBox
morningman opened a new pull request #3983: URL: https://github.com/apache/incubator-doris/pull/3983 Fix #3982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] liutang123 edited a comment on issue #3976: Lost data when load data to partitions created by old version doris

2020-06-29 Thread GitBox
liutang123 edited a comment on issue #3976: URL: https://github.com/apache/incubator-doris/issues/3976#issuecomment-651500229 > This code takes into effect in following Doris-0.13. And you upgrade to Doris-0.12, there is no problem. > I think you have already upgrade to master instead.

[GitHub] [incubator-doris] liutang123 commented on issue #3976: Lost data when load data to partitions created by old version doris

2020-06-29 Thread GitBox
liutang123 commented on issue #3976: URL: https://github.com/apache/incubator-doris/issues/3976#issuecomment-651500229 > This code takes into effect in following Doris-0.13. And you upgrade to Doris-0.12, there is no problem. > I think you have already upgrade to master instead. In this

[GitHub] [incubator-doris] morningman opened a new issue #3982: [Bug] BE crash when doing schema change for segment v1 table

2020-06-29 Thread GitBox
morningman opened a new issue #3982: URL: https://github.com/apache/incubator-doris/issues/3982 **Describe the bug** be.out shows: ``` *** Aborted at 1593481276 (unix time) try "date -d @1593481276" if you are using GNU date *** PC: @ 0x7f1d86cb9c50 __memcpy_sse2_unalign

[GitHub] [incubator-doris] gaodayue closed issue #3972: Insert may send duplicate partition to BE if plan is reanalyzed

2020-06-29 Thread GitBox
gaodayue closed issue #3972: URL: https://github.com/apache/incubator-doris/issues/3972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] gaodayue merged pull request #3973: [Bug] Insert may leak DeltaWriter when re-analyzed

2020-06-29 Thread GitBox
gaodayue merged pull request #3973: URL: https://github.com/apache/incubator-doris/pull/3973 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-doris] branch master updated: [Bug] Insert may leak DeltaWriter when re-analyzed (#3973)

2020-06-29 Thread gaodayue
This is an automated email from the ASF dual-hosted git repository. gaodayue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new f9a52f5 [Bug] Insert may leak DeltaW

[GitHub] [incubator-doris] spaces-X commented on issue #3908: Column can not be resloved after reorderTable

2020-06-29 Thread GitBox
spaces-X commented on issue #3908: URL: https://github.com/apache/incubator-doris/issues/3908#issuecomment-651495609 @liutang123 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] chaoyli commented on issue #3976: Lost data when load data to partitions created by old version doris

2020-06-29 Thread GitBox
chaoyli commented on issue #3976: URL: https://github.com/apache/incubator-doris/issues/3976#issuecomment-651476937 This code takes into effect in following Doris-0.13. And you upgrade to Doris-0.12, there is no problem. I think you have already upgrade to master instead. In this situat

[GitHub] [incubator-doris] chaoyli commented on issue #3976: Lost data when load data to partitions created by old version doris

2020-06-29 Thread GitBox
chaoyli commented on issue #3976: URL: https://github.com/apache/incubator-doris/issues/3976#issuecomment-651476013 Previously, the version_hash is used to differentiate the same load with the same version. In old days, FE will send version to BE before load finished. Assuming I have t

[GitHub] [incubator-doris] xy720 opened a new pull request #3981: [New Feature] Batch update partition's property in one command

2020-06-29 Thread GitBox
xy720 opened a new pull request #3981: URL: https://github.com/apache/incubator-doris/pull/3981 #3389 This commit supports updating partitions' properties of range table in one command. Example: - replication_num ``` alter table tbl_name modify partition (p1, p2,

[GitHub] [incubator-doris] morningman opened a new issue #3980: [Bug][RoutineLoad] Routine load job being blocked by many COMMITTED tasks

2020-06-29 Thread GitBox
morningman opened a new issue #3980: URL: https://github.com/apache/incubator-doris/issues/3980 **Describe the bug** We found that routine load is not running, and some latest routine load task's transaction state is COMMITTED, not VISIBLE for a long time. And also, the related

[GitHub] [incubator-doris] morningman opened a new pull request #3979: [Bug] Fix bug that routine load task throw exception when calling afterVisible()

2020-06-29 Thread GitBox
morningman opened a new pull request #3979: URL: https://github.com/apache/incubator-doris/pull/3979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-doris] acelyc111 closed pull request #3978: Add .circleci/config.yml

2020-06-29 Thread GitBox
acelyc111 closed pull request #3978: URL: https://github.com/apache/incubator-doris/pull/3978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-doris] acelyc111 opened a new pull request #3978: Add .circleci/config.yml

2020-06-29 Thread GitBox
acelyc111 opened a new pull request #3978: URL: https://github.com/apache/incubator-doris/pull/3978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] acelyc111 opened a new pull request #3977: [refactor] Remove useless return value of class RowsetGraph

2020-06-29 Thread GitBox
acelyc111 opened a new pull request #3977: URL: https://github.com/apache/incubator-doris/pull/3977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman merged pull request #3975: [UT] resolve metric ut fails for Doris FE

2020-06-29 Thread GitBox
morningman merged pull request #3975: URL: https://github.com/apache/incubator-doris/pull/3975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: [UT] resolve metric ut fails (#3975)

2020-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 3ac459f [UT] resolve metric ut fai

[GitHub] [incubator-doris] liutang123 commented on issue #3976: Lost data when load data to partitions created by old version doris

2020-06-29 Thread GitBox
liutang123 commented on issue #3976: URL: https://github.com/apache/incubator-doris/issues/3976#issuecomment-651129678 @chaoyli cc @imay @gaodayue This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] liutang123 opened a new issue #3976: Lost data when load data to partitions created by old version doris

2020-06-29 Thread GitBox
liutang123 opened a new issue #3976: URL: https://github.com/apache/incubator-doris/issues/3976 In #2358, we remove an important logic of `_check_added_rowset`: ```Version version = {rowset->start_version(), rowset->end_version()}; RowsetSharedPtr exist_rs = get_rowset_by_ve

[incubator-doris] branch master updated (48d947e -> 4839823)

2020-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 48d947e Support rpc_timeout property in stream load request to cancel request in fe in time when strea

[incubator-doris] branch master updated (0cbacaf -> 9671394)

2020-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 0cbacaf [Refactor] Replace some boost to std in OlapScanNode (#3934) add 9671394 [BUG]Make segmen

[incubator-doris] branch master updated (2c8fdb6 -> 0cbacaf)

2020-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 2c8fdb6 [BUG]Make segment V1 and V2 share same file cache (#3945) add 0cbacaf [Refactor] Replace

[incubator-doris] branch master updated (af1beb6 -> 2c96d27)

2020-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from af1beb6 [Enhance] Add prepare phase for some timestamp functions (#3947) add 566a7f1 [Enhance] A

[incubator-doris] branch master updated (2c96d27 -> 48d947e)

2020-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 2c96d27 [Enhance] Add MetaUrl and CompactionUrl for "show tablet" stmt (#3962) add 48d947e Suppo

[incubator-doris] branch master updated (9671394 -> af1beb6)

2020-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 9671394 [BUG]Make segment V1 and V2 share same file cache (#3945) add af1beb6 [Enhance] Add prepa

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3975: [UT] resolve metric ut fails

2020-06-29 Thread GitBox
wuyunfeng opened a new pull request #3975: URL: https://github.com/apache/incubator-doris/pull/3975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] acelyc111 commented on issue #3911: [Proposal] Make BE web site more pretty

2020-06-29 Thread GitBox
acelyc111 commented on issue #3911: URL: https://github.com/apache/incubator-doris/issues/3911#issuecomment-651052333 > could you also improve the fe webserver and change it to restful > #3314 I'll try if I have time, I'll reply #3314 if I start to work on it. --

[GitHub] [incubator-doris] yangzhg edited a comment on issue #3911: [Proposal] Make BE web site more pretty

2020-06-29 Thread GitBox
yangzhg edited a comment on issue #3911: URL: https://github.com/apache/incubator-doris/issues/3911#issuecomment-651047284 could you also improve the fe webserver and change it to restful https://github.com/apache/incubator-doris/issues/3314

[GitHub] [incubator-doris] morningman merged pull request #3953: [Bug] Fix bug that default_rowset_type have a session variable

2020-06-29 Thread GitBox
morningman merged pull request #3953: URL: https://github.com/apache/incubator-doris/pull/3953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] yangzhg edited a comment on issue #3911: [Proposal] Make BE web site more pretty

2020-06-29 Thread GitBox
yangzhg edited a comment on issue #3911: URL: https://github.com/apache/incubator-doris/issues/3911#issuecomment-651047284 could you also improve the fe webserver and change it to restful This is an automated message from th

[GitHub] [incubator-doris] yangzhg commented on issue #3911: [Proposal] Make BE web site more pretty

2020-06-29 Thread GitBox
yangzhg commented on issue #3911: URL: https://github.com/apache/incubator-doris/issues/3911#issuecomment-651047284 could you also improve the fe webserver? This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-doris] morningman merged pull request #3948: Support rpc_timeout property in stream load request to cancel request in fe in time when stream load request is timeout

2020-06-29 Thread GitBox
morningman merged pull request #3948: URL: https://github.com/apache/incubator-doris/pull/3948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman merged pull request #3947: [Enhance] Add prepare phase for some timestamp functions

2020-06-29 Thread GitBox
morningman merged pull request #3947: URL: https://github.com/apache/incubator-doris/pull/3947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman merged pull request #3962: [Enhance] Add MetaUrl and CompactionUrl for "show tablet" stmt

2020-06-29 Thread GitBox
morningman merged pull request #3962: URL: https://github.com/apache/incubator-doris/pull/3962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman closed issue #3946: [Enhance] Add prepare phase for some timestamp functions

2020-06-29 Thread GitBox
morningman closed issue #3946: URL: https://github.com/apache/incubator-doris/issues/3946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] morningman merged pull request #3934: [Refactor] Replace some boost to std in OlapScanNode

2020-06-29 Thread GitBox
morningman merged pull request #3934: URL: https://github.com/apache/incubator-doris/pull/3934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman closed issue #3944: [BUG]Storage engine's can not clean segmentV2's file cache

2020-06-29 Thread GitBox
morningman closed issue #3944: URL: https://github.com/apache/incubator-doris/issues/3944 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] morningman merged pull request #3945: [BUG]Make segment V1 and V2 share same file cache

2020-06-29 Thread GitBox
morningman merged pull request #3945: URL: https://github.com/apache/incubator-doris/pull/3945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] yangzhg opened a new pull request #3974: Improve performance of unique table read

2020-06-29 Thread GitBox
yangzhg opened a new pull request #3974: URL: https://github.com/apache/incubator-doris/pull/3974 Implements #3971 the test table as list: ``` mysql> desc test; ++-+--+---+-+-+ | Field | Type| Null | Key | Default | Extra

[GitHub] [incubator-doris] gaodayue opened a new pull request #3973: [Bug] Insert may leak DeltaWriter when re-analyzed

2020-06-29 Thread GitBox
gaodayue opened a new pull request #3973: URL: https://github.com/apache/incubator-doris/pull/3973 Fixes #3972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] gaodayue opened a new issue #3972: Insert may send duplicate partition to BE if plan is reanalyzed

2020-06-29 Thread GitBox
gaodayue opened a new issue #3972: URL: https://github.com/apache/incubator-doris/issues/3972 **Describe the bug** When running BE in debug mode, we found DCHECK at line 251 may fail sometime https://github.com/apache/incubator-doris/blob/d82d48da877f63a951cef83ddb44ec8adde9fe22/b