[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #3909: [webserver] Make BE webserver more pretty

2020-06-21 Thread GitBox
acelyc111 commented on a change in pull request #3909: URL: https://github.com/apache/incubator-doris/pull/3909#discussion_r443347226 ## File path: be/src/www/doris.js ## @@ -0,0 +1,148 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review comment: I'

[incubator-doris] branch master updated (f03abcd -> 3a7b8e9)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from f03abcd [Spark Load] Rollup Tree Builder (#3727) add 3a7b8e9 [Spark Load] Doris Support Using Hiv

[incubator-doris] branch master updated (f03abcd -> 3a7b8e9)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from f03abcd [Spark Load] Rollup Tree Builder (#3727) add 3a7b8e9 [Spark Load] Doris Support Using Hiv

[incubator-doris] branch master updated (56bb218 -> f03abcd)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 56bb218 [Bug] Can not use non-key column as partition column in duplicate table (#3916) add f03ab

[incubator-doris] branch master updated (56bb218 -> f03abcd)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 56bb218 [Bug] Can not use non-key column as partition column in duplicate table (#3916) add f03ab

[GitHub] [incubator-doris] morningman merged pull request #3063: (#3061) [Spark Load] Doris Support Using Hive Table to Build Global Dict

2020-06-21 Thread GitBox
morningman merged pull request #3063: URL: https://github.com/apache/incubator-doris/pull/3063 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman merged pull request #3727: (#3726) [Spark Load] Rollup Tree Builder

2020-06-21 Thread GitBox
morningman merged pull request #3727: URL: https://github.com/apache/incubator-doris/pull/3727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] lfyzjck commented on issue #2757: Doris could not 'select' or 'insert' by presto

2020-06-21 Thread GitBox
lfyzjck commented on issue #2757: URL: https://github.com/apache/incubator-doris/issues/2757#issuecomment-647297399 Presto raise TableNotFoundException because it could not found any valid columns from Doris. I just found that the way Doris stored dataType is different with MySQL in

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-21 Thread GitBox
xy720 commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r443316601 ## File path: be/src/exec/buffered_reader.cpp ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-21 Thread GitBox
wutiangan commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r443315827 ## File path: be/src/exec/buffered_reader.cpp ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-21 Thread GitBox
xy720 commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r443314263 ## File path: be/src/exec/broker_reader.cpp ## @@ -155,6 +155,8 @@ Status BrokerReader::readat(int64_t position, int64_t nbytes, int64_t* bytes_rea

[GitHub] [incubator-doris] morningman commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-21 Thread GitBox
morningman commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r443314176 ## File path: be/src/exec/broker_reader.cpp ## @@ -155,6 +155,8 @@ Status BrokerReader::readat(int64_t position, int64_t nbytes, int64_t* byte

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-21 Thread GitBox
wutiangan commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r443313805 ## File path: be/src/exec/broker_reader.cpp ## @@ -155,6 +155,8 @@ Status BrokerReader::readat(int64_t position, int64_t nbytes, int64_t* bytes

[GitHub] [incubator-doris] yangzhg edited a comment on pull request #3898: Support import true or false as boolean value

2020-06-21 Thread GitBox
yangzhg edited a comment on pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#issuecomment-647270265 > @yangzhg Hi, I think the result of processing bool value for stream load and insert stmt should keep consistent. > For now, like insert into xx values(1), res

[GitHub] [incubator-doris] yangzhg edited a comment on pull request #3898: Support import true or false as boolean value

2020-06-21 Thread GitBox
yangzhg edited a comment on pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#issuecomment-647270265 > @yangzhg Hi, I think the result of processing bool value for stream load and insert stmt should keep consistent. > For now, like insert into xx values(1), res

[GitHub] [incubator-doris] yangzhg commented on pull request #3898: Support import true or false as boolean value

2020-06-21 Thread GitBox
yangzhg commented on pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#issuecomment-647270265 > @yangzhg Hi, I think the result of processing bool value for stream load and insert stmt should keep consistent. > For now, like insert into xx values(1), result=tru

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3924: [Doris On ES][Docs] update document for best practices

2020-06-21 Thread GitBox
wuyunfeng commented on a change in pull request #3924: URL: https://github.com/apache/incubator-doris/pull/3924#discussion_r443302664 ## File path: docs/zh-CN/extending-doris/doris-on-es.md ## @@ -449,6 +449,65 @@ select * from es_table where esquery(k4, ' { 4. Doris计算完结果后,返

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3924: [Doris On ES][Docs] update document for best practices

2020-06-21 Thread GitBox
wutiangan commented on a change in pull request #3924: URL: https://github.com/apache/incubator-doris/pull/3924#discussion_r443301501 ## File path: docs/zh-CN/extending-doris/doris-on-es.md ## @@ -449,6 +449,65 @@ select * from es_table where esquery(k4, ' { 4. Doris计算完结果后,返

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3924: [Doris On ES][Docs] update document for best practices

2020-06-21 Thread GitBox
wutiangan commented on a change in pull request #3924: URL: https://github.com/apache/incubator-doris/pull/3924#discussion_r443301293 ## File path: docs/zh-CN/extending-doris/doris-on-es.md ## @@ -449,6 +449,65 @@ select * from es_table where esquery(k4, ' { 4. Doris计算完结果后,返

[GitHub] [incubator-doris] blackfox1983 commented on pull request #3924: [Doris On ES][Docs] update document for best practices

2020-06-21 Thread GitBox
blackfox1983 commented on pull request #3924: URL: https://github.com/apache/incubator-doris/pull/3924#issuecomment-647251044 lgtm This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3924: [Doris On ES][Docs] update document for best practices

2020-06-21 Thread GitBox
wuyunfeng opened a new pull request #3924: URL: https://github.com/apache/incubator-doris/pull/3924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-21 Thread GitBox
xy720 commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r443290119 ## File path: be/src/exec/buffered_reader.cpp ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [incubator-doris] wyb edited a comment on issue #3433: [Spark load] Doris support Spark load

2020-06-21 Thread GitBox
wyb edited a comment on issue #3433: URL: https://github.com/apache/incubator-doris/issues/3433#issuecomment-635180109 **Resource manager** #3418 [Spark load] Add resource manager (Merged) **Fe schedule job execution** #3712 [Spark load][Fe 1/6] Add spark etl job config (Merged

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3727: (#3726) [Spark Load] Rollup Tree Builder

2020-06-21 Thread GitBox
wangbo commented on a change in pull request #3727: URL: https://github.com/apache/incubator-doris/pull/3727#discussion_r443280150 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/MinimumCoverageRollupTreeBuilder.java ## @@ -0,0 +1,126 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3454: [Doris On ES] Split /_cluster/state to [indexName/_mappings, indexName/_search_shards]

2020-06-21 Thread GitBox
wuyunfeng commented on a change in pull request #3454: URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r443279326 ## File path: fe/src/main/java/org/apache/doris/external/elasticsearch/EsRepository.java ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] morningman merged pull request #3916: [Bug] Can not use non-key column as partition column in duplicate table

2020-06-21 Thread GitBox
morningman merged pull request #3916: URL: https://github.com/apache/incubator-doris/pull/3916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: [Bug] Can not use non-key column as partition column in duplicate table (#3916)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 56bb218 [Bug] Can not use non-key

[GitHub] [incubator-doris] morningman merged pull request #3850: [FE] Prohibit pointing helper to itself when starting FE

2020-06-21 Thread GitBox
morningman merged pull request #3850: URL: https://github.com/apache/incubator-doris/pull/3850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated (66a8383 -> 4c3ccfb)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 66a8383 [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs (#3858)

[incubator-doris] branch master updated (35d07d8 -> 66a8383)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 35d07d8 [Doc] Fix audit-plugin doc error (#3922) add 66a8383 [Running_Profile] Fix all counter in

[GitHub] [incubator-doris] morningman merged pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs

2020-06-21 Thread GitBox
morningman merged pull request #3858: URL: https://github.com/apache/incubator-doris/pull/3858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3727: (#3726) [Spark Load] Rollup Tree Builder

2020-06-21 Thread GitBox
wangbo commented on a change in pull request #3727: URL: https://github.com/apache/incubator-doris/pull/3727#discussion_r443278487 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/MinimumCoverageRollupTreeBuilder.java ## @@ -0,0 +1,126 @@ +// Licensed to the Apa

[incubator-doris] branch master updated: [Doc] Fix audit-plugin doc error (#3922)

2020-06-21 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 35d07d8 [Doc] Fix audit-plugin doc erro

[GitHub] [incubator-doris] imay merged pull request #3922: [Doc] Fix audit-plugin doc error

2020-06-21 Thread GitBox
imay merged pull request #3922: URL: https://github.com/apache/incubator-doris/pull/3922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] morningman commented on pull request #3923: [Spill to Disk] Aggregation Node Support Spill to disk in big query

2020-06-21 Thread GitBox
morningman commented on pull request #3923: URL: https://github.com/apache/incubator-doris/pull/3923#issuecomment-647138443 Hi @HappenLee , Please to create an issue to describe the why you did it and how it works. And also in the PR's comment, you should describe the main changes of you

[GitHub] [incubator-doris] WingsGo commented on pull request #3519: Check backend disk has available capactiy by storage medium before create table

2020-06-21 Thread GitBox
WingsGo commented on pull request #3519: URL: https://github.com/apache/incubator-doris/pull/3519#issuecomment-647136169 > I think we need to add a FE config like `enable_strict_storage_medium_check`, and default is false, and > can also be modified at runtime. > Because I am afraid i

[GitHub] [incubator-doris] HappenLee opened a new pull request #3923: [Spill to Disk] Aggregation Node Support Spill to disk in big query

2020-06-21 Thread GitBox
HappenLee opened a new pull request #3923: URL: https://github.com/apache/incubator-doris/pull/3923 RT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-doris] morningman merged pull request #3717: [Spark load][Fe 6/6] Fe process etl and loading state job

2020-06-21 Thread GitBox
morningman merged pull request #3717: URL: https://github.com/apache/incubator-doris/pull/3717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: [Spark load][Fe 6/6] Fe process etl and loading state job (#3717)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new a63fa88 [Spark load][Fe 6/6] Fe pr

[GitHub] [incubator-doris] morningman commented on a change in pull request #3760: Support external users to contribute udf

2020-06-21 Thread GitBox
morningman commented on a change in pull request #3760: URL: https://github.com/apache/incubator-doris/pull/3760#discussion_r443222828 ## File path: docs/zh-CN/extending-doris/user-defined-function.md ## @@ -74,23 +93,154 @@ under the License. |Varchar|StringVal| |Decimal|Dec

[GitHub] [incubator-doris] liyuance opened a new pull request #3922: [Doc] Fix audit-plugin doc error

2020-06-21 Thread GitBox
liyuance opened a new pull request #3922: URL: https://github.com/apache/incubator-doris/pull/3922 Fix audit-plugin doc error Droris -> Doris This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-doris] morningman commented on a change in pull request #3910: [Bug] Unify the timezone

2020-06-21 Thread GitBox
morningman commented on a change in pull request #3910: URL: https://github.com/apache/incubator-doris/pull/3910#discussion_r443216636 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -554,6 +554,13 @@ public static Catalog getCurrentCatalog() {

[GitHub] [incubator-doris] morningman opened a new pull request #3921: [Bug] Enable to get TCP metrics for linux kernel 2.x

2020-06-21 Thread GitBox
morningman opened a new pull request #3921: URL: https://github.com/apache/incubator-doris/pull/3921 Fix #3920 CL: 1. Parse the TCP metrics header in `/proc/net/snmp` to get the right position of the metrics. This

[GitHub] [incubator-doris] morningman opened a new issue #3920: [Bug] Failed to get TCP metrics when linux kernel is 2.x

2020-06-21 Thread GitBox
morningman opened a new issue #3920: URL: https://github.com/apache/incubator-doris/issues/3920 **Describe the bug** In PR #3835, I get the tcp metrics from `/proc/net/snmp`. But the content of `/proc/net/snmp` is different in linux kernel 2.x and kernel 3.x In 2.x, the content

[GitHub] [incubator-doris] WingsGo commented on pull request #3910: [Bug] Unify the timezone

2020-06-21 Thread GitBox
WingsGo commented on pull request #3910: URL: https://github.com/apache/incubator-doris/pull/3910#issuecomment-647127064 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman commented on a change in pull request #3910: [Bug] Unify the timezone

2020-06-21 Thread GitBox
morningman commented on a change in pull request #3910: URL: https://github.com/apache/incubator-doris/pull/3910#discussion_r443216636 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -554,6 +554,13 @@ public static Catalog getCurrentCatalog() {

[GitHub] [incubator-doris] morningman opened a new issue #3919: [Bug] Create table with dynamic partition encounter exception

2020-06-21 Thread GitBox
morningman opened a new issue #3919: URL: https://github.com/apache/incubator-doris/issues/3919 **Describe the bug** When create table with dynamic partition without specifying the time zone, it will throw exception: `nknown or incorrect time zone: 'PRC'` **To Reproduce**

[GitHub] [incubator-doris] morningman merged pull request #3914: [Doc] Fix error description of bucket impact in data-partition.md

2020-06-21 Thread GitBox
morningman merged pull request #3914: URL: https://github.com/apache/incubator-doris/pull/3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: [Doc] Fix doc-bug (#3914)

2020-06-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 03fa1fe [Doc] Fix doc-bug (#3914)

[incubator-doris] branch master updated: [Bug] Fix bug that BE crash when doing some queries (#3918)

2020-06-21 Thread lingmiao
This is an automated email from the ASF dual-hosted git repository. lingmiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 1e42c4a [Bug] Fix bug that BE crash

[GitHub] [incubator-doris] EmmyMiao87 closed issue #3917: [Bug] BE crash when doing some queries.

2020-06-21 Thread GitBox
EmmyMiao87 closed issue #3917: URL: https://github.com/apache/incubator-doris/issues/3917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] EmmyMiao87 merged pull request #3918: [Bug] Fix bug that BE crash when doing some queries

2020-06-21 Thread GitBox
EmmyMiao87 merged pull request #3918: URL: https://github.com/apache/incubator-doris/pull/3918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3916: [Bug] Can not use non-key column as partition column in duplicate table

2020-06-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #3916: URL: https://github.com/apache/incubator-doris/pull/3916#discussion_r443190547 ## File path: fe/src/main/java/org/apache/doris/analysis/RangePartitionDesc.java ## @@ -145,9 +149,14 @@ public PartitionInfo toPartitionInfo(L

[GitHub] [incubator-doris] morningman commented on a change in pull request #3916: [Bug] Can not use non-key column as partition column in duplicate table

2020-06-21 Thread GitBox
morningman commented on a change in pull request #3916: URL: https://github.com/apache/incubator-doris/pull/3916#discussion_r443189982 ## File path: fe/src/main/java/org/apache/doris/analysis/RangePartitionDesc.java ## @@ -145,9 +149,14 @@ public PartitionInfo toPartitionInfo(L