[GitHub] [incubator-doris] vagetablechicken edited a comment on pull request #3899: [Bug] fix mem_tracker use-after-free & add UT for it

2020-06-18 Thread GitBox
vagetablechicken edited a comment on pull request #3899: URL: https://github.com/apache/incubator-doris/pull/3899#issuecomment-645732574 The detected error: ``` ==11791==ERROR: AddressSanitizer: heap-use-after-free on address 0x6140d4d0 at pc 0x0173f25c bp 0x7ffc769fb940 sp 0x

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3898: Support import true or false as boolean value

2020-06-18 Thread GitBox
chaoyli commented on a change in pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#discussion_r442646702 ## File path: be/src/olap/utils.cpp ## @@ -1264,6 +1265,15 @@ bool valid_datetime(const string &value_str) { } } +bool valid_bool(const st

[GitHub] [incubator-doris] acelyc111 opened a new pull request #3909: [webserver] Introduce mustache and make BE webserver more pretty

2020-06-18 Thread GitBox
acelyc111 opened a new pull request #3909: URL: https://github.com/apache/incubator-doris/pull/3909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-doris] branch master updated (1d9fa50 -> e0461cc)

2020-06-18 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 1d9fa50 [BUG][Broker] Fix broker read buffer size from input stream (#3881) add e0461cc [bug] Ma

[incubator-doris] branch master updated (1d9fa50 -> e0461cc)

2020-06-18 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 1d9fa50 [BUG][Broker] Fix broker read buffer size from input stream (#3881) add e0461cc [bug] Ma

[GitHub] [incubator-doris] chaoyli merged pull request #3903: [Bug] Make compaction metrics value is right

2020-06-18 Thread GitBox
chaoyli merged pull request #3903: URL: https://github.com/apache/incubator-doris/pull/3903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-doris] chaoyli closed issue #3904: Compaction not collect the number of rowsets compacted rightly

2020-06-18 Thread GitBox
chaoyli closed issue #3904: URL: https://github.com/apache/incubator-doris/issues/3904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs

2020-06-18 Thread GitBox
HappenLee commented on a change in pull request #3858: URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r442601729 ## File path: docs/zh-CN/administrator-guide/running-profile.md ## @@ -92,18 +92,23 @@ BE端收集的统计信息较多,下面列出了各个参数的对应含义: - AverageThreadTokens: 执

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs

2020-06-18 Thread GitBox
HappenLee commented on a change in pull request #3858: URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r442601667 ## File path: docs/zh-CN/administrator-guide/running-profile.md ## @@ -92,18 +92,23 @@ BE端收集的统计信息较多,下面列出了各个参数的对应含义: - AverageThreadTokens: 执

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-18 Thread GitBox
xy720 commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r442599424 ## File path: be/src/exec/buffered_reader.h ## @@ -0,0 +1,61 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [incubator-doris] morningman commented on pull request #3894: [Enhancement] Remove strict report version check of tablets report

2020-06-18 Thread GitBox
morningman commented on pull request #3894: URL: https://github.com/apache/incubator-doris/pull/3894#issuecomment-646394294 I left a comment in #3894 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] morningman edited a comment on pull request #3894: [Enhancement] Remove strict report version check of tablets report

2020-06-18 Thread GitBox
morningman edited a comment on pull request #3894: URL: https://github.com/apache/incubator-doris/pull/3894#issuecomment-646394294 I left a comment in #3893 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] morningman commented on issue #3893: [Proposal] remove strict report version check of TabletReport

2020-06-18 Thread GitBox
morningman commented on issue #3893: URL: https://github.com/apache/incubator-doris/issues/3893#issuecomment-646394143 So I suggest to just remove the line 730, and all things could be go well. https://github.com/apache/incubator-doris/blob/1d9fa5071d1bd80582d4148c13e6e8d2d985c9e0/

[GitHub] [incubator-doris] morningman commented on issue #3893: [Proposal] remove strict report version check of TabletReport

2020-06-18 Thread GitBox
morningman commented on issue #3893: URL: https://github.com/apache/incubator-doris/issues/3893#issuecomment-646393889 The `report version` is mainly used to avoid errors in the following scenarios: ``` Time Line

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3806: Add a session variable allow remove order by for subquery in set opertion clause

2020-06-18 Thread GitBox
yangzhg commented on a change in pull request #3806: URL: https://github.com/apache/incubator-doris/pull/3806#discussion_r442589390 ## File path: fe/src/main/java/org/apache/doris/analysis/QueryStmt.java ## @@ -285,27 +285,29 @@ protected void createSortInfo(Analyzer analyzer)

[GitHub] [incubator-doris] morningman closed issue #3879: [BUG]Broker cannot read the full length of buffer size

2020-06-18 Thread GitBox
morningman closed issue #3879: URL: https://github.com/apache/incubator-doris/issues/3879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] morningman merged pull request #3881: [BUG]Fix broker read buffer size from input stream

2020-06-18 Thread GitBox
morningman merged pull request #3881: URL: https://github.com/apache/incubator-doris/pull/3881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated (5a253bc -> 1d9fa50)

2020-06-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 5a253bc [BE][Tool] Add segment v2 footer meta viewer (#3822) add 1d9fa50 [BUG][Broker] Fix broker

[GitHub] [incubator-doris] morningman merged pull request #3822: Add segment v2 footer meta viewer

2020-06-18 Thread GitBox
morningman merged pull request #3822: URL: https://github.com/apache/incubator-doris/pull/3822 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated (ca96ea3 -> 5a253bc)

2020-06-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from ca96ea3 [Memory Engine] MemTablet creation and compatibility handling in BE (#3762) add 5a253bc

[GitHub] [incubator-doris] hf200012 closed issue #3906: 官方有微信群或者QQ群吗,建一个,方便大家交流

2020-06-18 Thread GitBox
hf200012 closed issue #3906: URL: https://github.com/apache/incubator-doris/issues/3906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-18 Thread GitBox
xy720 commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r442327599 ## File path: be/src/exec/buffered_reader.cpp ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-18 Thread GitBox
xy720 commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r442327705 ## File path: be/src/exec/buffered_reader.h ## @@ -0,0 +1,61 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3878: [optimize] Optimize spark load/broker load reading parquet format file

2020-06-18 Thread GitBox
xy720 commented on a change in pull request #3878: URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r442327238 ## File path: be/src/exec/buffered_reader.cpp ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [incubator-doris] morningman commented on a change in pull request #3872: [Bug] Fix bug that BE crash when doing Insert Operation

2020-06-18 Thread GitBox
morningman commented on a change in pull request #3872: URL: https://github.com/apache/incubator-doris/pull/3872#discussion_r442204451 ## File path: be/src/runtime/plan_fragment_executor.cpp ## @@ -323,7 +323,12 @@ Status PlanFragmentExecutor::open_internal() { {

[GitHub] [incubator-doris] spaces-X opened a new issue #3908: Column can not be resloved after reorderTable

2020-06-18 Thread GitBox
spaces-X opened a new issue #3908: URL: https://github.com/apache/incubator-doris/issues/3908 1. Create two tables: ``` CREATE TABLE `s1` ( `dt` int(11) NULL COMMENT "", `id` int(11) NULL COMMENT "", `pv` int(11) SUM NULL COMMENT "" ) ENGINE=OLAP AGGREGATE KEY(

[GitHub] [incubator-doris] morningman commented on a change in pull request #3806: Add a session variable allow remove order by for subquery in set opertion clause

2020-06-18 Thread GitBox
morningman commented on a change in pull request #3806: URL: https://github.com/apache/incubator-doris/pull/3806#discussion_r442209934 ## File path: fe/src/main/java/org/apache/doris/analysis/QueryStmt.java ## @@ -285,27 +285,29 @@ protected void createSortInfo(Analyzer analyze

[GitHub] [incubator-doris] morningman commented on a change in pull request #3872: [Bug] Fix bug that BE crash when doing Insert Operation

2020-06-18 Thread GitBox
morningman commented on a change in pull request #3872: URL: https://github.com/apache/incubator-doris/pull/3872#discussion_r442204451 ## File path: be/src/runtime/plan_fragment_executor.cpp ## @@ -323,7 +323,12 @@ Status PlanFragmentExecutor::open_internal() { {

[GitHub] [incubator-doris] morningman commented on issue #3906: 官方有微信群或者QQ群吗,建一个,方便大家交流

2020-06-18 Thread GitBox
morningman commented on issue #3906: URL: https://github.com/apache/incubator-doris/issues/3906#issuecomment-645965993 有微信群,可以加我微信 morningman-cmy This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-doris] spaces-X closed issue #3897: subquery can not reslove the grandpa column

2020-06-18 Thread GitBox
spaces-X closed issue #3897: URL: https://github.com/apache/incubator-doris/issues/3897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3898: Support import true or false as boolean value

2020-06-18 Thread GitBox
yangzhg commented on a change in pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#discussion_r442160830 ## File path: be/src/exprs/cast_functions.cpp ## @@ -229,6 +229,17 @@ StringVal CastFunctions::cast_to_string_val(FunctionContext* ctx, const Str

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3898: Support import true or false as boolean value

2020-06-18 Thread GitBox
yangzhg commented on a change in pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#discussion_r442160165 ## File path: be/src/olap/utils.cpp ## @@ -1264,6 +1265,15 @@ bool valid_datetime(const string &value_str) { } } +bool valid_bool(const st

[GitHub] [incubator-doris] wanpengfei-git closed pull request #3907: Test action

2020-06-18 Thread GitBox
wanpengfei-git closed pull request #3907: URL: https://github.com/apache/incubator-doris/pull/3907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] wanpengfei-git opened a new pull request #3907: Test action

2020-06-18 Thread GitBox
wanpengfei-git opened a new pull request #3907: URL: https://github.com/apache/incubator-doris/pull/3907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-doris] hf200012 opened a new issue #3906: 官方有微信群或者QQ群吗,建一个,方便大家交流

2020-06-18 Thread GitBox
hf200012 opened a new issue #3906: URL: https://github.com/apache/incubator-doris/issues/3906 要不我来见一个qq群,群号:1087086074 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3902: Support max_stream_load_timeout_second config in fe

2020-06-18 Thread GitBox
caiconghui commented on a change in pull request #3902: URL: https://github.com/apache/incubator-doris/pull/3902#discussion_r442100819 ## File path: fe/src/main/java/org/apache/doris/common/Config.java ## @@ -474,11 +474,17 @@ public static int stream_load_default_timeout_

[GitHub] [incubator-doris] morningman commented on a change in pull request #3902: Support max_stream_load_timeout_second config in fe

2020-06-18 Thread GitBox
morningman commented on a change in pull request #3902: URL: https://github.com/apache/incubator-doris/pull/3902#discussion_r442099875 ## File path: fe/src/main/java/org/apache/doris/common/Config.java ## @@ -474,11 +474,17 @@ public static int stream_load_default_timeout_

[GitHub] [incubator-doris] caiconghui edited a comment on pull request #3902: Support max_stream_load_timeout_second config in fe

2020-06-18 Thread GitBox
caiconghui edited a comment on pull request #3902: URL: https://github.com/apache/incubator-doris/pull/3902#issuecomment-645905137 ref #3905 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] caiconghui commented on pull request #3902: Support max_stream_load_timeout_second config in fe

2020-06-18 Thread GitBox
caiconghui commented on pull request #3902: URL: https://github.com/apache/incubator-doris/pull/3902#issuecomment-645905137 ref #3902 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3898: Support import true or false as boolean value

2020-06-18 Thread GitBox
chaoyli commented on a change in pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#discussion_r442097496 ## File path: be/src/olap/utils.cpp ## @@ -1264,6 +1265,15 @@ bool valid_datetime(const string &value_str) { } } +bool valid_bool(const st

[GitHub] [incubator-doris] caiconghui removed a comment on pull request #3902: Support max_stream_load_timeout_second config in fe

2020-06-18 Thread GitBox
caiconghui removed a comment on pull request #3902: URL: https://github.com/apache/incubator-doris/pull/3902#issuecomment-645877887 #3902 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-doris] caiconghui commented on pull request #3902: Support max_stream_load_timeout_second config in fe

2020-06-18 Thread GitBox
caiconghui commented on pull request #3902: URL: https://github.com/apache/incubator-doris/pull/3902#issuecomment-645877887 #3902 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] caiconghui opened a new issue #3905: [Config]max_stream_load_timeout_second config is needed for preventing user's large stream load timeout setting

2020-06-18 Thread GitBox
caiconghui opened a new issue #3905: URL: https://github.com/apache/incubator-doris/issues/3905 Now, all load type txns share same max_timeout_second config, which is not sutiable for stream load txn. stream load txn cost much less time than broker load. so max_stream_load_timeout_second i

[GitHub] [incubator-doris] chaoyli commented on issue #3904: Compaction not collect the number of rowsets compacted rightly

2020-06-18 Thread GitBox
chaoyli commented on issue #3904: URL: https://github.com/apache/incubator-doris/issues/3904#issuecomment-645875513 If I performed a base compaction, the input_rowsets is always zero. Because the gc_used_rowsets() clear the input_rowsets before save the metrics. --

[GitHub] [incubator-doris] chaoyli opened a new issue #3904: Compaction not collect the number of rowsets compacted rightly

2020-06-18 Thread GitBox
chaoyli opened a new issue #3904: URL: https://github.com/apache/incubator-doris/issues/3904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-doris] chaoyli opened a new pull request #3903: [bug] Make compaction metrics value is right

2020-06-18 Thread GitBox
chaoyli opened a new pull request #3903: URL: https://github.com/apache/incubator-doris/pull/3903 Now _input_rowsets will be cleared when calling gc_used_rowsets(). After that, the metrics is not right upon be calculated.

[GitHub] [incubator-doris] caiconghui opened a new pull request #3902: Support max_stream_load_timeout_second config in fe

2020-06-18 Thread GitBox
caiconghui opened a new pull request #3902: URL: https://github.com/apache/incubator-doris/pull/3902 This configuration is specifically used to limit timeout setting for stream load. It is to prevent that failed stream load transactions to be canceled after a long time because of the user'

[GitHub] [incubator-doris] wuyunfeng edited a comment on issue #3559: [Doris on ES] unix_timestamp(date_format(now(), '%Y-%m-%d')) not push down

2020-06-18 Thread GitBox
wuyunfeng edited a comment on issue #3559: URL: https://github.com/apache/incubator-doris/issues/3559#issuecomment-645842622 BTW, it seems Doris can not rewrite nested function: ![image](https://user-images.githubusercontent.com/5183061/84992495-8db81780-b17a-11ea-8c37-cda6cbaeb8ef.

[GitHub] [incubator-doris] wuyunfeng commented on issue #3559: [Doris on ES] unix_timestamp(date_format(now(), '%Y-%m-%d')) not push down

2020-06-18 Thread GitBox
wuyunfeng commented on issue #3559: URL: https://github.com/apache/incubator-doris/issues/3559#issuecomment-645842622 BTW, it seems Doris can not rewrite nested function: ![image](https://user-images.githubusercontent.com/5183061/84992495-8db81780-b17a-11ea-8c37-cda6cbaeb8ef.png)

[GitHub] [incubator-doris] wuyunfeng edited a comment on issue #3559: [Doris on ES] unix_timestamp(date_format(now(), '%Y-%m-%d')) not push down

2020-06-18 Thread GitBox
wuyunfeng edited a comment on issue #3559: URL: https://github.com/apache/incubator-doris/issues/3559#issuecomment-645837038 @blackfox1983 I think maybe the reason maybe is Data-Type is different with unix_timestamp(date_format(now(), '%Y-%m-%d')), I just create a table: ```

[GitHub] [incubator-doris] wuyunfeng commented on issue #3559: [Doris on ES] unix_timestamp(date_format(now(), '%Y-%m-%d')) not push down

2020-06-18 Thread GitBox
wuyunfeng commented on issue #3559: URL: https://github.com/apache/incubator-doris/issues/3559#issuecomment-645837038 @blackfox1983 I think maybe the reason maybe is Data-Type is different with unix_timestamp(date_format(now(), '%Y-%m-%d')), I just create a table: ```