[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3571: Support bitmap_intersect

2020-05-18 Thread GitBox
EmmyMiao87 commented on a change in pull request #3571: URL: https://github.com/apache/incubator-doris/pull/3571#discussion_r427069144 ## File path: fe/src/main/java/org/apache/doris/catalog/FunctionSet.java ## @@ -554,29 +555,29 @@ public boolean isNonNullResultWithNullParamF

[GitHub] [incubator-doris] zhangy5 commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
zhangy5 commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427066007 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "导出查询结果集", +"language": "zh-CN" +} +--- + +

[GitHub] [incubator-doris] morningman merged pull request #3631: [Spark on Doris] Shade and provide the thrift lib in spark-doris-connector

2020-05-18 Thread GitBox
morningman merged pull request #3631: URL: https://github.com/apache/incubator-doris/pull/3631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman closed issue #3630: [Spark] Incompatible thrift library

2020-05-18 Thread GitBox
morningman closed issue #3630: URL: https://github.com/apache/incubator-doris/issues/3630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated: [Spark on Doris] Shade and provide the thrift lib in spark-doris-connector (#3631)

2020-05-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 4cbcae1 [Spark on Doris] Shade and

[GitHub] [incubator-doris] morningman commented on issue #3634: [Schema change] throw error 'Can not change default value'

2020-05-18 Thread GitBox
morningman commented on issue #3634: URL: https://github.com/apache/incubator-doris/issues/3634#issuecomment-630606249 try `ALTER TABLE test.test1 MODIFY COLUMN field4 bigint(20) default ""` This is an automated message f

[GitHub] [incubator-doris] morningman commented on pull request #3625: support more syntax in case when clause

2020-05-18 Thread GitBox
morningman commented on pull request #3625: URL: https://github.com/apache/incubator-doris/pull/3625#issuecomment-630597416 Please add an ISSUE related to this PR This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-doris] hww123 opened a new issue #3634: [Schema change] throw error 'Can not change default value'

2020-05-18 Thread GitBox
hww123 opened a new issue #3634: URL: https://github.com/apache/incubator-doris/issues/3634 doris version:12.8 **case**: ``` CREATE TABLE `test1` ( `field1` varchar(500) NULL COMMENT "", `field2` int(11) NULL COMMENT "0", `field3` bigint(20) NULL COMMENT "0" )

[GitHub] [incubator-doris] morningman commented on a change in pull request #3632: Add ignore config to determine whether to continue to start be when load tablet from header failed.

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3632: URL: https://github.com/apache/incubator-doris/pull/3632#discussion_r427033285 ## File path: be/src/olap/data_dir.cpp ## @@ -694,19 +694,26 @@ OLAPStatus DataDir::load() { // create tablet from tablet meta and add it

[GitHub] [incubator-doris] morningman opened a new issue #3633: [Config] Stop BE start process when loading tablet header failed

2020-05-18 Thread GitBox
morningman opened a new issue #3633: URL: https://github.com/apache/incubator-doris/issues/3633 At present, BE will read all the header information of the tablet when it starts. When an error occurs in reading, BE only prints a warning log, and then ignores the tablet to continue reading o

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3628: Fix first start error after upgrade doris to support delete dulplicate table value columns

2020-05-18 Thread GitBox
yangzhg commented on a change in pull request #3628: URL: https://github.com/apache/incubator-doris/pull/3628#discussion_r427028900 ## File path: be/src/olap/rowset/alpha_rowset.cpp ## @@ -300,16 +300,23 @@ OLAPStatus AlphaRowset::init() { if (segment_group_meta.zone

[GitHub] [incubator-doris] wyb closed pull request #3055: [Spark load] FE creates spark load job and submits spark etl job

2020-05-18 Thread GitBox
wyb closed pull request #3055: URL: https://github.com/apache/incubator-doris/pull/3055 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] morningman commented on a change in pull request #3628: Fix first start error after upgrade doris to support delete dulplicate table value columns

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3628: URL: https://github.com/apache/incubator-doris/pull/3628#discussion_r426621699 ## File path: be/src/olap/rowset/alpha_rowset.cpp ## @@ -300,16 +300,23 @@ OLAPStatus AlphaRowset::init() { if (segment_group_meta.z

[GitHub] [incubator-doris] yangzhg opened a new pull request #3632: Add ignore config to determine whether to continue to start be when load tablet from header failed.

2020-05-18 Thread GitBox
yangzhg opened a new pull request #3632: URL: https://github.com/apache/incubator-doris/pull/3632 Add config `ignore_load_tablet_failure` to determine whether to continue to start be when load tablet from header failed. Thi

[GitHub] [incubator-doris] imay commented on issue #3568: Do not link to dist.apache.org from public pages

2020-05-18 Thread GitBox
imay commented on issue #3568: URL: https://github.com/apache/incubator-doris/issues/3568#issuecomment-630570090 Hi @sebbASF This issue has been fixed, please check This is an automated message from the Apache Git Servic

[GitHub] [incubator-doris] imay commented on issue #3567: Download page issues

2020-05-18 Thread GitBox
imay commented on issue #3567: URL: https://github.com/apache/incubator-doris/issues/3567#issuecomment-630569833 Hi @sebbASF This issue has been fixed, please check This is an automated message from the Apache Git Servic

[GitHub] [incubator-doris] imay merged pull request #3575: [Fix]modify download links(branch-0.11)

2020-05-18 Thread GitBox
imay merged pull request #3575: URL: https://github.com/apache/incubator-doris/pull/3575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-doris] branch branch-0.11 updated: [website] Modify download links(branch-0.11) (#3575)

2020-05-18 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch branch-0.11 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/branch-0.11 by this push: new 589fcac [website] Modify down

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427019024 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "查询结果集导出", Review comment: ok --

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427018439 ## File path: be/src/runtime/result_sink.cpp ## @@ -35,6 +36,17 @@ ResultSink::ResultSink(const RowDescriptor& row_desc, const std::vector&

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427018048 ## File path: be/src/runtime/mysql_result_writer.h ## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427017714 ## File path: be/src/runtime/mysql_result_writer.h ## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427017396 ## File path: be/src/runtime/file_result_writer.cpp ## @@ -0,0 +1,319 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427017242 ## File path: be/src/runtime/file_result_writer.cpp ## @@ -0,0 +1,319 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427016918 ## File path: be/src/runtime/file_result_writer.cpp ## @@ -0,0 +1,319 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-18 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427016796 ## File path: be/src/exec/parquet_writer.cpp ## @@ -0,0 +1,91 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [incubator-doris] vagetablechicken commented on issue #3468: [Memory Engine] Write pipeline external API and data format

2020-05-18 Thread GitBox
vagetablechicken commented on issue #3468: URL: https://github.com/apache/incubator-doris/issues/3468#issuecomment-630563767 Users can load/update/delete data by load JSON format rows, which can be converted to PartialRows. e.g. routine load from Kafka(will soon support JSON format load).

[GitHub] [incubator-doris] wuyunfeng edited a comment on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-05-18 Thread GitBox
wuyunfeng edited a comment on issue #3306: URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-630555113 > 支持对Elasticsearch外表的alter操作这个我处理下 👌cool This is an automated message from the Apache Git Se

[GitHub] [incubator-doris] wuyunfeng commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-05-18 Thread GitBox
wuyunfeng commented on issue #3306: URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-630555113 > 支持对Elasticsearch外表的alter操作这个我处理下 👌, cool This is an automated message from the Apache Git Service

[GitHub] [incubator-doris] stalary commented on a change in pull request #3454: [Doris On ES] Split /_cluster/state to [indexName/_mappings, indexName/_search_shards]

2020-05-18 Thread GitBox
stalary commented on a change in pull request #3454: URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r427005963 ## File path: fe/src/main/java/org/apache/doris/external/EsStateStore.java ## @@ -74,37 +59,48 @@ public void registerTable(EsTable esTable) {

[GitHub] [incubator-doris] stalary commented on a change in pull request #3454: [Doris On ES] Split /_cluster/state to [indexName/_mappings, indexName/_search_shards]

2020-05-18 Thread GitBox
stalary commented on a change in pull request #3454: URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r427005431 ## File path: fe/src/main/java/org/apache/doris/external/EsStateStore.java ## @@ -192,77 +141,75 @@ public EsTableState parseClusterState55(String

[GitHub] [incubator-doris] stalary commented on a change in pull request #3454: [Doris On ES] Split /_cluster/state to [indexName/_mappings, indexName/_search_shards]

2020-05-18 Thread GitBox
stalary commented on a change in pull request #3454: URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r427005210 ## File path: fe/src/main/java/org/apache/doris/external/EsRestClient.java ## @@ -49,48 +54,103 @@ .readTimeout(10, TimeUnit.SECONDS)

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3454: [Doris On ES] Split /_cluster/state to [indexName/_mappings, indexName/_search_shards]

2020-05-18 Thread GitBox
wuyunfeng commented on a change in pull request #3454: URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r426999378 ## File path: fe/src/main/java/org/apache/doris/external/EsStateStore.java ## @@ -74,37 +59,48 @@ public void registerTable(EsTable esTable) {

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3631: [Spark on Doris] Shade and provide the thrift lib in spark-doris-connector

2020-05-18 Thread GitBox
wuyunfeng commented on a change in pull request #3631: URL: https://github.com/apache/incubator-doris/pull/3631#discussion_r426978066 ## File path: extension/spark-doris-connector/pom.xml ## @@ -168,6 +211,10 @@ com.google.flatbuffers

[GitHub] [incubator-doris] morningman opened a new pull request #3631: [Spark on Doris] Shade and provide the thrift lib in spark-doris-connector

2020-05-18 Thread GitBox
morningman opened a new pull request #3631: URL: https://github.com/apache/incubator-doris/pull/3631 Fix: #3630 Mainly changes: 1. Shade and provide the thrift lib in spark-doris-connector 2. Add a `build.sh` for spark-doris-connector 3. Move the README.md of spark-doris-conn

[GitHub] [incubator-doris] morningman opened a new issue #3630: [Spark] Incompatible thrift library

2020-05-18 Thread GitBox
morningman opened a new issue #3630: URL: https://github.com/apache/incubator-doris/issues/3630 **Describe the bug** The spark 2.1 include thrift with version 0.9.2, but `spark-doris-connector` use version 0.9.3. So we need to shade the thrift library in `spark-doris-connector` to avo

[GitHub] [incubator-doris] stalary commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-05-18 Thread GitBox
stalary commented on issue #3306: URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-630234678 支持对Elasticsearch外表的alter操作这个我处理下 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] sduzh opened a new pull request #3629: different cmake build directories for different build types (#3623)

2020-05-18 Thread GitBox
sduzh opened a new pull request #3629: URL: https://github.com/apache/incubator-doris/pull/3629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-doris] yangzhg opened a new pull request #3628: Fix first start error after upgrade doris to support delete dulplicate table value columns

2020-05-18 Thread GitBox
yangzhg opened a new pull request #3628: URL: https://github.com/apache/incubator-doris/pull/3628 Fixes #3627 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] yangzhg opened a new issue #3627: Doris be cannot start after upgrade to 0.12.10

2020-05-18 Thread GitBox
yangzhg opened a new issue #3627: URL: https://github.com/apache/incubator-doris/issues/3627 **Describe the bug** if doris has duplicate tables after upgrade to 0.12.10, the be may failed to start. **To Reproduce** Steps to reproduce the behavior: 1. doris has duplicate tab

[GitHub] [incubator-doris] HappenLee opened a new pull request #3626: Update Compiling environment of BE to Support C++14/17

2020-05-18 Thread GitBox
HappenLee opened a new pull request #3626: URL: https://github.com/apache/incubator-doris/pull/3626 RT issue #3563 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] wkhapy123 closed issue #3525: help .how could docker be not kill by system

2020-05-18 Thread GitBox
wkhapy123 closed issue #3525: URL: https://github.com/apache/incubator-doris/issues/3525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] yangzhg opened a new pull request #3625: support more syntax in case when clause

2020-05-18 Thread GitBox
yangzhg opened a new pull request #3625: URL: https://github.com/apache/incubator-doris/pull/3625 support support more syntax in case-when clause with subquey. suport query like ` case when k1 > subquery1 and k2 < subquey2 then ... else ... ` or `case when subquey in null then ...` --

[GitHub] [incubator-doris] decster commented on a change in pull request #3580: [Memory Engine] Add column reader/writer

2020-05-18 Thread GitBox
decster commented on a change in pull request #3580: URL: https://github.com/apache/incubator-doris/pull/3580#discussion_r426449095 ## File path: be/src/olap/memory/column_writer.h ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [incubator-doris] decster commented on a change in pull request #3580: [Memory Engine] Add column reader/writer

2020-05-18 Thread GitBox
decster commented on a change in pull request #3580: URL: https://github.com/apache/incubator-doris/pull/3580#discussion_r426449191 ## File path: be/src/olap/memory/typed_column_reader.h ## @@ -0,0 +1,221 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] decster commented on a change in pull request #3580: [Memory Engine] Add column reader/writer

2020-05-18 Thread GitBox
decster commented on a change in pull request #3580: URL: https://github.com/apache/incubator-doris/pull/3580#discussion_r426448038 ## File path: be/src/olap/memory/typed_column_reader.h ## @@ -0,0 +1,221 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] decster commented on a change in pull request #3580: [Memory Engine] Add column reader/writer

2020-05-18 Thread GitBox
decster commented on a change in pull request #3580: URL: https://github.com/apache/incubator-doris/pull/3580#discussion_r426447837 ## File path: be/src/olap/memory/typed_column_reader.h ## @@ -0,0 +1,221 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] decster commented on a change in pull request #3580: [Memory Engine] Add column reader/writer

2020-05-18 Thread GitBox
decster commented on a change in pull request #3580: URL: https://github.com/apache/incubator-doris/pull/3580#discussion_r426446742 ## File path: be/src/olap/memory/typed_column_reader.h ## @@ -0,0 +1,221 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] decster commented on a change in pull request #3580: [Memory Engine] Add column reader/writer

2020-05-18 Thread GitBox
decster commented on a change in pull request #3580: URL: https://github.com/apache/incubator-doris/pull/3580#discussion_r426446533 ## File path: be/src/olap/memory/typed_column_writer.h ## @@ -0,0 +1,305 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] decster commented on a change in pull request #3580: [Memory Engine] Add column reader/writer

2020-05-18 Thread GitBox
decster commented on a change in pull request #3580: URL: https://github.com/apache/incubator-doris/pull/3580#discussion_r426438772 ## File path: be/src/olap/memory/typed_column_writer.h ## @@ -0,0 +1,305 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] decster commented on a change in pull request #3580: [Memory Engine] Add column reader/writer

2020-05-18 Thread GitBox
decster commented on a change in pull request #3580: URL: https://github.com/apache/incubator-doris/pull/3580#discussion_r426438450 ## File path: be/src/olap/memory/typed_column_writer.h ## @@ -0,0 +1,305 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] morningman commented on issue #3624: [Proposal] The execution model of compaction needs to improve

2020-05-18 Thread GitBox
morningman commented on issue #3624: URL: https://github.com/apache/incubator-doris/issues/3624#issuecomment-630004739 Good proposal. However, the compaction strategy is difficult to meet all needs. In the case of inaccurate memory statistics, manual intervention may still be requi

[GitHub] [incubator-doris] vagetablechicken opened a new issue #3624: [Proposal] The execution model of compaction needs to improve

2020-05-18 Thread GitBox
vagetablechicken opened a new issue #3624: URL: https://github.com/apache/incubator-doris/issues/3624 ### Current model Each dir creates M threads for base compaction, N threads for cumulative compaction. And compaction threads execute one compaction in one cycle(may skip execution beca