[GitHub] [incubator-doris] morningman opened a new issue #3549: [Proposal] Support `SELECT INTO OUTFILE` feature.

2020-05-10 Thread GitBox
morningman opened a new issue #3549: URL: https://github.com/apache/incubator-doris/issues/3549 ## Motivation Doris' current data export method is relatively simple, and data can only be exported through the `Export` feature. The `Export` feature can only export data in partition le

[GitHub] [incubator-doris] pei-open commented on issue #3516: can not find main class in start_fe.sh

2020-05-10 Thread GitBox
pei-open commented on issue #3516: URL: https://github.com/apache/incubator-doris/issues/3516#issuecomment-626497421 看一下这个文件:https://github.com/apache/incubator-doris/blob/master/bin/start_fe.sh 这个里面的最后一部分 ``` if [ ${RUN_DAEMON} -eq 1 ]; then nohup $LIMIT $JAVA $final_ja

[GitHub] [incubator-doris] WingsGo commented on pull request #3539: Throw DdlException when use admin set frontend config

2020-05-10 Thread GitBox
WingsGo commented on pull request #3539: URL: https://github.com/apache/incubator-doris/pull/3539#issuecomment-626486846 > `fe/src/test/java/org/apache/doris/analysis/AminSetConfigStmtTest` no file extension; done Thi

[GitHub] [incubator-doris] hffariel commented on pull request #3535: [Feature]support documents' fulltext searching

2020-05-10 Thread GitBox
hffariel commented on pull request #3535: URL: https://github.com/apache/incubator-doris/pull/3535#issuecomment-626451277 > By the way, could you please add the branch name you try to merge to in your PR title? > Or there are 3 PR with same name. Sure. -

[GitHub] [incubator-doris] yangzhg opened a new pull request #3548: add doc link to char_length

2020-05-10 Thread GitBox
yangzhg opened a new pull request #3548: URL: https://github.com/apache/incubator-doris/pull/3548 add char_length function link to sidebar This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422757108 ## File path: be/src/olap/memory/column.cpp ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422756451 ## File path: be/src/olap/memory/column.h ## @@ -0,0 +1,101 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

[GitHub] [incubator-doris] decster commented on pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#issuecomment-626446729 > @decster Hi, I have one question: Do we have a data structure to describe the block of rows for multi columns? Like Doris RowBlockV2, Arrow RecordBatch and TiDB Chunk.

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422755103 ## File path: be/src/olap/memory/column_block.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422755073 ## File path: be/src/olap/memory/column.cpp ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422755043 ## File path: be/src/olap/memory/buffer.h ## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422748342 ## File path: be/src/olap/memory/column.cpp ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422748533 ## File path: be/src/olap/memory/column_block.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422748342 ## File path: be/src/olap/memory/column.cpp ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[incubator-doris] branch master updated: Add -Werror when gcc<=7.3.0 & udf fix (#3533)

2020-05-10 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 57cbfb7 Add -Werror when gcc<=7.3.0 & u

[incubator-doris] branch master updated: [ASAN] Fix some address problems detected by ASAN (#3495)

2020-05-10 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new b576e54 [ASAN] Fix some address problem

[GitHub] [incubator-doris] morningman commented on issue #3534: [Proposal]FE audit plugin should support filter useless audit log

2020-05-10 Thread GitBox
morningman commented on issue #3534: URL: https://github.com/apache/incubator-doris/issues/3534#issuecomment-626437183 It's OK? What's your plan? Define the rule in `conf`? This is an automated message from the Apache Git

[GitHub] [incubator-doris] morningman commented on issue #3534: [Proposal]FE audit plugin should support filter useless audit log

2020-05-10 Thread GitBox
morningman commented on issue #3534: URL: https://github.com/apache/incubator-doris/issues/3534#issuecomment-626436572 It's OK? What's your plan? Define the rule in `conf`? This is an automated message from the Apache Git

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3424: allow delete duplicated non-key column using delete from

2020-05-10 Thread GitBox
yangzhg commented on a change in pull request #3424: URL: https://github.com/apache/incubator-doris/pull/3424#discussion_r422745613 ## File path: be/src/olap/olap_cond.cpp ## @@ -637,7 +637,7 @@ bool Conditions::delete_conditions_eval(const RowCursor& row) const { }

[incubator-doris] branch master updated: Identify old empty tablet when add tablet to meta in ReportHandler (#3547)

2020-05-10 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 561765f Identify old empty tablet

[GitHub] [incubator-doris] wyb commented on issue #3010: Spark load etl interface

2020-05-10 Thread GitBox
wyb commented on issue #3010: URL: https://github.com/apache/incubator-doris/issues/3010#issuecomment-626421411 1. User interface: 1.1 Spark resource management Spark is used as an external computing resource in Doris to do ETL work. In the future, there may be other external

[GitHub] [incubator-doris] morningman commented on a change in pull request #3536: [Feature]support documents' fulltext searching

2020-05-10 Thread GitBox
morningman commented on a change in pull request #3536: URL: https://github.com/apache/incubator-doris/pull/3536#discussion_r422644692 ## File path: docs/.vuepress/config.js ## @@ -90,6 +106,7 @@ module.exports = { sidebar: convertSidebar(require('./sidebar/en.js'), '/

[GitHub] [incubator-doris] morningman commented on a change in pull request #3537: [Feature]support documents' fulltext searching

2020-05-10 Thread GitBox
morningman commented on a change in pull request #3537: URL: https://github.com/apache/incubator-doris/pull/3537#discussion_r422644605 ## File path: docs/.vuepress/config.js ## @@ -90,6 +106,7 @@ module.exports = { sidebar: convertSidebar(require('./sidebar/en.js'), '/

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3523: Refactor some redunant code && Replace some UT by UtFrameUtils

2020-05-10 Thread GitBox
WingsGo commented on a change in pull request #3523: URL: https://github.com/apache/incubator-doris/pull/3523#discussion_r422629684 ## File path: fe/src/main/java/org/apache/doris/backup/RestoreJob.java ## @@ -806,7 +739,54 @@ private void checkAndPrepareMeta() { // No

[GitHub] [incubator-doris] WingsGo commented on pull request #3519: Check backend disk has available capactiy by storage medium before create table

2020-05-10 Thread GitBox
WingsGo commented on pull request #3519: URL: https://github.com/apache/incubator-doris/pull/3519#issuecomment-626311134 > By the way, the code refactor can be done in another PR. Or the change list is too long that will be hard for the reviewer to review the core logic of your change.

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3519: Check backend disk has available capactiy by storage medium before create table

2020-05-10 Thread GitBox
WingsGo commented on a change in pull request #3519: URL: https://github.com/apache/incubator-doris/pull/3519#discussion_r422627266 ## File path: fe/src/main/java/org/apache/doris/system/Backend.java ## @@ -346,6 +347,23 @@ public double getMaxDiskUsedPct() { return ma

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3519: Check backend disk has available capactiy by storage medium before create table

2020-05-10 Thread GitBox
WingsGo commented on a change in pull request #3519: URL: https://github.com/apache/incubator-doris/pull/3519#discussion_r422627235 ## File path: fe/src/main/java/org/apache/doris/system/Backend.java ## @@ -346,6 +347,23 @@ public double getMaxDiskUsedPct() { return ma

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3519: Check backend disk has available capactiy by storage medium before create table

2020-05-10 Thread GitBox
WingsGo commented on a change in pull request #3519: URL: https://github.com/apache/incubator-doris/pull/3519#discussion_r422626910 ## File path: fe/src/main/java/org/apache/doris/system/SystemInfoService.java ## @@ -443,7 +390,7 @@ public void releaseBackends(String clusterNam

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3519: Check backend disk has available capactiy by storage medium before create table

2020-05-10 Thread GitBox
WingsGo commented on a change in pull request #3519: URL: https://github.com/apache/incubator-doris/pull/3519#discussion_r422626757 ## File path: fe/src/main/java/org/apache/doris/system/SystemInfoService.java ## @@ -729,8 +639,18 @@ public void releaseBackends(String clusterNa

[incubator-doris] branch master updated (edb3ad6 -> 56db6e7)

2020-05-10 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from edb3ad6 [Deps] Remove redundant com.baidu:jprotobuf (#3322) add 56db6e7 [Config] allow user to co

[GitHub] [incubator-doris] morningman commented on pull request #3488: [Config] allow user to config BRPC socket_max_unwritten_bytes

2020-05-10 Thread GitBox
morningman commented on pull request #3488: URL: https://github.com/apache/incubator-doris/pull/3488#issuecomment-626302019 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] morningman commented on a change in pull request #3519: Check backend disk has available capactiy by storage medium before create table

2020-05-10 Thread GitBox
morningman commented on a change in pull request #3519: URL: https://github.com/apache/incubator-doris/pull/3519#discussion_r422617501 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -4894,8 +4894,7 @@ public void renameTable(Database db, OlapTable ta

[incubator-doris] branch master updated: [Deps] Remove redundant com.baidu:jprotobuf (#3322)

2020-05-10 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new edb3ad6 [Deps] Remove redundant co

[GitHub] [incubator-doris] morningman commented on a change in pull request #3523: Refactor some redunant code && Replace some UT by UtFrameUtils

2020-05-10 Thread GitBox
morningman commented on a change in pull request #3523: URL: https://github.com/apache/incubator-doris/pull/3523#discussion_r422613324 ## File path: fe/src/main/java/org/apache/doris/alter/AlterJob.java ## @@ -189,18 +189,14 @@ protected boolean checkBackendState(Replica replic

[GitHub] [incubator-doris] morningman commented on a change in pull request #3369: Support txn management in db level isolation and use ArrayDeque to improve txn task performance

2020-05-10 Thread GitBox
morningman commented on a change in pull request #3369: URL: https://github.com/apache/incubator-doris/pull/3369#discussion_r422612957 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -1346,81 +359,71 @@ public TransactionIdGenerator

[GitHub] [incubator-doris] morningman commented on pull request #3488: [Config] allow user to config BRPC socket_max_unwritten_bytes

2020-05-10 Thread GitBox
morningman commented on pull request #3488: URL: https://github.com/apache/incubator-doris/pull/3488#issuecomment-626294453 > Hi @morningman do you have any more comments? In addition, I can't see why NewDorisTest failed, but I think it's unrelated to this PR, could you help confirm that?

[GitHub] [incubator-doris] morningman commented on a change in pull request #3544: [FIX] fix some doris web page dispaly error

2020-05-10 Thread GitBox
morningman commented on a change in pull request #3544: URL: https://github.com/apache/incubator-doris/pull/3544#discussion_r422611714 ## File path: fe/src/main/java/org/apache/doris/http/action/WebBaseAction.java ## @@ -54,33 +54,41 @@ public class WebBaseAction extends BaseA

[GitHub] [incubator-doris] morningman commented on pull request #3547: Identify old empty tablet when add tablet to meta in ReportHandler

2020-05-10 Thread GitBox
morningman commented on pull request #3547: URL: https://github.com/apache/incubator-doris/pull/3547#issuecomment-626293183 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
kangkaisen commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422596311 ## File path: be/src/olap/memory/buffer.h ## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [incubator-doris] kangkaisen commented on pull request #3508: [Memory Engine] add core column related classes

2020-05-10 Thread GitBox
kangkaisen commented on pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#issuecomment-626285200 @decster Hi, I have one question: Do we have a data structure to describe `the block of rows for multi columns`? Like Doris `RowBlockV2`, Arrow `RecordBatch` and T