[GitHub] [incubator-doris] yangzhg edited a comment on pull request #3345: [FIX] fix doris string functions not support multibyte string

2020-05-05 Thread GitBox
yangzhg edited a comment on pull request #3345: URL: https://github.com/apache/incubator-doris/pull/3345#issuecomment-624412771 > @yangzhg > BE build failed, can you fix it? @imay `UT` has passed This is an automat

[GitHub] [incubator-doris] decster opened a new issue #3477: Speedup test build

2020-05-05 Thread GitBox
decster opened a new issue #3477: URL: https://github.com/apache/incubator-doris/issues/3477 Currently doris be unittest build a binary per class/file, this leads to large disk space waste and long build time, it should be binary per module at least. ``` [decster@doris-sandbox01

[GitHub] [incubator-doris] Youngwb commented on a change in pull request #3439: Support append_trailing_char_if_absent function

2020-05-05 Thread GitBox
Youngwb commented on a change in pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r420562556 ## File path: docs/en/sql-reference/sql-functions/string-functions/append_trailing_char_if_absent.md ## @@ -0,0 +1,58 @@ +--- +{ +"title": "a

[GitHub] [incubator-doris] yangzhg edited a comment on pull request #3345: [FIX] fix doris string functions not support multibyte string

2020-05-05 Thread GitBox
yangzhg edited a comment on pull request #3345: URL: https://github.com/apache/incubator-doris/pull/3345#issuecomment-624412771 > @yangzhg > BE build failed, can you fix it? @imay done This is an automated message f

[incubator-doris] branch master updated (caa7a07 -> dafb356)

2020-05-05 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from caa7a07 [Query Plan]Support simple transitivity on join predicate pushdown (#3453) add dafb356 [

[incubator-doris] branch branch-0.12 updated: [BugFix] Fix navbar not showing on mobile clients(#3419) & image relative path problem (#3427)

2020-05-05 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch branch-0.12 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/branch-0.12 by this push: new 583ac93 [BugFix] Fix nav

[incubator-doris] branch branch-0.11 updated: [Bugfix] Fix navbar not showing on mobile clients(#3419) & image relative path problem (#3427)

2020-05-05 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch branch-0.11 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/branch-0.11 by this push: new b1aa322 [Bugfix] Fix nav

[GitHub] [incubator-doris] decster commented on a change in pull request #3462: [Memory Engine] Add hash index implementation

2020-05-05 Thread GitBox
decster commented on a change in pull request #3462: URL: https://github.com/apache/incubator-doris/pull/3462#discussion_r420517955 ## File path: be/src/olap/memory/hash_index.cpp ## @@ -0,0 +1,171 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [incubator-doris] decster commented on a change in pull request #3462: [Memory Engine] Add hash index implementation

2020-05-05 Thread GitBox
decster commented on a change in pull request #3462: URL: https://github.com/apache/incubator-doris/pull/3462#discussion_r420518020 ## File path: be/src/olap/memory/hash_index.h ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

[GitHub] [incubator-doris] yangzhg commented on pull request #3345: [FIX] fix doris string functions not support multibyte string

2020-05-05 Thread GitBox
yangzhg commented on pull request #3345: URL: https://github.com/apache/incubator-doris/pull/3345#issuecomment-624412771 > @yangzhg > BE build failed, can you fix it? done This is an automated message from the Apach

[GitHub] [incubator-doris] imay commented on pull request #3345: [FIX] fix doris string functions not support multibyte string

2020-05-05 Thread GitBox
imay commented on pull request #3345: URL: https://github.com/apache/incubator-doris/pull/3345#issuecomment-624404460 > @imay Please review again. You can assign this PR to yourself. Then you will be the moderator of this PR --

[GitHub] [incubator-doris] imay commented on pull request #3345: [FIX] fix doris string functions not support multibyte string

2020-05-05 Thread GitBox
imay commented on pull request #3345: URL: https://github.com/apache/incubator-doris/pull/3345#issuecomment-624404025 @yangzhg BE build failed, can you fix it? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3462: [Memory Engine] Add hash index implementation

2020-05-05 Thread GitBox
kangkaisen commented on a change in pull request #3462: URL: https://github.com/apache/incubator-doris/pull/3462#discussion_r420199814 ## File path: be/src/olap/memory/hash_index.cpp ## @@ -0,0 +1,171 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [incubator-doris] kangkaisen commented on pull request #3345: [FIX] fix doris string functions not support multibyte string

2020-05-05 Thread GitBox
kangkaisen commented on pull request #3345: URL: https://github.com/apache/incubator-doris/pull/3345#issuecomment-624119517 @imay Please review again. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] kangkaisen commented on issue #3464: [Bug]Query failed when fact table has no data in join case

2020-05-05 Thread GitBox
kangkaisen commented on issue #3464: URL: https://github.com/apache/incubator-doris/issues/3464#issuecomment-624117430 >When the leftChildFragment 's has no data and returned num nodes 0, the returned num nodes should be changed to 1. Because for a scan node has no data,there will be as l

[GitHub] [incubator-doris] imay commented on a change in pull request #3439: Support append_trailing_char_if_absent function

2020-05-05 Thread GitBox
imay commented on a change in pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r420145099 ## File path: docs/en/sql-reference/sql-functions/string-functions/append_trailing_char_if_absent.md ## @@ -0,0 +1,58 @@ +--- +{ +"title": "appe

[GitHub] [incubator-doris] morningman commented on a change in pull request #3476: [Bug] Fix bug of Partition prune of constant in predicate

2020-05-05 Thread GitBox
morningman commented on a change in pull request #3476: URL: https://github.com/apache/incubator-doris/pull/3476#discussion_r420131841 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java ## @@ -928,6 +928,14 @@ private PartitionColumnFilter createPar

[GitHub] [incubator-doris] wuyunfeng commented on pull request #3454: [Doris On ES] Split /_cluster/state to [indexName/_mappings, indexName/_search_shards]

2020-05-05 Thread GitBox
wuyunfeng commented on pull request #3454: URL: https://github.com/apache/incubator-doris/pull/3454#issuecomment-624064264 OK This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman commented on pull request #3476: [Bug] Fix bug of Partition prune of constant in predicate

2020-05-05 Thread GitBox
morningman commented on pull request #3476: URL: https://github.com/apache/incubator-doris/pull/3476#issuecomment-624064105 Hi @wutiangan Better to create an issue the describe the bug you met. And link the issue to this PR.

[GitHub] [incubator-doris] wutiangan opened a new pull request #3476: [Bug] Fix bug of Partition prune of constant in predicate

2020-05-05 Thread GitBox
wutiangan opened a new pull request #3476: URL: https://github.com/apache/incubator-doris/pull/3476 **1. phenomenon:** The following two statements are the same, but a query has results and the other query has no results mysql> select * from (select '积极' as kk1, sum(k2) from t

[GitHub] [incubator-doris] morningman opened a new pull request #3475: [Bug] Fix bug of predicate pushdown logic

2020-05-05 Thread GitBox
morningman opened a new pull request #3475: URL: https://github.com/apache/incubator-doris/pull/3475 When there is subquery in where clause, the query will be rewritten to join operation. And some auxiliary binary predicates will be generated. These binary predicates will not go thro

[GitHub] [incubator-doris] morningman opened a new issue #3474: [Bug] Query throw unexpected exception: null

2020-05-05 Thread GitBox
morningman opened a new issue #3474: URL: https://github.com/apache/incubator-doris/issues/3474 **Describe the bug** Query return error: `Unexpected exception: null` **To Reproduce** ``` CREATE TABLE test.`pushdown_test` ( `k1` tinyint(4) NULL COMMENT "", `k2` small

[GitHub] [incubator-doris] Youngwb commented on a change in pull request #3439: Support append_trailing_char_if_absent function

2020-05-05 Thread GitBox
Youngwb commented on a change in pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r420095253 ## File path: docs/en/sql-reference/sql-functions/string-functions/append_trailing_char_if_absent.md ## @@ -0,0 +1,58 @@ +--- +{ +"title": "a

[GitHub] [incubator-doris] imay commented on pull request #3463: vector reserve before push_back

2020-05-05 Thread GitBox
imay commented on pull request #3463: URL: https://github.com/apache/incubator-doris/pull/3463#issuecomment-624034670 Hi @sduzh Please don't push code to unrelated PR next time, better to create another PR. This is a

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3462: [Memory Engine] Add hash index implementation

2020-05-05 Thread GitBox
chaoyli commented on a change in pull request #3462: URL: https://github.com/apache/incubator-doris/pull/3462#discussion_r420023841 ## File path: be/src/olap/memory/hash_index.h ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

[GitHub] [incubator-doris] morningman commented on a change in pull request #3462: [Memory Engine] Add hash index implementation

2020-05-05 Thread GitBox
morningman commented on a change in pull request #3462: URL: https://github.com/apache/incubator-doris/pull/3462#discussion_r420015552 ## File path: be/src/olap/memory/hash_index.cpp ## @@ -0,0 +1,175 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [incubator-doris] decster opened a new issue #3473: [Memory Engine] Old version GC

2020-05-05 Thread GitBox
decster opened a new issue #3473: URL: https://github.com/apache/incubator-doris/issues/3473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-doris] decster opened a new issue #3472: [Memory Engine] Delta compaction

2020-05-05 Thread GitBox
decster opened a new issue #3472: URL: https://github.com/apache/incubator-doris/issues/3472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-doris] decster opened a new issue #3471: [Memory Engine] Read Pipeline basic ScanNode implementation

2020-05-05 Thread GitBox
decster opened a new issue #3471: URL: https://github.com/apache/incubator-doris/issues/3471 First, implement a simple full scan node, so queries can run against this table This is an automated message from the Apache Git Se

[GitHub] [incubator-doris] decster opened a new issue #3470: [Memory Engine] Transaction op handling

2020-05-05 Thread GitBox
decster opened a new issue #3470: URL: https://github.com/apache/incubator-doris/issues/3470 This includes handling of prepare/commit/publish_version requests from load task & FE, and TxManager related code modification. Thi

[GitHub] [incubator-doris] decster opened a new issue #3469: [Memory Engine] Write Pipeline: internal data processing and storage

2020-05-05 Thread GitBox
decster opened a new issue #3469: URL: https://github.com/apache/incubator-doris/issues/3469 This includes how the memory engine handles data write/load quests, write tx WAL, apply write ops etc. This is an automated message

[GitHub] [incubator-doris] morningman commented on a change in pull request #3461: [Decommission] Support NOT dropping BE after decommission

2020-05-05 Thread GitBox
morningman commented on a change in pull request #3461: URL: https://github.com/apache/incubator-doris/pull/3461#discussion_r419989076 ## File path: docs/en/administrator-guide/config/fe_config.md ## @@ -1,7 +1,7 @@ --- { -"title": "Configuration", -"language": "en" +

[GitHub] [incubator-doris] decster opened a new issue #3468: [Memory Engine] Write pipeline external API and data format

2020-05-05 Thread GitBox
decster opened a new issue #3468: URL: https://github.com/apache/incubator-doris/issues/3468 This includes how a user can load/update/delete data into memory engine backed table This is an automated message from the Apac

[GitHub] [incubator-doris] decster opened a new issue #3467: [Memory Engine] Metadata related support for memory engine

2020-05-05 Thread GitBox
decster opened a new issue #3467: URL: https://github.com/apache/incubator-doris/issues/3467 This includes metadata related definitions, operations, and potential code refactors, etc. - [ ] #3442 This is an automa

[GitHub] [incubator-doris] decster opened a new issue #3466: [Memory Engine] Core tablet related classes

2020-05-05 Thread GitBox
decster opened a new issue #3466: URL: https://github.com/apache/incubator-doris/issues/3466 This includes MemTablet, MemSubTablet, tablet reader/writer etc. This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-doris] decster opened a new issue #3465: [Memory Engine] Core column data structure

2020-05-05 Thread GitBox
decster opened a new issue #3465: URL: https://github.com/apache/incubator-doris/issues/3465 This includes column related classes: ColumnBlock, ColumnDelta, DeltaIndex, ColumnReader/Writer This is an automated messag

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-05-05 Thread GitBox
kangpinghuang commented on a change in pull request #3230: URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r419932135 ## File path: be/src/exec/broker_reader.h ## @@ -52,6 +52,7 @@ class BrokerReader : public FileReader { // Read virtual Status re

[GitHub] [incubator-doris] imay commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-05-05 Thread GitBox
imay commented on a change in pull request #3230: URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r419906166 ## File path: be/src/exec/file_reader.h ## @@ -34,6 +34,16 @@ class FileReader { // is set to zero. virtual Status read(uint8_t* buf, size_

[GitHub] [incubator-doris] imay commented on pull request #3454: [Doris On ES] Split /_cluster/state to [indexName/_mappings, indexName/_search_shards]

2020-05-05 Thread GitBox
imay commented on pull request #3454: URL: https://github.com/apache/incubator-doris/pull/3454#issuecomment-623889451 @wuyunfeng Could you please review this PR? @stalary You'd better add more information about this change list in commit message -