[GitHub] [incubator-doris] wangbo commented on issue #3354: (#3353) Colocate Join Bug Fix

2020-04-18 Thread GitBox
wangbo commented on issue #3354: (#3353) Colocate Join Bug Fix URL: https://github.com/apache/incubator-doris/pull/3354#issuecomment-616041312 This pr now is just for review. It can't be merge after I sync this pr to out production env and the error status disappear. ---

[GitHub] [incubator-doris] wangbo opened a new pull request #3354: (#3353) Colocate Join Bug Fix

2020-04-18 Thread GitBox
wangbo opened a new pull request #3354: (#3353) Colocate Join Bug Fix URL: https://github.com/apache/incubator-doris/pull/3354 (#3353) 1 Fix sync error colocate group status between fe 2 Fix missing ```remove table edit log operation```

[GitHub] [incubator-doris] wangbo opened a new issue #3353: [Bug] Colocate Join Bug Fix

2020-04-18 Thread GitBox
wangbo opened a new issue #3353: [Bug] Colocate Join Bug Fix URL: https://github.com/apache/incubator-doris/issues/3353 **Colocate Group sync error status between fe ** This is just a clerical, pr is more clear. **Colocate Group miss remove table operation in edit log** In curr

[GitHub] [incubator-doris] wuyunfeng commented on issue #3352: Add LOG.isDebugEnabled for some debug logical of Coordinator

2020-04-18 Thread GitBox
wuyunfeng commented on issue #3352: Add LOG.isDebugEnabled for some debug logical of Coordinator URL: https://github.com/apache/incubator-doris/pull/3352#issuecomment-616026046 for issue: https://github.com/apache/incubator-doris/issues/3346

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3352: Add LOG.isDebugEnabled for some debug logical of Coordinator

2020-04-18 Thread GitBox
wuyunfeng opened a new pull request #3352: Add LOG.isDebugEnabled for some debug logical of Coordinator URL: https://github.com/apache/incubator-doris/pull/3352 This may very slightly affect the performance or not. This is an

[GitHub] [incubator-doris] wuyunfeng commented on issue #3351: [Doris On ES] Pushdown some castexpr predicate to ES

2020-04-18 Thread GitBox
wuyunfeng commented on issue #3351: [Doris On ES] Pushdown some castexpr predicate to ES URL: https://github.com/apache/incubator-doris/pull/3351#issuecomment-616023623 for https://github.com/apache/incubator-doris/issues/3306 --

[GitHub] [incubator-doris] wuyunfeng commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-04-18 Thread GitBox
wuyunfeng commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-616023600 https://github.com/apache/incubator-doris/pull/3351 for `增加对CastExpr过滤条件的处理` ---

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3351: [Doris On ES] Pushdown some castexpr predicate to ES

2020-04-18 Thread GitBox
wuyunfeng opened a new pull request #3351: [Doris On ES] Pushdown some castexpr predicate to ES URL: https://github.com/apache/incubator-doris/pull/3351 Process castexpr, such as: k (float) > 2.0, k(int) > 3.2, Doris On Es should ignore this doris native cast transformation for every row'

[GitHub] [incubator-doris] morningman closed issue #3190: [Optimize] Simplify the delete process

2020-04-18 Thread GitBox
morningman closed issue #3190: [Optimize] Simplify the delete process URL: https://github.com/apache/incubator-doris/issues/3190 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-doris] branch master updated: [Delete] Make some correct in delete operation (#3338)

2020-04-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new c223d37 [Delete] Make some correct

[GitHub] [incubator-doris] morningman merged pull request #3338: [ISSUE #3190]Make some correct in delete

2020-04-18 Thread GitBox
morningman merged pull request #3338: [ISSUE #3190]Make some correct in delete URL: https://github.com/apache/incubator-doris/pull/3338 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] morningman commented on a change in pull request #3345: [FIX] fix doris string functions not support multibyte string

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3345: [FIX] fix doris string functions not support multibyte string URL: https://github.com/apache/incubator-doris/pull/3345#discussion_r410261854 ## File path: be/src/exprs/string_functions.cpp ## @@ -37,19 +37,55 @@ void

[GitHub] [incubator-doris] morningman commented on a change in pull request #3340: [SegmentV2] Optimize the upgrade logic of SegmentV2

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3340: [SegmentV2] Optimize the upgrade logic of SegmentV2 URL: https://github.com/apache/incubator-doris/pull/3340#discussion_r410805271 ## File path: docs/documentation/cn/administrator-guide/segment-v2-usage.md ## @@ -1,1

[GitHub] [incubator-doris] morningman merged pull request #3350: MOD: fix some typo, mod routine load doc

2020-04-18 Thread GitBox
morningman merged pull request #3350: MOD: fix some typo, mod routine load doc URL: https://github.com/apache/incubator-doris/pull/3350 This is an automated message from the Apache Git Service. To respond to the message, plea

[incubator-doris] branch master updated: [Doc] Fix some typo, mod routine load doc (#3350)

2020-04-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 1d33705 [Doc] Fix some typo, mod r

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410713063 ## File path: be/src/exec/json_scanner.h ## @@ -0,0 +1,140 @@ +// Licensed

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410707220 ## File path: be/src/exec/json_scanner.h ## @@ -0,0 +1,140 @@ +// Licensed

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410713892 ## File path: be/src/exprs/json_functions.cpp ## @@ -209,31 +162,138 @@ rap

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410712486 ## File path: be/src/exec/json_scanner.cpp ## @@ -0,0 +1,485 @@ +// License

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410711587 ## File path: be/src/exec/json_scanner.cpp ## @@ -0,0 +1,485 @@ +// License

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410713273 ## File path: be/src/exec/json_scanner.cpp ## @@ -0,0 +1,485 @@ +// License

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410703515 ## File path: be/src/exprs/json_functions.cpp ## @@ -107,75 +107,28 @@ Doub

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410713975 ## File path: be/src/exec/json_scanner.cpp ## @@ -0,0 +1,485 @@ +// License

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410710996 ## File path: be/src/exec/json_scanner.cpp ## @@ -0,0 +1,485 @@ +// License

[GitHub] [incubator-doris] morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-04-18 Thread GitBox
morningman commented on a change in pull request #3230: Support load json-data into Doris by RoutineLoad or StreamLoad URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r410710574 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/R

[GitHub] [incubator-doris] kangkaisen merged pull request #3335: [ISSUE #3190]Add documents for delete simplifly

2020-04-18 Thread GitBox
kangkaisen merged pull request #3335: [ISSUE #3190]Add documents for delete simplifly URL: https://github.com/apache/incubator-doris/pull/3335 This is an automated message from the Apache Git Service. To respond to the messa

[incubator-doris] branch master updated: [ISSUE #3190]Add documents for delete simplifly (#3335)

2020-04-18 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 31ebb24 [ISSUE #3190]Add documents

[GitHub] [incubator-doris] kangkaisen merged pull request #3336: fix cooldown timestamp bug

2020-04-18 Thread GitBox
kangkaisen merged pull request #3336: fix cooldown timestamp bug URL: https://github.com/apache/incubator-doris/pull/3336 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[incubator-doris] branch master updated: Fix cooldown timestamp bug (#3336)

2020-04-18 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 77a7037 Fix cooldown timestamp bug

[GitHub] [incubator-doris] kangkaisen commented on issue #3343: Can we update BRPC to newer version for prometheus support?

2020-04-18 Thread GitBox
kangkaisen commented on issue #3343: Can we update BRPC to newer version for prometheus support? URL: https://github.com/apache/incubator-doris/issues/3343#issuecomment-615881788 I think we could update BRPC version, but we need strict test firstly. @vagetablechicken Are you willing to do

[GitHub] [incubator-doris] kangkaisen commented on issue #3348: [Bug] Partition key's type has been changed after executing queries

2020-04-18 Thread GitBox
kangkaisen commented on issue #3348: [Bug] Partition key's type has been changed after executing queries URL: https://github.com/apache/incubator-doris/pull/3348#issuecomment-615877943 @morningman Hi, Please add a UT. This is

[GitHub] [incubator-doris] kangkaisen closed issue #3329: TxnManager::commit_txn may have race condition because of lack of txn lock

2020-04-18 Thread GitBox
kangkaisen closed issue #3329: TxnManager::commit_txn may have race condition because of lack of txn lock URL: https://github.com/apache/incubator-doris/issues/3329 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-doris] kangkaisen merged pull request #3330: Fix rowset_meta race condition for commit_txn in TxnManager

2020-04-18 Thread GitBox
kangkaisen merged pull request #3330: Fix rowset_meta race condition for commit_txn in TxnManager URL: https://github.com/apache/incubator-doris/pull/3330 This is an automated message from the Apache Git Service. To respond

[incubator-doris] branch master updated: Fix rowset_meta race condition for commit_txn in TxnManager (#3330)

2020-04-18 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 67b0da5 Fix rowset_meta race condi

[GitHub] [incubator-doris] chaoyli edited a comment on issue #3330: Fix rowset_meta race condition for commit_txn in TxnManager

2020-04-18 Thread GitBox
chaoyli edited a comment on issue #3330: Fix rowset_meta race condition for commit_txn in TxnManager URL: https://github.com/apache/incubator-doris/pull/3330#issuecomment-615834669 I discuss with @kangkaisen, you can use the _txn_mutex still. ---

[GitHub] [incubator-doris] chaoyli commented on issue #3330: Fix rowset_meta race condition for commit_txn in TxnManager

2020-04-18 Thread GitBox
chaoyli commented on issue #3330: Fix rowset_meta race condition for commit_txn in TxnManager URL: https://github.com/apache/incubator-doris/pull/3330#issuecomment-615834669 You can use the _txn_mutex still This is an automat

[GitHub] [incubator-doris] imay commented on issue #3349: [bug]Doris Documentations 给出的sql语句示例为中文

2020-04-18 Thread GitBox
imay commented on issue #3349: [bug]Doris Documentations 给出的sql语句示例为中文 URL: https://github.com/apache/incubator-doris/issues/3349#issuecomment-615831255 @jevic 你可以提交个PR帮我们修复这个问题 This is an automated message from the Apach

[GitHub] [incubator-doris] stalary opened a new pull request #3350: MOD: fix some typo, mod routine load doc

2020-04-18 Thread GitBox
stalary opened a new pull request #3350: MOD: fix some typo, mod routine load doc URL: https://github.com/apache/incubator-doris/pull/3350 Fix BOOLEAN typo, improve the routine load sample This is an automated message from th