[GitHub] [incubator-doris] HangyuanLiu opened a new issue #3213: [Bug] Cast expr in predicate result in wrong result

2020-03-26 Thread GitBox
HangyuanLiu opened a new issue #3213: [Bug] Cast expr in predicate result in wrong result URL: https://github.com/apache/incubator-doris/issues/3213 ![image](https://user-images.githubusercontent.com/12147090/77729052-becff280-7038-11ea-9cba-b1c24533629d.png) -

[GitHub] [incubator-doris] chaoyli commented on issue #3207: StorageEngine: unused_rowsets use unordered_multimap

2020-03-26 Thread GitBox
chaoyli commented on issue #3207: StorageEngine: unused_rowsets use unordered_multimap URL: https://github.com/apache/incubator-doris/pull/3207#issuecomment-604837961 LGTM This is an automated message from the Apache Git Serv

[GitHub] [incubator-doris] chaoyli merged pull request #3207: StorageEngine: unused_rowsets use unordered_multimap

2020-03-26 Thread GitBox
chaoyli merged pull request #3207: StorageEngine: unused_rowsets use unordered_multimap URL: https://github.com/apache/incubator-doris/pull/3207 This is an automated message from the Apache Git Service. To respond to the mes

[incubator-doris] branch master updated: StorageEngine: unused_rowsets use unordered_multimap (#3207)

2020-03-26 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 0462607 StorageEngine: unused_rows

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211#discussion_r399057171 ## File path: be/src/agent/task_worker_pool.cpp ## @@ -668,8 +658,8 @@ void* TaskWorkerPool::_push_worker_

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211#discussion_r399057491 ## File path: be/src/agent/task_worker_pool.cpp ## @@ -1169,7 +1160,8 @@ void* TaskWorkerPool::_report_ta

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211#discussion_r399057343 ## File path: be/src/agent/task_worker_pool.cpp ## @@ -967,8 +956,8 @@ void* TaskWorkerPool::_storage_med

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211#discussion_r399057425 ## File path: be/src/agent/task_worker_pool.cpp ## @@ -1016,20 +1005,17 @@ void* TaskWorkerPool::_check_c

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
chaoyli commented on a change in pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211#discussion_r399057245 ## File path: be/src/agent/task_worker_pool.cpp ## @@ -718,11 +708,12 @@ void* TaskWorkerPool::_publish_v

[GitHub] [incubator-doris] imay commented on a change in pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
imay commented on a change in pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211#discussion_r399049053 ## File path: be/src/exprs/utility_functions.cpp ## @@ -17,27 +17,25 @@ #include "exprs/utility_functions.

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-26 Thread GitBox
vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r399037164 ## File path: be/src/exec/tablet_sink.cpp ## @@ -186,80 +267,89 @@ void NodeChannel::cancel() { cl

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
vagetablechicken commented on a change in pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211#discussion_r399033631 ## File path: be/src/exprs/utility_functions.cpp ## @@ -17,27 +17,25 @@ #include "exprs/utilit

[GitHub] [incubator-doris] WingsGo commented on issue #3212: [Alter]Clean SchemaChangeJobV2 when schema change CANCELLED or FINISHED

2020-03-26 Thread GitBox
WingsGo commented on issue #3212: [Alter]Clean SchemaChangeJobV2 when schema change CANCELLED or FINISHED URL: https://github.com/apache/incubator-doris/pull/3212#issuecomment-604811091 For #3132 This is an automated message

[GitHub] [incubator-doris] WingsGo opened a new pull request #3212: [Alter]Clean SchemaChangeJobV2 when schema change CANCELLED or FINISHED

2020-03-26 Thread GitBox
WingsGo opened a new pull request #3212: [Alter]Clean SchemaChangeJobV2 when schema change CANCELLED or FINISHED URL: https://github.com/apache/incubator-doris/pull/3212 SchemaChangeJobV2 will use too much memory in FE, which may casuse FullGC. But these data is useless after job is done,

[GitHub] [incubator-doris] imay commented on a change in pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
imay commented on a change in pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211#discussion_r399016712 ## File path: be/src/exprs/utility_functions.cpp ## @@ -17,27 +17,25 @@ #include "exprs/utility_functions.

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #3211: use SleepFor() instead of usleep()

2020-03-26 Thread GitBox
vagetablechicken opened a new pull request #3211: use SleepFor() instead of usleep() URL: https://github.com/apache/incubator-doris/pull/3211 https://github.com/apache/incubator-doris/issues/3204#issuecomment-604334778 contains so many reformat diffs, please use commit filter, or I c

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3090: (#3088) Support Java version 64 bits Integers for BITMAP type

2020-03-26 Thread GitBox
wangbo commented on a change in pull request #3090: (#3088) Support Java version 64 bits Integers for BITMAP type URL: https://github.com/apache/incubator-doris/pull/3090#discussion_r399006301 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/Roaring64Map.java ##

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #3209: Add 'IndexKeysType' field in 'Desc all table stmt'

2020-03-26 Thread GitBox
EmmyMiao87 commented on issue #3209: Add 'IndexKeysType' field in 'Desc all table stmt' URL: https://github.com/apache/incubator-doris/pull/3209#issuecomment-604785331 > I think only show IndexKeysType isn't enough,we need also show the materialized view sql. > @EmmyMiao87 Hi, Currently

[GitHub] [incubator-doris] imay commented on a change in pull request #3172: Change some config

2020-03-26 Thread GitBox
imay commented on a change in pull request #3172: Change some config URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r398694002 ## File path: conf/be.conf ## @@ -36,15 +36,16 @@ brpc_port = 8060 # you can specify the storage medium of each root path, HD

[GitHub] [incubator-doris] morningman commented on a change in pull request #3090: (#3088) Support Java version 64 bits Integers for BITMAP type

2020-03-26 Thread GitBox
morningman commented on a change in pull request #3090: (#3088) Support Java version 64 bits Integers for BITMAP type URL: https://github.com/apache/incubator-doris/pull/3090#discussion_r398644115 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/Roaring64Map.java ###

[GitHub] [incubator-doris] morningman commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations

2020-03-26 Thread GitBox
morningman commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations URL: https://github.com/apache/incubator-doris/pull/3201#discussion_r398630183 ## File path: fe/src/main/java/org/apache/doris/analysis/AddPart

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level

2020-03-26 Thread GitBox
caiconghui commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level URL: https://github.com/apache/incubator-doris/pull/3196#discussion_r398629922 ## File path: fe/src/main/java/org/apache/doris/transaction/Transaction

[GitHub] [incubator-doris] morningman commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations

2020-03-26 Thread GitBox
morningman commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations URL: https://github.com/apache/incubator-doris/pull/3201#discussion_r398629773 ## File path: fe/src/main/java/org/apache/doris/alter/AlterOpera

[GitHub] [incubator-doris] morningman commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations

2020-03-26 Thread GitBox
morningman commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations URL: https://github.com/apache/incubator-doris/pull/3201#discussion_r398628232 ## File path: fe/src/main/java/org/apache/doris/alter/AlterOpTyp

[GitHub] [incubator-doris] morningman commented on issue #3143: Non blocking OlapTableSink

2020-03-26 Thread GitBox
morningman commented on issue #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#issuecomment-604467763 Hi @vagetablechicken , please resolve the conflict. And Hi @imay , do you have any other comment? --

[GitHub] [incubator-doris] morningman commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-26 Thread GitBox
morningman commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r398612691 ## File path: be/src/exec/tablet_sink.cpp ## @@ -186,80 +267,89 @@ void NodeChannel::cancel() { closure-

[GitHub] [incubator-doris] morningman commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level

2020-03-26 Thread GitBox
morningman commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level URL: https://github.com/apache/incubator-doris/pull/3196#discussion_r398591258 ## File path: fe/src/main/java/org/apache/doris/transaction/Transaction

[GitHub] [incubator-doris] morningman commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level

2020-03-26 Thread GitBox
morningman commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level URL: https://github.com/apache/incubator-doris/pull/3196#discussion_r398589961 ## File path: fe/src/main/java/org/apache/doris/transaction/Transaction

[GitHub] [incubator-doris] morningman commented on a change in pull request #3208: Sql reference of materialized view

2020-03-26 Thread GitBox
morningman commented on a change in pull request #3208: Sql reference of materialized view URL: https://github.com/apache/incubator-doris/pull/3208#discussion_r398577717 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE MATERIALIZED VIEW.md ##

[incubator-doris] branch master updated: [Spark] Support convert Arrow data to RowBatch asynchronously in Spark-Doris-Connector (#3186)

2020-03-26 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 16b61b6 [Spark] Support convert A

[GitHub] [incubator-doris] morningman merged pull request #3186: Support convert Arrow data to RowBatch asynchronously in Spark-Doris-Connector

2020-03-26 Thread GitBox
morningman merged pull request #3186: Support convert Arrow data to RowBatch asynchronously in Spark-Doris-Connector URL: https://github.com/apache/incubator-doris/pull/3186 This is an automated message from the Apache Git

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations

2020-03-26 Thread GitBox
kangkaisen commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations URL: https://github.com/apache/incubator-doris/pull/3201#discussion_r398568426 ## File path: fe/src/main/java/org/apache/doris/alter/AlterOpera

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations

2020-03-26 Thread GitBox
kangkaisen commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations URL: https://github.com/apache/incubator-doris/pull/3201#discussion_r398572556 ## File path: fe/src/main/java/org/apache/doris/analysis/AddPart

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations

2020-03-26 Thread GitBox
kangkaisen commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations URL: https://github.com/apache/incubator-doris/pull/3201#discussion_r398564708 ## File path: fe/src/main/java/org/apache/doris/alter/AlterOpTyp

[GitHub] [incubator-doris] kangkaisen merged pull request #3206: Rewritten subquery in having clause

2020-03-26 Thread GitBox
kangkaisen merged pull request #3206: Rewritten subquery in having clause URL: https://github.com/apache/incubator-doris/pull/3206 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] kangkaisen closed issue #3205: The 'between and' in having subquery is not rewritten.

2020-03-26 Thread GitBox
kangkaisen closed issue #3205: The 'between and' in having subquery is not rewritten. URL: https://github.com/apache/incubator-doris/issues/3205 This is an automated message from the Apache Git Service. To respond to the mes

[incubator-doris] branch master updated: Rewritten subquery in having clause (#3206)

2020-03-26 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new c4c37a4 Rewritten subquery in havi

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level

2020-03-26 Thread GitBox
kangkaisen commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level URL: https://github.com/apache/incubator-doris/pull/3196#discussion_r398546798 ## File path: fe/src/test/java/org/apache/doris/load/loadv2/LoadJobTest

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level

2020-03-26 Thread GitBox
kangkaisen commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level URL: https://github.com/apache/incubator-doris/pull/3196#discussion_r398558113 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTran

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level

2020-03-26 Thread GitBox
kangkaisen commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level URL: https://github.com/apache/incubator-doris/pull/3196#discussion_r398550613 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTran

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level

2020-03-26 Thread GitBox
kangkaisen commented on a change in pull request #3196: Support determine isPreviousLoadFinished for some alter jobs in table level URL: https://github.com/apache/incubator-doris/pull/3196#discussion_r398547815 ## File path: fe/src/main/java/org/apache/doris/transaction/Transaction

[GitHub] [incubator-doris] xiaoyeblue opened a new issue #3210: Exception about "Filesystem closed" in broker load,any help will be appreciated

2020-03-26 Thread GitBox
xiaoyeblue opened a new issue #3210: Exception about "Filesystem closed" in broker load,any help will be appreciated URL: https://github.com/apache/incubator-doris/issues/3210 1. Load task failed msg: 'type:LOAD_RUN_FAIL; msg:Open broker reader failed, broker:TNetworkAddress(hostname

[GitHub] [incubator-doris] kangkaisen commented on issue #3209: Add 'IndexKeysType' field in 'Desc all table stmt'

2020-03-26 Thread GitBox
kangkaisen commented on issue #3209: Add 'IndexKeysType' field in 'Desc all table stmt' URL: https://github.com/apache/incubator-doris/pull/3209#issuecomment-604407793 I think only show IndexKeysType isn't enough,we need also show the materialized view sql. @EmmyMiao87 Hi, Currently, do

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3207: StorageEngine: unused_rowsets use unordered_multimap

2020-03-26 Thread GitBox
vagetablechicken commented on a change in pull request #3207: StorageEngine: unused_rowsets use unordered_multimap URL: https://github.com/apache/incubator-doris/pull/3207#discussion_r398535226 ## File path: be/src/olap/storage_engine.h ## @@ -296,7 +296,9 @@ class Storage

[GitHub] [incubator-doris] vagetablechicken removed a comment on issue #3207: StorageEngine: unused_rowsets use unordered_multimap

2020-03-26 Thread GitBox
vagetablechicken removed a comment on issue #3207: StorageEngine: unused_rowsets use unordered_multimap URL: https://github.com/apache/incubator-doris/pull/3207#issuecomment-604404054 It couldn't be better. I'll fix it. 原始信息 发件人: lichaoyong 日期: 2020/3/26 19:4

[GitHub] [incubator-doris] vagetablechicken commented on issue #3207: StorageEngine: unused_rowsets use unordered_multimap

2020-03-26 Thread GitBox
vagetablechicken commented on issue #3207: StorageEngine: unused_rowsets use unordered_multimap URL: https://github.com/apache/incubator-doris/pull/3207#issuecomment-604404054 It couldn't be better. I'll fix it. 原始信息 发件人: lichaoyong 日期: 2020/3/26 19:42 (GMT+0

[incubator-doris] branch master updated: [rowset id] A little improvement of rowset id generator (#3203)

2020-03-26 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new cc31bf9 [rowset id] A little improvemen

[GitHub] [incubator-doris] imay merged pull request #3203: [rowset id] A little improvement of rowset id generator

2020-03-26 Thread GitBox
imay merged pull request #3203: [rowset id] A little improvement of rowset id generator URL: https://github.com/apache/incubator-doris/pull/3203 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #3209: Add 'IndexKeysType' field in 'Desc all table stmt'

2020-03-26 Thread GitBox
EmmyMiao87 opened a new pull request #3209: Add 'IndexKeysType' field in 'Desc all table stmt' URL: https://github.com/apache/incubator-doris/pull/3209 After doris support aggregation materialized view on duplicate table, desc stmt of metadata is confused in sometimes. The reason is tha

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3207: StorageEngine: unused_rowsets use unordered_multimap

2020-03-26 Thread GitBox
chaoyli commented on a change in pull request #3207: StorageEngine: unused_rowsets use unordered_multimap URL: https://github.com/apache/incubator-doris/pull/3207#discussion_r398507447 ## File path: be/src/olap/storage_engine.h ## @@ -296,7 +296,9 @@ class StorageEngine {

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #3208: Sql reference of materialized view

2020-03-26 Thread GitBox
EmmyMiao87 opened a new pull request #3208: Sql reference of materialized view URL: https://github.com/apache/incubator-doris/pull/3208 Sql reference of Create and drop materialized view in English and Chinese. This is an auto

[GitHub] [incubator-doris] vagetablechicken commented on issue #3204: usleep() is obsolete, and may be set the wrong interval by integer overflow

2020-03-26 Thread GitBox
vagetablechicken commented on issue #3204: usleep() is obsolete, and may be set the wrong interval by integer overflow URL: https://github.com/apache/incubator-doris/issues/3204#issuecomment-604334778 > The usual C++11 std::this_thread::sleep_for is not high resolution sleep. Many

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #3207: StorageEngine: unused_rowsets use unordered_multimap

2020-03-26 Thread GitBox
vagetablechicken opened a new pull request #3207: StorageEngine: unused_rowsets use unordered_multimap URL: https://github.com/apache/incubator-doris/pull/3207 Ref https://github.com/apache/incubator-doris/issues/3199 using unordered_multimap lets StorageEngine::check_rowset_id_in_u

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #3206: Rewritten subquery in having clause

2020-03-26 Thread GitBox
EmmyMiao87 opened a new pull request #3206: Rewritten subquery in having clause URL: https://github.com/apache/incubator-doris/pull/3206 The subquery in having clause should be rewritten too. If not, ExprRewriteRule will not be apply in subquery. For example: select k1, sum (k2) fro

[GitHub] [incubator-doris] EmmyMiao87 opened a new issue #3205: The 'between and' in having subquery is not rewritten.

2020-03-26 Thread GitBox
EmmyMiao87 opened a new issue #3205: The 'between and' in having subquery is not rewritten. URL: https://github.com/apache/incubator-doris/issues/3205 **Describe the bug** query: ``` select k1, sum (k2) from all_type_table group by k1 having sum(k2) > (select k1 from all_type