[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395959565 ## File path: be/src/exec/tablet_sink.cpp ## @@ -877,5 +920,24 @@ int OlapTableSink::_validate_data(Runti

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395963965 ## File path: be/src/exec/tablet_sink.cpp ## @@ -128,55 +129,128 @@ Status NodeChannel::open_wait() {

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395959565 ## File path: be/src/exec/tablet_sink.cpp ## @@ -877,5 +920,24 @@ int OlapTableSink::_validate_data(Runti

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395956321 ## File path: be/src/exec/tablet_sink.cpp ## @@ -128,55 +129,128 @@ Status NodeChannel::open_wait() {

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
imay commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395954239 ## File path: be/src/exec/tablet_sink.cpp ## @@ -128,55 +129,128 @@ Status NodeChannel::open_wait() { _open_closu

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
imay commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395953272 ## File path: be/src/exec/tablet_sink.cpp ## @@ -186,80 +260,90 @@ void NodeChannel::cancel() { closure->ref();

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
imay commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395951339 ## File path: be/src/exec/tablet_sink.cpp ## @@ -128,55 +129,128 @@ Status NodeChannel::open_wait() { _open_closu

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
imay commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395951806 ## File path: be/src/exec/tablet_sink.cpp ## @@ -877,5 +920,24 @@ int OlapTableSink::_validate_data(RuntimeState* stat

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
imay commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395953751 ## File path: be/src/exec/tablet_sink.cpp ## @@ -611,57 +633,79 @@ Status OlapTableSink::close(RuntimeState* state, St

[incubator-doris] branch master updated: Remove deep copy when doing hash table EvalRow (#3171)

2020-03-20 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new dd8d748 Remove deep copy when doing has

[GitHub] [incubator-doris] imay merged pull request #3171: Fix group by varchar column bug

2020-03-20 Thread GitBox
imay merged pull request #3171: Fix group by varchar column bug URL: https://github.com/apache/incubator-doris/pull/3171 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] wyb opened a new pull request #3171: Fix group by varchar column bug

2020-03-20 Thread GitBox
wyb opened a new pull request #3171: Fix group by varchar column bug URL: https://github.com/apache/incubator-doris/pull/3171 remove varchar column deep copy in partition hash table EvalRow function This is an automated messag

[GitHub] [incubator-doris] wyb opened a new issue #3170: [Bug] memory exceed limit when group by varchar columns

2020-03-20 Thread GitBox
wyb opened a new issue #3170: [Bug] memory exceed limit when group by varchar columns URL: https://github.com/apache/incubator-doris/issues/3170 4 backends, 32G memory per backend Errors happen when execute two SQLs concurrently. ERROR 1064 (HY000): errCode = 2, detailMessage

[GitHub] [incubator-doris] morningman opened a new pull request #3169: [RoutineLoad] Fix bug that job will be paused when table is altering

2020-03-20 Thread GitBox
morningman opened a new pull request #3169: [RoutineLoad] Fix bug that job will be paused when table is altering URL: https://github.com/apache/incubator-doris/pull/3169 Also add some debug log to observe the cost time of the process of routine load task ISSUE: #3168 --

[GitHub] [incubator-doris] morningman opened a new issue #3168: [Bug] Routine load task is paused when table is altering

2020-03-20 Thread GitBox
morningman opened a new issue #3168: [Bug] Routine load task is paused when table is altering URL: https://github.com/apache/incubator-doris/issues/3168 **Describe the bug** First, create a routine load job, than begin to alter the table, the job may be pause because following error:

[GitHub] [incubator-doris] morningman merged pull request #3167: remove right join

2020-03-20 Thread GitBox
morningman merged pull request #3167: remove right join URL: https://github.com/apache/incubator-doris/pull/3167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[incubator-doris] branch master updated (47a3d50 -> d29ed84)

2020-03-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 47a3d50 [UnitTest] Fix unit test bug in BetaRowset and PageCacheTest (#3157) add d29ed84 [Bug]

[GitHub] [incubator-doris] yangzhg opened a new pull request #3167: remove right join

2020-03-20 Thread GitBox
yangzhg opened a new pull request #3167: remove right join URL: https://github.com/apache/incubator-doris/pull/3167 remove right join This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] morningman merged pull request #3157: Fix unit test bug in BetaRowset and PageCacheTest

2020-03-20 Thread GitBox
morningman merged pull request #3157: Fix unit test bug in BetaRowset and PageCacheTest URL: https://github.com/apache/incubator-doris/pull/3157 This is an automated message from the Apache Git Service. To respond to the mes

[incubator-doris] branch master updated: [UnitTest] Fix unit test bug in BetaRowset and PageCacheTest (#3157)

2020-03-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 47a3d50 [UnitTest] Fix unit test b

[incubator-doris] branch master updated (2dc995d -> 6beadfd)

2020-03-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 2dc995d [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table (#3166)

[GitHub] [incubator-doris] morningman merged pull request #3164: fix delete predicate bug for v2

2020-03-20 Thread GitBox
morningman merged pull request #3164: fix delete predicate bug for v2 URL: https://github.com/apache/incubator-doris/pull/3164 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-doris] branch master updated (5a8fcd2 -> 2dc995d)

2020-03-20 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 5a8fcd2 [CodeStyle] Delete obsolete code of partition_aggregation_node and partitioned_hash_table (#31

[GitHub] [incubator-doris] chaoyli merged pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table

2020-03-20 Thread GitBox
chaoyli merged pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table URL: https://github.com/apache/incubator-doris/pull/3166 This is an automated message from the Apache Git Se

[GitHub] [incubator-doris] wangbo commented on issue #3090: (#3088) Support Java version 64 bits Integers for BITMAP type

2020-03-20 Thread GitBox
wangbo commented on issue #3090: (#3088) Support Java version 64 bits Integers for BITMAP type URL: https://github.com/apache/incubator-doris/pull/3090#issuecomment-601663649 major change 1. put 32-bit integer and long type which fits 32-bit to container 0 2. ut fix 3. some NPE f

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table

2020-03-20 Thread GitBox
chaoyli commented on a change in pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table URL: https://github.com/apache/incubator-doris/pull/3166#discussion_r395577456 ## File path: be/src/exec/partitioned_hash_table.h ## @@ -42

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table

2020-03-20 Thread GitBox
chaoyli commented on a change in pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table URL: https://github.com/apache/incubator-doris/pull/3166#discussion_r395576703 ## File path: be/src/exec/partitioned_aggregation_node_ir.cc

[GitHub] [incubator-doris] HappenLee opened a new pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table

2020-03-20 Thread GitBox
HappenLee opened a new pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table URL: https://github.com/apache/incubator-doris/pull/3166 This is an automated message from the Apach

[GitHub] [incubator-doris] chaoyli commented on issue #3157: Rename NewPartitionedAggregationNode to PartitionedAggregationNode

2020-03-20 Thread GitBox
chaoyli commented on issue #3157: Rename NewPartitionedAggregationNode to PartitionedAggregationNode URL: https://github.com/apache/incubator-doris/pull/3157#issuecomment-601646522 #3165 This is an automated message from the

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395548920 ## File path: be/src/exec/tablet_sink.h ## @@ -47,18 +48,101 @@ class ExprContext; class TExpr; names

[GitHub] [incubator-doris] chaoyli commented on issue #3165: BetaRowset and PageCacheTest unit test failed

2020-03-20 Thread GitBox
chaoyli commented on issue #3165: BetaRowset and PageCacheTest unit test failed URL: https://github.com/apache/incubator-doris/issues/3165#issuecomment-601626730 PageCacheTest failed because the value is reused of two cache entry. The value is stored in buf which memory is allocated dynami

[GitHub] [incubator-doris] chaoyli commented on issue #3165: BetaRowset and PageCacheTest unit test failed

2020-03-20 Thread GitBox
chaoyli commented on issue #3165: BetaRowset and PageCacheTest unit test failed URL: https://github.com/apache/incubator-doris/issues/3165#issuecomment-601625514 BetaRowset failed because of initializing storage engine failed after import block_manager. Before block_manger are initializ

[GitHub] [incubator-doris] chaoyli edited a comment on issue #3165: BetaRowset and PageCacheTest unit test failed

2020-03-20 Thread GitBox
chaoyli edited a comment on issue #3165: BetaRowset and PageCacheTest unit test failed URL: https://github.com/apache/incubator-doris/issues/3165#issuecomment-601625514 BetaRowset unit test failed because of initializing storage engine failed after import block_manager. Before block_ma

[GitHub] [incubator-doris] chaoyli opened a new issue #3165: BetaRowset and PageCacheTest unit test failed

2020-03-20 Thread GitBox
chaoyli opened a new issue #3165: BetaRowset and PageCacheTest unit test failed URL: https://github.com/apache/incubator-doris/issues/3165 I run all the unit test of BE. And unit test related to BetaRowset and PageCacheTest are failed. -

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #3164: fix delete predicate bug for v2

2020-03-20 Thread GitBox
kangpinghuang opened a new pull request #3164: fix delete predicate bug for v2 URL: https://github.com/apache/incubator-doris/pull/3164 This bug is caused that the min and max wrapper field is not inited when there is no predicate of that column. Issue: #3163 -

[GitHub] [incubator-doris] kangpinghuang opened a new issue #3163: delete result is invalid when there is no predicate

2020-03-20 Thread GitBox
kangpinghuang opened a new issue #3163: delete result is invalid when there is no predicate URL: https://github.com/apache/incubator-doris/issues/3163 **Describe the bug** the result is invalid when there is no predicate for count(*) agaist a table with delete. **To Reproduce**

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
imay commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395524007 ## File path: be/src/exec/tablet_sink.h ## @@ -47,18 +48,101 @@ class ExprContext; class TExpr; namespace stream_l

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3150: Support non-correlated subquery in having clause

2020-03-20 Thread GitBox
yangzhg commented on a change in pull request #3150: Support non-correlated subquery in having clause URL: https://github.com/apache/incubator-doris/pull/3150#discussion_r395505446 ## File path: fe/src/main/java/org/apache/doris/analysis/StmtRewriter.java ## @@ -97,8 +103,

[GitHub] [incubator-doris] morningman commented on issue #3161: Support to create a slave table of Mysql through real-time update

2020-03-20 Thread GitBox
morningman commented on issue #3161: Support to create a slave table of Mysql through real-time update URL: https://github.com/apache/incubator-doris/issues/3161#issuecomment-601593768 Doris doesn't support update and delete, so its not easy to be a slave. But we may think to provide so

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395492007 ## File path: be/src/exec/tablet_sink.h ## @@ -47,18 +48,101 @@ class ExprContext; class TExpr; names

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395492007 ## File path: be/src/exec/tablet_sink.h ## @@ -47,18 +48,101 @@ class ExprContext; class TExpr; names

[GitHub] [incubator-doris] chaoyli merged pull request #3162: [CodeStyle] Delete obsolete code of partition_aggregation_node and pa…

2020-03-20 Thread GitBox
chaoyli merged pull request #3162: [CodeStyle] Delete obsolete code of partition_aggregation_node and pa… URL: https://github.com/apache/incubator-doris/pull/3162 This is an automated message from the Apache Git Service. To

[incubator-doris] branch master updated (c08d6e4 -> 5a8fcd2)

2020-03-20 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from c08d6e4 [tablet meta] Do some refactor on TabletMeta (#3136) add 5a8fcd2 [CodeStyle] Delete obsol

[GitHub] [incubator-doris] HappenLee opened a new pull request #3162: [CodeStyle] Delete obsolete code of partition_aggregation_node and pa…

2020-03-20 Thread GitBox
HappenLee opened a new pull request #3162: [CodeStyle] Delete obsolete code of partition_aggregation_node and pa… URL: https://github.com/apache/incubator-doris/pull/3162 …rtitioned_hash_table delete be/src/exec/partitioned_aggregation_node.cc delete be/src/exec/partitioned_aggreg

[GitHub] [incubator-doris] shipengAlan opened a new issue #3161: Support to create a slave table of Mysql through real-time update

2020-03-20 Thread GitBox
shipengAlan opened a new issue #3161: Support to create a slave table of Mysql through real-time update URL: https://github.com/apache/incubator-doris/issues/3161 In data warehouse, data transfers from multiple sources is always required. And, DB, e.g. MySQL is one of the most important.

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

2020-03-20 Thread GitBox
imay commented on a change in pull request #3143: Non blocking OlapTableSink URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395464396 ## File path: be/src/exec/tablet_sink.cpp ## @@ -128,55 +127,127 @@ Status NodeChannel::open_wait() { _open_closu

[incubator-doris] branch master updated (2d3dbc2 -> c08d6e4)

2020-03-20 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 2d3dbc2 Revert "[CodeStyle] Del obsolete code of partition_aggregation_node (#3154)" (#3160) add c08d6

[GitHub] [incubator-doris] imay merged pull request #3136: [tablet meta] Do some refactor on TabletMeta

2020-03-20 Thread GitBox
imay merged pull request #3136: [tablet meta] Do some refactor on TabletMeta URL: https://github.com/apache/incubator-doris/pull/3136 This is an automated message from the Apache Git Service. To respond to the message, please