[GitHub] [incubator-doris] imay commented on a change in pull request #2952: Fix some function DATE type priority

2020-02-19 Thread GitBox
imay commented on a change in pull request #2952: Fix some function DATE type priority URL: https://github.com/apache/incubator-doris/pull/2952#discussion_r381830172 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java ## @@ -802,7 +802,6 @@ priva

[GitHub] [incubator-doris] imay commented on a change in pull request #2952: Fix some function DATE type priority

2020-02-19 Thread GitBox
imay commented on a change in pull request #2952: Fix some function DATE type priority URL: https://github.com/apache/incubator-doris/pull/2952#discussion_r381828431 ## File path: fe/src/test/java/org/apache/doris/utframe/ConstantExpressTest.java ## @@ -0,0 +1,130 @@ +pack

[GitHub] [incubator-doris] kangkaisen opened a new pull request #2952: Fix some function DATE type priority

2020-02-19 Thread GitBox
kangkaisen opened a new pull request #2952: Fix some function DATE type priority URL: https://github.com/apache/incubator-doris/pull/2952 1. Fix the bug introduced by https://github.com/apache/incubator-doris/pull/2947. The following sql result is , which is wrong. The result shoul

[GitHub] [incubator-doris] wangbo commented on a change in pull request #2940: spark etl build global dict doc

2020-02-19 Thread GitBox
wangbo commented on a change in pull request #2940: spark etl build global dict doc URL: https://github.com/apache/incubator-doris/pull/2940#discussion_r381780855 ## File path: docs/documentation/cn/internal/spark_etl_global_dict.md ## @@ -0,0 +1,125 @@ +# 目标 +支持Spark ETL导

[GitHub] [incubator-doris] wangbo edited a comment on issue #2940: spark etl build global dict doc

2020-02-19 Thread GitBox
wangbo edited a comment on issue #2940: spark etl build global dict doc URL: https://github.com/apache/incubator-doris/pull/2940#issuecomment-588605086 @morningman > spark 构建全局索引的工作,我理解是 spark导入功能中的一部分是吧? 是的,如果本次导入是有精确去重字段的话,是需要在流程中加一步构建全局字典。 > 目前一个spark导入作业所需要的信息,使用sql表述感

[GitHub] [incubator-doris] wangbo commented on issue #2940: spark etl build global dict doc

2020-02-19 Thread GitBox
wangbo commented on issue #2940: spark etl build global dict doc URL: https://github.com/apache/incubator-doris/pull/2940#issuecomment-588605086 @morningman > spark 构建全局索引的工作,我理解是 spark导入功能中的一部分是吧? 是的,如果本次导入是有精确去重字段的话,是需要在流程中加一步构建全局字典。 > 目前一个spark导入作业所需要的信息,使用sql表述感觉非常复杂了,

[GitHub] [incubator-doris] wangbo commented on a change in pull request #2940: spark etl build global dict doc

2020-02-19 Thread GitBox
wangbo commented on a change in pull request #2940: spark etl build global dict doc URL: https://github.com/apache/incubator-doris/pull/2940#discussion_r381733448 ## File path: docs/documentation/cn/internal/spark_etl_global_dict.md ## @@ -0,0 +1,125 @@ +# 目标 +支持Spark ETL导

[GitHub] [incubator-doris] lingbin opened a new pull request #2951: [ut] Add log to track problem in small_file_mgr_test

2020-02-19 Thread GitBox
lingbin opened a new pull request #2951: [ut] Add log to track problem in small_file_mgr_test URL: https://github.com/apache/incubator-doris/pull/2951 This case will occasionally fail in regression testing, so we add some logs to help to solve it. ---

[GitHub] [incubator-doris] morningman merged pull request #2950: [Bug] Missing `in memory` property for restore meta info

2020-02-19 Thread GitBox
morningman merged pull request #2950: [Bug] Missing `in memory` property for restore meta info URL: https://github.com/apache/incubator-doris/pull/2950 This is an automated message from the Apache Git Service. To respond to

[incubator-doris] branch master updated (ed299d5 -> 180bf02)

2020-02-19 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from ed299d5 Create pprof_profile_dir before heap profiling (#2944) add 180bf02 [Bug] Missing `in memo

[GitHub] [incubator-doris] EmmyMiao87 closed pull request #2821: The new materialized view selector

2020-02-19 Thread GitBox
EmmyMiao87 closed pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] imay merged pull request #2944: create pprof_profile_dir before heap profiling

2020-02-19 Thread GitBox
imay merged pull request #2944: create pprof_profile_dir before heap profiling URL: https://github.com/apache/incubator-doris/pull/2944 This is an automated message from the Apache Git Service. To respond to the message, plea

[incubator-doris] branch master updated: Create pprof_profile_dir before heap profiling (#2944)

2020-02-19 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ed299d5 Create pprof_profile_dir before

[GitHub] [incubator-doris] WingsGo commented on issue #2751: Fix bug for SIGFPE produced in AlphaRowset::split_range

2020-02-19 Thread GitBox
WingsGo commented on issue #2751: Fix bug for SIGFPE produced in AlphaRowset::split_range URL: https://github.com/apache/incubator-doris/pull/2751#issuecomment-588563520 > The current_num_rows_per_row_block is loaded in olap_index.cpp. > If you can reproduce the bug, you can print the va

[GitHub] [incubator-doris] chaoyli commented on issue #2949: add rle v2 encoding for segment v2

2020-02-19 Thread GitBox
chaoyli commented on issue #2949: add rle v2 encoding for segment v2 URL: https://github.com/apache/incubator-doris/pull/2949#issuecomment-588286553 If you just move the old code from the AlphaRowset, the question of AlphaRowset still exists. Like - I/O exemplification of read St

[GitHub] [incubator-doris] chaoyli merged pull request #2777: [Alter] Add more schema change to varchar type

2020-02-19 Thread GitBox
chaoyli merged pull request #2777: [Alter] Add more schema change to varchar type URL: https://github.com/apache/incubator-doris/pull/2777 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-doris] branch master updated: [Alter] Add more schema change to varchar type (#2777)

2020-02-19 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new cc0d412 [Alter] Add more schema ch

[GitHub] [incubator-doris] morningman commented on a change in pull request #2940: spark etl build global dict doc

2020-02-19 Thread GitBox
morningman commented on a change in pull request #2940: spark etl build global dict doc URL: https://github.com/apache/incubator-doris/pull/2940#discussion_r381342174 ## File path: docs/documentation/cn/internal/spark_etl_global_dict.md ## @@ -0,0 +1,125 @@ +# 目标 +支持Spark

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2940: spark etl build global dict doc

2020-02-19 Thread GitBox
kangpinghuang commented on a change in pull request #2940: spark etl build global dict doc URL: https://github.com/apache/incubator-doris/pull/2940#discussion_r381307037 ## File path: docs/documentation/cn/internal/spark_etl_global_dict.md ## @@ -0,0 +1,125 @@ +# 目标 +支持Spa

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2940: spark etl build global dict doc

2020-02-19 Thread GitBox
kangpinghuang commented on a change in pull request #2940: spark etl build global dict doc URL: https://github.com/apache/incubator-doris/pull/2940#discussion_r381306214 ## File path: docs/documentation/cn/internal/spark_etl_global_dict.md ## @@ -0,0 +1,125 @@ +# 目标 +支持Spa

[GitHub] [incubator-doris] imay commented on a change in pull request #2804: [JDK] Support OpenJDK

2020-02-19 Thread GitBox
imay commented on a change in pull request #2804: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/pull/2804#discussion_r381300010 ## File path: fe/src/main/java/org/apache/doris/rpc/BackendServiceProxy.java ## @@ -53,6 +56,11 @@ private static Ba

[GitHub] [incubator-doris] morningman opened a new pull request #2950: [Bug] Missing `in memory` property for restore meta info

2020-02-19 Thread GitBox
morningman opened a new pull request #2950: [Bug] Missing `in memory` property for restore meta info URL: https://github.com/apache/incubator-doris/pull/2950 This bug is introduced by PR #2846 This is an automated message fro

[GitHub] [incubator-doris] vagetablechicken commented on issue #2780: OlapTableSink::send is low efficient?

2020-02-19 Thread GitBox
vagetablechicken commented on issue #2780: OlapTableSink::send is low efficient? URL: https://github.com/apache/incubator-doris/issues/2780#issuecomment-588210735 > The enhancement of this test case seems not obvious? the origin ver is being tested. It typically takes 5h. I haven't t

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #2949: add rle v2 encoding for segment v2

2020-02-19 Thread GitBox
kangpinghuang opened a new pull request #2949: add rle v2 encoding for segment v2 URL: https://github.com/apache/incubator-doris/pull/2949 1. reuse the rle encoding in alpha rowset 2. modify segment_test because of change of encoding issue: #2886 -

[GitHub] [incubator-doris] imay merged pull request #2933: Fix the flush_status bug in flush-executor

2020-02-19 Thread GitBox
imay merged pull request #2933: Fix the flush_status bug in flush-executor URL: https://github.com/apache/incubator-doris/pull/2933 This is an automated message from the Apache Git Service. To respond to the message, please l

[incubator-doris] branch master updated: Fix the flush_status bug in flush-executor (#2933)

2020-02-19 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new c617fc9 Fix the flush_status bug in flu

[incubator-doris] branch master updated: [Bug] Missing `in memory` property for old version of partition info (#2948)

2020-02-19 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new cfcc29f [Bug] Missing `in memory` prope

[GitHub] [incubator-doris] imay merged pull request #2948: [Bug] Missing `in memory` property for old version of partition info

2020-02-19 Thread GitBox
imay merged pull request #2948: [Bug] Missing `in memory` property for old version of partition info URL: https://github.com/apache/incubator-doris/pull/2948 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] imay merged pull request #2947: Fix some function with date type bug

2020-02-19 Thread GitBox
imay merged pull request #2947: Fix some function with date type bug URL: https://github.com/apache/incubator-doris/pull/2947 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-doris] branch master updated: Fix some function with date type bug (#2947)

2020-02-19 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 147953f Fix some function with date typ

[GitHub] [incubator-doris] morningman merged pull request #2926: [Alter] Change table's state right after all rollup jobs being cancelled

2020-02-19 Thread GitBox
morningman merged pull request #2926: [Alter] Change table's state right after all rollup jobs being cancelled URL: https://github.com/apache/incubator-doris/pull/2926 This is an automated message from the Apache Git Service

[incubator-doris] branch master updated: [Alter] Change table's state right after all rollup jobs being cancelled

2020-02-19 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new a015cd0 [Alter] Change table's sta

[GitHub] [incubator-doris] chaoyli commented on issue #2780: OlapTableSink::send is low efficient?

2020-02-19 Thread GitBox
chaoyli commented on issue #2780: OlapTableSink::send is low efficient? URL: https://github.com/apache/incubator-doris/issues/2780#issuecomment-588163478 The enhancement of this test case seems not obvious? This is an automat

[GitHub] [incubator-doris] vagetablechicken edited a comment on issue #2944: create pprof_profile_dir before heap profiling

2020-02-19 Thread GitBox
vagetablechicken edited a comment on issue #2944: create pprof_profile_dir before heap profiling URL: https://github.com/apache/incubator-doris/pull/2944#issuecomment-588157911 > If `heap_profile_dir` is not empty, then the profile will be opened and the performance of the process will be

[GitHub] [incubator-doris] vagetablechicken commented on issue #2944: create pprof_profile_dir before heap profiling

2020-02-19 Thread GitBox
vagetablechicken commented on issue #2944: create pprof_profile_dir before heap profiling URL: https://github.com/apache/incubator-doris/pull/2944#issuecomment-588157911 > If `heap_profile_dir` is not empty, then the profile will be opened and the performance of the process will be reduced

[GitHub] [incubator-doris] vagetablechicken commented on issue #2780: OlapTableSink::send is low efficient?

2020-02-19 Thread GitBox
vagetablechicken commented on issue #2780: OlapTableSink::send is low efficient? URL: https://github.com/apache/incubator-doris/issues/2780#issuecomment-588156273 # OlapTableSink Multithreading Solution Design ## single-thread model (original model) ![image](https://user-images.g

[GitHub] [incubator-doris] morningman merged pull request #2941: drop index when index column is dropped

2020-02-19 Thread GitBox
morningman merged pull request #2941: drop index when index column is dropped URL: https://github.com/apache/incubator-doris/pull/2941 This is an automated message from the Apache Git Service. To respond to the message, pleas

[incubator-doris] branch master updated (3994b52 -> ceaa790)

2020-02-19 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 3994b52 [Alter] Change max create replicas timeout configurable (#2945) add ceaa790 [Alter] Drop

[incubator-doris] branch master updated (a76f2b8 -> 3994b52)

2020-02-19 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from a76f2b8 bitmap_union_count support window function (#2902) add 3994b52 [Alter] Change max create

[GitHub] [incubator-doris] morningman merged pull request #2945: [Alter]Make max create replicas timeout configurable

2020-02-19 Thread GitBox
morningman merged pull request #2945: [Alter]Make max create replicas timeout configurable URL: https://github.com/apache/incubator-doris/pull/2945 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2933: Fix the flush_status bug in flush-executor

2020-02-19 Thread GitBox
lingbin commented on a change in pull request #2933: Fix the flush_status bug in flush-executor URL: https://github.com/apache/incubator-doris/pull/2933#discussion_r381164233 ## File path: be/src/olap/memtable_flush_executor.cpp ## @@ -35,15 +31,15 @@ std::ostream& operato

[GitHub] [incubator-doris] morningman opened a new pull request #2948: [Bug] Missing `in memory` property for old version of partition info

2020-02-19 Thread GitBox
morningman opened a new pull request #2948: [Bug] Missing `in memory` property for old version of partition info URL: https://github.com/apache/incubator-doris/pull/2948 This bug is introduced by PR #2846 This is an automate