[GitHub] [incubator-doris] morningman opened a new pull request #2904: [Rollup] Change table's state right after all rollup jobs are done

2020-02-13 Thread GitBox
morningman opened a new pull request #2904: [Rollup] Change table's state right after all rollup jobs are done URL: https://github.com/apache/incubator-doris/pull/2904 In the current implementation, the state of the table will be set until the next round of job scheduling. So there may be

[GitHub] [incubator-doris] morningman opened a new issue #2903: [Rollup] Some problems about batch adding rollups

2020-02-13 Thread GitBox
morningman opened a new issue #2903: [Rollup] Some problems about batch adding rollups URL: https://github.com/apache/incubator-doris/issues/2903 1. Table's state is not NORMAL after all rollup jobs are done. This is because in the current implementation, the state of the table

[GitHub] [incubator-doris] kangkaisen opened a new pull request #2902: bitmap_union_count support window function

2020-02-13 Thread GitBox
kangkaisen opened a new pull request #2902: bitmap_union_count support window function URL: https://github.com/apache/incubator-doris/pull/2902 For https://github.com/apache/incubator-doris/issues/2901 1. Make bitmap_union_count support window function 2. Fix bitmap insert into bu

[GitHub] [incubator-doris] kangkaisen opened a new issue #2901: Bitmap_union_count doesn't support window functions

2020-02-13 Thread GitBox
kangkaisen opened a new issue #2901: Bitmap_union_count doesn't support window functions URL: https://github.com/apache/incubator-doris/issues/2901 Currently, The following code couldn't run: ``` select id, bitmap_union_count(uv) over(order by id) intent_uv from ( select id, bitm

[GitHub] [incubator-doris] chaoyli merged pull request #2899: [gutil] import scoped_refptr smart pointer from KUDU

2020-02-13 Thread GitBox
chaoyli merged pull request #2899: [gutil] import scoped_refptr smart pointer from KUDU URL: https://github.com/apache/incubator-doris/pull/2899 This is an automated message from the Apache Git Service. To respond to the mes

[incubator-doris] branch master updated (0e997a8 -> 09a4d3e)

2020-02-13 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 0e997a8 Fix a sql_parser.cup conflict by a duplicated show index stmt (#2894) add 09a4d3e [gutil

[GitHub] [incubator-doris] lingbin commented on issue #2899: [gutil] import scoped_refptr smart pointer from KUDU

2020-02-13 Thread GitBox
lingbin commented on issue #2899: [gutil] import scoped_refptr smart pointer from KUDU URL: https://github.com/apache/incubator-doris/pull/2899#issuecomment-586094212 I checked the code of kudu. Almost all tools in `gutil` do not have UT. It may be because these utils have been thoroughly

[GitHub] [incubator-doris] wangbo closed issue #2900: Fix AddRollupStmt Sql Syntax Tree Compile Warning

2020-02-13 Thread GitBox
wangbo closed issue #2900: Fix AddRollupStmt Sql Syntax Tree Compile Warning URL: https://github.com/apache/incubator-doris/issues/2900 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] wangbo opened a new issue #2900: Fix AddRollupStmt Sql Syntax Tree Compile Warning

2020-02-13 Thread GitBox
wangbo opened a new issue #2900: Fix AddRollupStmt Sql Syntax Tree Compile Warning URL: https://github.com/apache/incubator-doris/issues/2900 **java_cup sql parser compile warning** ``` [WARNING] /incubator-doris/fe/src/main/cup/sql_parser.cup [0:0]: *** Shift/Reduce conflict found i

[GitHub] [incubator-doris] chaoyli commented on issue #2896: Import a new ThreadPool Framework

2020-02-13 Thread GitBox
chaoyli commented on issue #2896: Import a new ThreadPool Framework URL: https://github.com/apache/incubator-doris/issues/2896#issuecomment-586089869 1. import scoped_refptr from gutil #2899 2. import ConditionVariable from Kudu 3. import ThreadPool --

[incubator-doris] branch master updated: Fix a sql_parser.cup conflict by a duplicated show index stmt (#2894)

2020-02-13 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 0e997a8 Fix a sql_parser.cup confl

[GitHub] [incubator-doris] kangkaisen merged pull request #2894: fix a sql_parser.cup conflict by a duplicted show index stmt

2020-02-13 Thread GitBox
kangkaisen merged pull request #2894: fix a sql_parser.cup conflict by a duplicted show index stmt URL: https://github.com/apache/incubator-doris/pull/2894 This is an automated message from the Apache Git Service. To respond

[incubator-doris] branch master updated: [Syntax] Fix alter rollup stmt Shift/Reduce conflict (#2897)

2020-02-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 83d33ce [Syntax] Fix alter rollup

[GitHub] [incubator-doris] morningman merged pull request #2897: fix alter rollup Shift/Reduce conflict warning

2020-02-13 Thread GitBox
morningman merged pull request #2897: fix alter rollup Shift/Reduce conflict warning URL: https://github.com/apache/incubator-doris/pull/2897 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] chaoyli opened a new pull request #2899: [gutil] import scoped_refptr smart pointer from KUDU

2020-02-13 Thread GitBox
chaoyli opened a new pull request #2899: [gutil] import scoped_refptr smart pointer from KUDU URL: https://github.com/apache/incubator-doris/pull/2899 scoped_refptr is used to replace std::shared_ptr, is generally faster and smaller. advantage (1) only requires a single allocation,

[GitHub] [incubator-doris] chaoyli closed pull request #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli closed pull request #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] lingbin merged pull request #2898: Add env-util class

2020-02-13 Thread GitBox
lingbin merged pull request #2898: Add env-util class URL: https://github.com/apache/incubator-doris/pull/2898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[incubator-doris] branch master updated (ed95352 -> d2625a2)

2020-02-13 Thread lingbin
This is an automated email from the ASF dual-hosted git repository. lingbin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from ed95352 support intersect and except syntax (#2882) add d2625a2 [env] Add env-util class (#2898) No

[GitHub] [incubator-doris] lingbin opened a new pull request #2898: Add env-util class

2020-02-13 Thread GitBox
lingbin opened a new pull request #2898: Add env-util class URL: https://github.com/apache/incubator-doris/pull/2898 The code submitted later will use this utility class. Currently only factory methods for various file types are provided. In the future, tool methods that are common

[GitHub] [incubator-doris] lingbin commented on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
lingbin commented on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585807638 Could you please split this PR into multiple commits? For example: 1. import some gutil 2. import some util 3. import new thread-pool

[GitHub] [incubator-doris] wangbo opened a new pull request #2897: fix alter rollup Shift/Reduce conflict warning

2020-02-13 Thread GitBox
wangbo opened a new pull request #2897: fix alter rollup Shift/Reduce conflict warning URL: https://github.com/apache/incubator-doris/pull/2897 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster and

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster and

[GitHub] [incubator-doris] chaoyli commented on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli commented on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585767725 Thread design point: 1. It is a thin wrapper around pthread that can register itself with the singleton ThreadMgr (a private class implemen

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585766207 Thread pool design point: All tasks submitted directly to the thread pool enter a FIFO queue and are dispatched to a worker thread wh

[GitHub] [incubator-doris] chaoyli commented on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli commented on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585766207 Thread pool with a variable number of threads. All tasks submitted directly to the thread pool enter a FIFO queue and are dispatched to a wo

[GitHub] [incubator-doris] chaoyli commented on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli commented on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585763911 This patch imports many basis class. 1. scoped_refptr scoped_refptr is used to replace std::shared_ptr, is generally faster and smalle

[GitHub] [incubator-doris] chaoyli removed a comment on issue #2896: Import a new ThreadPool Framework

2020-02-13 Thread GitBox
chaoyli removed a comment on issue #2896: Import a new ThreadPool Framework URL: https://github.com/apache/incubator-doris/issues/2896#issuecomment-585757484 Now, Doris have multiple ThreadPool in different code path. And all of them have a little difference. So I import a new ThreadP

[GitHub] [incubator-doris] chaoyli commented on issue #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli commented on issue #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895#issuecomment-585760983 #2896 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2896: Import a new ThreadPool Framework

2020-02-13 Thread GitBox
chaoyli edited a comment on issue #2896: Import a new ThreadPool Framework URL: https://github.com/apache/incubator-doris/issues/2896#issuecomment-585758880 This ThreadPool have three features. 1. Using a token mechanism to receive tasks. In Doris, tasks are submitted into ThreadP

[GitHub] [incubator-doris] chaoyli commented on issue #2896: Import a new ThreadPool Framework

2020-02-13 Thread GitBox
chaoyli commented on issue #2896: Import a new ThreadPool Framework URL: https://github.com/apache/incubator-doris/issues/2896#issuecomment-585758880 This ThreadPool have three features. **Using a token mechanism to receive tasks.** In Doris, tasks are submitted into ThreadPool wi

[GitHub] [incubator-doris] chaoyli commented on issue #2896: Import a new ThreadPool Framework

2020-02-13 Thread GitBox
chaoyli commented on issue #2896: Import a new ThreadPool Framework URL: https://github.com/apache/incubator-doris/issues/2896#issuecomment-585757484 Now, Doris have multiple ThreadPool in different code path. And all of them have a little difference. So I import a new ThreadPool to u

[GitHub] [incubator-doris] chaoyli opened a new issue #2896: Import a new ThreadPool Framework

2020-02-13 Thread GitBox
chaoyli opened a new issue #2896: Import a new ThreadPool Framework URL: https://github.com/apache/incubator-doris/issues/2896 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] WingsGo commented on issue #2777: [Alter] Add more schema change to varchar type

2020-02-13 Thread GitBox
WingsGo commented on issue #2777: [Alter] Add more schema change to varchar type URL: https://github.com/apache/incubator-doris/pull/2777#issuecomment-585751181 @imay @morningman @chaoyli Plz review this PR~ This is an auto

[GitHub] [incubator-doris] chaoyli opened a new pull request #2895: Import new ThreadPool framework

2020-02-13 Thread GitBox
chaoyli opened a new pull request #2895: Import new ThreadPool framework URL: https://github.com/apache/incubator-doris/pull/2895 1. Using a token machanism to receive tasks. Task in token can be handled serially or concurrently. MemTableFlush in Doirs can use this feature,

[GitHub] [incubator-doris] yangzhg opened a new pull request #2894: fix a sql_parser.cup conflict by a duplicted show index stmt

2020-02-13 Thread GitBox
yangzhg opened a new pull request #2894: fix a sql_parser.cup conflict by a duplicted show index stmt URL: https://github.com/apache/incubator-doris/pull/2894 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] EmmyMiao87 merged pull request #2882: Convert UnionStmt class into to SetOperationStmt, add Syntax support to sql_parser

2020-02-13 Thread GitBox
EmmyMiao87 merged pull request #2882: Convert UnionStmt class into to SetOperationStmt, add Syntax support to sql_parser URL: https://github.com/apache/incubator-doris/pull/2882 This is an automated message from the Apache G

[incubator-doris] branch master updated: support intersect and except syntax (#2882)

2020-02-13 Thread lingmiao
This is an automated email from the ASF dual-hosted git repository. lingmiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ed95352 support intersect and except

[GitHub] [incubator-doris] EmmyMiao87 closed issue #2834: [Proposal] Full support of set operations: add INTERSECT and EXCEPT set operators

2020-02-13 Thread GitBox
EmmyMiao87 closed issue #2834: [Proposal] Full support of set operations: add INTERSECT and EXCEPT set operators URL: https://github.com/apache/incubator-doris/issues/2834 This is an automated message from the Apache Git Ser

[GitHub] [incubator-doris] vagetablechicken opened a new issue #2893: Condition destroy error shouldn't be a fatal error

2020-02-13 Thread GitBox
vagetablechicken opened a new issue #2893: Condition destroy error shouldn't be a fatal error URL: https://github.com/apache/incubator-doris/issues/2893 When we stop one be, it always makes a fatal error: `F0213 12:33:53.604131 117681 utils.cpp:1124] fail to destroy cond. err=Devic