Re: [2/2] [lang] remove unused bcel test dependency

Nice one! schrieb am Sa. 14. Okt. 2017 um 15:27: > remove unused bcel test dependency > > > Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo > Commit: > http://git-wip-us.apache.org/repos/asf/commons-lang/commit/66226ec1 > Tree: http://git-wip-us.apache.org/repos/asf/commons-lan

Re: commons-csv git commit: Better ivar name.

Hello, I don't think this is a better name. In my opinion it's bad style to add types to variable names. How about recordContents or simply content/s ? Regards, Benedikt schrieb am Fr. 18. Aug. 2017 um 17:02: > Repository: commons-csv > Updated Branches: > refs/heads/master 431f8236e -> 25981

Re: [5/7] [text] salutations: Name constructor is now public for testing.

Hello Bruno, it just came to my mind, that it would probably be good to use java.util.ResourceBundle for defining the salutations et al. This way translations can easily be added by users. WDYT? Benedikt schrieb am So. 20. Nov. 2016 um 07:57: > salutations: Name constructor is now public for

Re: [lang] LANG-1289" type="fix" dev="ggregory">JavaVersion class depends on Apache Commons Math class NumberUtils.

Hello Gary, I don't understand this change. The NumberUtils import you removed was from lang itself. Doesn't this change introduce code duplication within Lang? Benedikt schrieb am Fr. 18. Nov. 2016 um 21:30: > Repository: commons-lang > Updated Branches: > refs/heads/master 429c847b2 -> 9dc

Re: svn commit: r1765341 - in /commons/proper/logging/trunk/src: changes/changes.xml main/java/org/apache/commons/logging/LogFactory.java main/java/org/apache/commons/logging/impl/SimpleLog.java

Hello Gary, do you see a way to back this change with tests? Regards, Benedikt

Re: svn commit: r1750760 - in /commons/proper/io/trunk/src: changes/ main/java/org/apache/commons/io/input/ test/java/org/apache/commons/io/input/

Hi Jochen, wouldn't it be good to have a Jira issue for this change? Regards, Benedikt schrieb am Do., 30. Juni 2016 um 11:04: > Author: jochen > Date: Thu Jun 30 09:04:21 2016 > New Revision: 1750760 > > URL: http://svn.apache.org/viewvc?rev=1750760&view=rev > Log: > Added the ObservableInput

Re: svn commit: r1749789 - /commons/proper/configuration/trunk/src/changes/changes.xml

Should be Commons Code*c* schrieb am Do., 23. Juni 2016 um 00:05: > Author: ggregory > Date: Wed Jun 22 22:05:46 2016 > New Revision: 1749789 > > URL: http://svn.apache.org/viewvc?rev=1749789&view=rev > Log: > [CONFIGURATION-635] Update optional dependency Apache Commons Code from > 1.9 to 1.10.