svn commit: r1697296 - /commons/proper/net/trunk/checkstyle.xml

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 01:31:10 2015 New Revision: 1697296 URL: http://svn.apache.org/r1697296 Log: RedundantThrows no longer supported Modified: commons/proper/net/trunk/checkstyle.xml Modified: commons/proper/net/trunk/checkstyle.xml URL: http://svn.apache.org/viewvc/commons/proper

svn commit: r1697294 - in /commons/proper/net/trunk: checkstyle.xml pom.xml

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 01:27:29 2015 New Revision: 1697294 URL: http://svn.apache.org/r1697294 Log: Latest checkstyle tool Modified: commons/proper/net/trunk/checkstyle.xml commons/proper/net/trunk/pom.xml Modified: commons/proper/net/trunk/checkstyle.xml URL: http://svn.apache.o

svn commit: r1697295 - in /commons/proper/net/trunk/src: main/java/examples/unix/ main/java/examples/util/ main/java/org/apache/commons/net/ main/java/org/apache/commons/net/ftp/ main/java/org/apache/

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 01:27:54 2015 New Revision: 1697295 URL: http://svn.apache.org/r1697295 Log: Empty Catch Blocks Modified: commons/proper/net/trunk/src/main/java/examples/unix/rexec.java commons/proper/net/trunk/src/main/java/examples/unix/rlogin.java commons/proper/net/t

svn commit: r1697293 - in /commons/proper/net/trunk: ./ src/main/java/examples/cidr/ src/main/java/examples/nntp/ src/main/java/examples/telnet/ src/main/java/org/apache/commons/net/ftp/ src/main/java

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 01:01:00 2015 New Revision: 1697293 URL: http://svn.apache.org/r1697293 Log: Moved @author entries to pom Modified: commons/proper/net/trunk/checkstyle.xml commons/proper/net/trunk/pom.xml commons/proper/net/trunk/src/main/java/examples/cidr/SubnetUtilsEx

svn commit: r1697292 - in /commons/proper/net/trunk/src/main/java/org/apache/commons/net: DefaultDatagramSocketFactory.java ftp/parser/FTPTimestampParserImpl.java

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 00:37:35 2015 New Revision: 1697292 URL: http://svn.apache.org/r1697292 Log: Missing @return Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/DefaultDatagramSocketFactory.java commons/proper/net/trunk/src/main/java/org/apache/commons/

svn commit: r1697291 - /commons/proper/net/trunk/checkstyle.xml

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 00:37:13 2015 New Revision: 1697291 URL: http://svn.apache.org/r1697291 Log: These are now fixed, so make them errors Modified: commons/proper/net/trunk/checkstyle.xml Modified: commons/proper/net/trunk/checkstyle.xml URL: http://svn.apache.org/viewvc/commons/p

svn commit: r1697290 - in /commons/proper/net/trunk/src: main/java/examples/ main/java/examples/ftp/ main/java/examples/mail/ main/java/org/apache/commons/net/chargen/ main/java/org/apache/commons/net

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 00:33:56 2015 New Revision: 1697290 URL: http://svn.apache.org/r1697290 Log: Redundant spaces Modified: commons/proper/net/trunk/src/main/java/examples/Main.java commons/proper/net/trunk/src/main/java/examples/ftp/FTPClientExample.java commons/proper/net/

svn commit: r1697289 - in /commons/proper/net/trunk/src: main/java/org/apache/commons/net/ftp/ main/java/org/apache/commons/net/ftp/parser/ test/java/org/apache/commons/net/ftp/parser/

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 00:32:19 2015 New Revision: 1697289 URL: http://svn.apache.org/r1697289 Log: Redundant spaces Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPFile.java commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/F

svn commit: r1697287 - in /commons/proper/net/trunk/src: changes/ main/java/org/apache/commons/net/ main/java/org/apache/commons/net/ftp/ main/java/org/apache/commons/net/imap/ main/java/org/apache/co

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 00:24:36 2015 New Revision: 1697287 URL: http://svn.apache.org/r1697287 Log: NET-579 SSL/TLS SocketClients do not verify the hostname against the certificate Added: commons/proper/net/trunk/src/main/java/org/apache/commons/net/util/SSLSocketUtils.java (with p

svn commit: r1697285 - in /commons/proper/bcel/trunk: checkstyle-suppressions.xml checkstyle.xml checkstyle_suppressions.xml

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 00:19:29 2015 New Revision: 1697285 URL: http://svn.apache.org/r1697285 Log: Use the same naming convention as NET and VFS Added: commons/proper/bcel/trunk/checkstyle-suppressions.xml - copied unchanged from r1697284, commons/proper/bcel/trunk/checkstyle_s

svn commit: r1697284 - in /commons/proper/net/trunk: checkstyle.xml pom.xml

2015-08-23 Thread sebb
Author: sebb Date: Mon Aug 24 00:14:58 2015 New Revision: 1697284 URL: http://svn.apache.org/r1697284 Log: Checkstyle fixes Modified: commons/proper/net/trunk/checkstyle.xml commons/proper/net/trunk/pom.xml Modified: commons/proper/net/trunk/checkstyle.xml URL: http://svn.apache.org/vie

svn commit: r1697283 - in /commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp: TestNtpClient.java TimeStampTest.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 23:49:13 2015 New Revision: 1697283 URL: http://svn.apache.org/r1697283 Log: Always use blocks Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpClient.java commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/T

svn commit: r1697282 - /commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 23:35:01 2015 New Revision: 1697282 URL: http://svn.apache.org/r1697282 Log: Qualifier order Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java Modified: commons/proper/net/trunk/src/test/java/org/apac

svn commit: r1697281 - /commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPPacket.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 23:34:39 2015 New Revision: 1697281 URL: http://svn.apache.org/r1697281 Log: Qualifier order Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPPacket.java Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/tf

svn commit: r1697280 - in /commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp: NtpV3Impl.java TimeStamp.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 23:33:58 2015 New Revision: 1697280 URL: http://svn.apache.org/r1697280 Log: Qualifier order Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/TimeSta

svn commit: r1697279 - /commons/proper/net/trunk/src/main/java/examples/telnet/WeatherTelnet.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 23:31:48 2015 New Revision: 1697279 URL: http://svn.apache.org/r1697279 Log: Qualifier order Modified: commons/proper/net/trunk/src/main/java/examples/telnet/WeatherTelnet.java Modified: commons/proper/net/trunk/src/main/java/examples/telnet/WeatherTelnet.java

svn commit: r1697278 - /commons/proper/bcel/trunk/checkstyle_suppressions.xml

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 23:08:47 2015 New Revision: 1697278 URL: http://svn.apache.org/r1697278 Log: Comments Modified: commons/proper/bcel/trunk/checkstyle_suppressions.xml Modified: commons/proper/bcel/trunk/checkstyle_suppressions.xml URL: http://svn.apache.org/viewvc/commons/prope

svn commit: r1697276 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/Verifier.java

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:52:57 2015 New Revision: 1697276 URL: http://svn.apache.org/r1697276 Log: simplify array building Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/Verifier.java Modified: commons/proper/bcel/trunk/src/main/java/org/apa

svn commit: r1697275 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:50:52 2015 New Revision: 1697275 URL: http://svn.apache.org/r1697275 Log: switch to more typical (idiomatic) java Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java Modified: commons/proper/bcel/tr

svn commit: r1697274 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/ClassSet.java

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:46:36 2015 New Revision: 1697274 URL: http://svn.apache.org/r1697274 Log: reduce allocations Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/ClassSet.java Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commo

svn commit: r1697273 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:45:15 2015 New Revision: 1697273 URL: http://svn.apache.org/r1697273 Log: reduce allocations Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java Modified: commons/proper/bcel/trunk/src/main/java/org/apache/c

svn commit: r1697272 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationEntry.java

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:38:49 2015 New Revision: 1697272 URL: http://svn.apache.org/r1697272 Log: reduce allocations Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationEntry.java Modified: commons/proper/bcel/trunk/src/main/java/org/

svn commit: r1697271 - /commons/proper/bcel/trunk/src/changes/changes.xml

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 22:36:37 2015 New Revision: 1697271 URL: http://svn.apache.org/r1697271 Log: BCEL-245 Type class includes constants that reference subclasses Modified: commons/proper/bcel/trunk/src/changes/changes.xml Modified: commons/proper/bcel/trunk/src/changes/changes.xml

svn commit: r1697270 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ util/

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:34:57 2015 New Revision: 1697270 URL: http://svn.apache.org/r1697270 Log: avoid possible NPEs in toStrings, and simplify Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ArrayElementValue.java commons/proper/bcel/t

svn propchange: r1697218 - svn:log

2015-08-23 Thread sebb
Author: sebb Revision: 1697218 Modified property: svn:log Modified: svn:log at Sun Aug 23 22:32:58 2015 -- --- svn:log (original) +++ svn:log Sun Aug 23 22:32:58 2015 @@ -1 +1 @@ -FindBugs: class may not have been construc

svn commit: r1697269 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:28:37 2015 New Revision: 1697269 URL: http://svn.apache.org/r1697269 Log: use stringbuilders right Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java Modified: commons/proper/bcel/trunk/src/main/java/org/ap

svn commit: r1697268 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/Class2HTML.java

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:25:22 2015 New Revision: 1697268 URL: http://svn.apache.org/r1697268 Log: use a static set for base types, for more readable code Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/Class2HTML.java Modified: commons/proper/bc

svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/

2015-08-23 Thread dbrosius
Author: dbrosius Date: Sun Aug 23 22:19:04 2015 New Revision: 1697267 URL: http://svn.apache.org/r1697267 Log: remove the need for casting at the clone() call site Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Attribute.java commons/proper/bcel/tru

svn commit: r1697260 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic: BranchInstruction.java GOTO.java JSR.java Select.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 21:10:54 2015 New Revision: 1697260 URL: http://svn.apache.org/r1697260 Log: setGetPosition was a bad idea; use separate get/set methods Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchInstruction.java commons/proper

svn commit: r1697258 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 21:08:51 2015 New Revision: 1697258 URL: http://svn.apache.org/r1697258 Log: Document Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel

svn commit: r1697254 - in /commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/generic: BranchHandleTestCase.java InstructionHandleTestCase.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 20:58:41 2015 New Revision: 1697254 URL: http://svn.apache.org/r1697254 Log: Start some tests for InstructionHandle/BranchHandle Added: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/generic/BranchHandleTestCase.java (with props) common

svn commit: r1697224 - in /commons/proper/bcel/trunk/src: changes/changes.xml main/java/org/apache/commons/bcel6/verifier/structurals/ControlFlowGraph.java main/java/org/apache/commons/bcel6/verifier/

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 16:52:06 2015 New Revision: 1697224 URL: http://svn.apache.org/r1697224 Log: BCEL-253 Pass 3b verifier is too strict. Modified: commons/proper/bcel/trunk/src/changes/changes.xml commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/struct

svn commit: r1697222 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/structurals/Subroutines.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 16:49:19 2015 New Revision: 1697222 URL: http://svn.apache.org/r1697222 Log: Use enum instead of dummy Integer values (effectively they were being used as an enum) Avoids Findbugs warning about comparing Integer with == Modified: commons/proper/bcel/trunk/src/m

svn commit: r1697220 - /commons/proper/bcel/trunk/findbugs-exclude-filter.xml

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 16:40:25 2015 New Revision: 1697220 URL: http://svn.apache.org/r1697220 Log: Suppress some more Findbugs reports Modified: commons/proper/bcel/trunk/findbugs-exclude-filter.xml Modified: commons/proper/bcel/trunk/findbugs-exclude-filter.xml URL: http://svn.apac

svn commit: r1697218 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/Type.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 16:39:33 2015 New Revision: 1697218 URL: http://svn.apache.org/r1697218 Log: FindBugs: class may not have been constructed warning when using getInstance Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/Type.java Modified: com

svn commit: r1697209 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 16:09:31 2015 New Revision: 1697209 URL: http://svn.apache.org/r1697209 Log: FindBUgs: Check return of mkdirs() Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java Modified: commons/proper/bcel/trunk/src/main/jav

svn commit: r1697208 - /commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/util/Class2HTMLTestCase.java

2015-08-23 Thread sebb
Author: sebb Date: Sun Aug 23 16:07:23 2015 New Revision: 1697208 URL: http://svn.apache.org/r1697208 Log: FindBUgs: Check return of mkdirs() Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/util/Class2HTMLTestCase.java Modified: commons/proper/bcel/trunk/src/test