Re: [PR] CAMEL-21847 Implemented try-with-resources for HttpClient. [camel]

2025-03-07 Thread via GitHub
davsclaus commented on PR #17373: URL: https://github.com/apache/camel/pull/17373#issuecomment-2707265168 okay here is a fix as the http client should only be closed when the oauth is no longer in use, when the endpoint is stopped https://github.com/apache/camel/commit/1662b2c5cf90e21dac

Re: [PR] CAMEL-21847 Implemented try-with-resources for HttpClient. [camel]

2025-03-07 Thread via GitHub
davsclaus closed pull request #17373: CAMEL-21847 Implemented try-with-resources for HttpClient. URL: https://github.com/apache/camel/pull/17373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] CAMEL-21847 Implemented try-with-resources for HttpClient. [camel]

2025-03-06 Thread via GitHub
dk2k commented on PR #17373: URL: https://github.com/apache/camel/pull/17373#issuecomment-2704865668 @davsclaus I don't get it. It's a local variable, it's life cycle ends once you exit method configureHttpClient() When it's used in any call within this method, nothing changes. The scope

Re: [PR] CAMEL-21847 Implemented try-with-resources for HttpClient. [camel]

2025-03-06 Thread via GitHub
github-actions[bot] commented on PR #17373: URL: https://github.com/apache/camel/pull/17373#issuecomment-2704626700 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer