spatnity commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1824102970
Thanks for the feedback @aldettinger , I will fix them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aldettinger merged PR #180:
URL: https://github.com/apache/camel-quarkus-examples/pull/180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
spatnity commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1823219771
Done! thanks @jamesnetherton
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jamesnetherton commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1821023830
Since there's no Docker on the Windows CI runner, you'll need to add a Maven
profile like this:
https://github.com/apache/camel-quarkus-examples/blob/main/jpa-
aldettinger commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1820588678
Well done :+1: Totally forgot about that one. The build looks in good shape
let's see.
--
This is an automated message from the Apache Git Service.
To respond to the
spatnity commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1820581636
I have run `mvn org.l2x6.cq:cq-maven-plugin:0.33.0:update-examples-json`
from the project root directory which automatically updated `examples.json`
--
This is an automa
aldettinger commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1820567496
@spatnity Yes, it could be that. Did you needed to update the json file
manually ? Or were you able to use a command ?
--
This is an automated message from the Apache
jamesnetherton commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1820367159
You don't need to run `update-examples-json` locally. But you need to ensue
that there's an entry for the new project added to
[docs/modules/ROOT/attachments/examples
spatnity commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1820352155
After running this maven goal
`org.l2x6.cq:cq-maven-plugin:0.33.0:update-examples-json`, there is a
`examples.json` file that is getting created (Untracked) which has nothi
spatnity commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1820320805
Yeah `README.adoc` syntax used is different compared to others.I will update
it
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
aldettinger commented on PR #180:
URL:
https://github.com/apache/camel-quarkus-examples/pull/180#issuecomment-1819835277
@spatnity
The error message from ci build is:
```
Failed to execute goal
org.l2x6.cq:cq-maven-plugin:0.33.0:update-examples-json (default-cli) on
proje
spatnity closed pull request #179: Add multiple datasources to Jdbc example
URL: https://github.com/apache/camel-quarkus-examples/pull/179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
aldettinger commented on PR #179:
URL:
https://github.com/apache/camel-quarkus-examples/pull/179#issuecomment-1814332228
@spatnity , probably it can rebased now, something like:
```
git pull --rebase
```
Execute README instructions to check everything is still fine.
spatnity commented on PR #179:
URL:
https://github.com/apache/camel-quarkus-examples/pull/179#issuecomment-1814224357
> Maybe we'll wait the 3.6.0.CR1
[pr](https://github.com/apache/camel-quarkus-examples/pull/178) to be merged
before merging this one.
Yeah sure!
--
This is a
aldettinger commented on PR #179:
URL:
https://github.com/apache/camel-quarkus-examples/pull/179#issuecomment-1814209087
Maybe we'll wait the 3.6.0.CR1
[pr](https://github.com/apache/camel-quarkus-examples/pull/178) to be merged
before merging this one.
--
This is an automated message f
15 matches
Mail list logo
