davsclaus closed pull request #12386: only extract the
ClassPathXmlApplicationContext once
URL: https://github.com/apache/camel/pull/12386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
davsclaus commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1935875115
Sorry closing old PRs - the camel-spring-xml should ideally be built before
the test modules. And its fine for us as is.
--
This is an automated message from the Apache Git Service.
T
TestBoost commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1857601821
Thank you so much!
I tried to extend `org.apache.camel.spring.SpringTestSupport` instead but I
found `getMandatoryBean(Class type, String name)` actually calls
`applicationContex
klease commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1856179600
Most of the tests in camel-spring-xml extend
`org.apache.camel.spring.SpringTestSupport`. That also provides the method
`getMandatoryBean(Class type, String name)` which would allow to sim
TestBoost commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1852821895
Thank you so much. I try to search in the test codes in camel-spring-xml and
only find this test look like this as of now. However, there are indeed some
tests like `ParentContextRegist
davsclaus commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1852358361
Did you notice that this was the only test that did this, or did you find
others in camel-spring-xml
--
This is an automated message from the Apache Git Service.
To respond to the me
TestBoost commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1849455576
Oh, I see and I did not notice this. So do we just extend
`SpringTestSupport` rather than `CamelSpringTestSupport`? And it seems
`SpringTestSupport` does not have the same way to check
davsclaus commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1849433564
Oh we cannot depend on `camel-test-spring-junit5` as its a chicken and egg
situation. As camel-spring-xml is a dependency on the test module, so you end
up with circular dependency.
-
TestBoost commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1849426344
Thank you for the response. And I indeed find in the
`CamelSpringTestSupport`, there is a place to only read the `context` once
under certain conditions. I just refactored as you said b
davsclaus commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1849367972
Thanks, the test should really extend CamelSpringTestSupport and be
something like
```
public class ErrorHandlerDefinitionParserTest extends SpringTestSupport {
@Ove
github-actions[bot] commented on PR #12386:
URL: https://github.com/apache/camel/pull/12386#issuecomment-1848784775
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committer
TestBoost opened a new pull request, #12386:
URL: https://github.com/apache/camel/pull/12386
# Description
This pull request is to make sure only extract the `ctx` once from the xml
file `org/apache/camel/spring/xml/handler/ErrorHandlerDefinitionParser.xml`.
There are four tests
12 matches
Mail list logo
