Re: [PR] feat: setting span statusCode based on error indicator [camel]

2025-06-11 Thread via GitHub
squakez merged PR #18335: URL: https://github.com/apache/camel/pull/18335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apac

Re: [PR] feat: setting span statusCode based on error indicator [camel]

2025-06-11 Thread via GitHub
squakez commented on PR #18335: URL: https://github.com/apache/camel/pull/18335#issuecomment-2961833581 > @squakez any feedback ? I am back from PTO. I'll have a look during the day. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] feat: setting span statusCode based on error indicator [camel]

2025-06-11 Thread via GitHub
davsclaus commented on PR #18335: URL: https://github.com/apache/camel/pull/18335#issuecomment-2961697863 @squakez any feedback ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] feat: setting span statusCode based on error indicator [camel]

2025-06-10 Thread via GitHub
lsergio commented on PR #18335: URL: https://github.com/apache/camel/pull/18335#issuecomment-2960201327 @davsclaus yes, both camel-opentelemetry and camel-opentelemetry2 tests are passing with this change. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] feat: setting span statusCode based on error indicator [camel]

2025-06-10 Thread via GitHub
davsclaus commented on PR #18335: URL: https://github.com/apache/camel/pull/18335#issuecomment-2960161743 Does all the tests of camel-opentelemtry pass with this code change ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] feat: setting span statusCode based on error indicator [camel]

2025-06-10 Thread via GitHub
lsergio commented on PR #18335: URL: https://github.com/apache/camel/pull/18335#issuecomment-2959893852 I have [this thread](https://camel.zulipchat.com/#narrow/channel/257298-camel/topic/OpenTelemetry.20span.20status.20not.20being.20set/with/523324775) on zulip chat that has to do with thi

Re: [PR] feat: setting span statusCode based on error indicator [camel]

2025-06-10 Thread via GitHub
github-actions[bot] commented on PR #18335: URL: https://github.com/apache/camel/pull/18335#issuecomment-2959814820 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

[PR] feat: setting span statusCode based on error indicator [camel]

2025-06-10 Thread via GitHub
lsergio opened a new pull request, #18335: URL: https://github.com/apache/camel/pull/18335 # Description This pull requests changes the OpenTelemetrySpanAdapter so that it sets the span status code to either OK or ERROR on the setError method. # Target - [ ] I checked th