Re: [PR] camel-solr 9.6.1 [camel]

2024-07-19 Thread via GitHub
oscerd commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2238572644 No ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-19 Thread via GitHub
orpiske commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2238571280 BTW, do we have a ticket for this? It may be beneficial to track this on a Jira ticket, so that it is listed on the release, trackable, etc ... if there's no ticket, I can create one.

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-19 Thread via GitHub
vdomrachev commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2238588144 May be you can reopen and update https://issues.apache.org/jira/browse/CAMEL-18577 ? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-19 Thread via GitHub
oscerd commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2238496670 Thanks for this, I'm going to merge this, probably beginning of the next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-19 Thread via GitHub
orpiske commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2238590192 > May be you can reopen and update https://issues.apache.org/jira/browse/CAMEL-18577 ? No. That is already resolved. I created https://issues.apache.org/jira/browse/CAMEL-20

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2237648025 Unfortunately, it looks like we have to wait for https://issues.apache.org/jira/browse/SOLR-17069 to make this PR work in camel 4.8.x . My working build of my project with updated came

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682886851 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrClientHandlerConcurrentUpdate.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Sof

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682805266 ## test-infra/camel-test-infra-solr/src/test/java/org/apache/camel/test/infra/solr/services/SolrLocalContainerService.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to t

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682757294 ## components/camel-solr/src/test/resources/solr/collection1/conf/solrconfig.xml: ## @@ -0,0 +1,1818 @@ + + + + + + + + LATEST + + + + + + ${solr.data.

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682691085 ## components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateTest.java: ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682680701 ## components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrCloudFixture.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682679571 ## components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrCloudFixture.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682676592 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrProducer.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682670613 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrClientHandlerCloud.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682670274 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrProducer.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682659624 ## test-infra/camel-test-infra-solr/src/test/java/org/apache/camel/test/infra/solr/services/SolrLocalContainerService.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682657895 ## components/camel-solr/src/test/resources/solr/collection1/conf/solrconfig.xml: ## @@ -0,0 +1,1818 @@ + + + + + + + + LATEST + + + + + + ${solr.data.dir

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682653859 ## components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrCloudFixture.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682655428 ## components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateTest.java: ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682653445 ## components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrCloudFixture.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682650246 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrProducer.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682649238 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrProducer.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682647037 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrProducer.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682638117 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrConfiguration.java: ## @@ -0,0 +1,389 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682635298 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrClientHandlerConcurrentUpdate.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
orpiske commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682631949 ## components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrClientHandlerCloud.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
oscerd commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2236165619 Looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2236043774 Ok.Started full build. Should i commit all generated and not gitignored changed files? And should i remove added components/camel-solr/.gitignore file with "src/generated" and then com

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
oscerd commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2236025242 You need to fully build the project because there are missing metadata, they will be generated once you full build. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2236022137 Should i do something with failing checks? (PR Build (Camel 4) / build (17, false) (pull_request) Failing after 10m) -- This is an automated message from the Apache Git Service. To r

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
oscerd commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2235983153 LGTM and we can eventually re-iterate. Let's wait for @orpiske and other to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682465688 ## components/camel-solr/pom.xml: ## @@ -0,0 +1,180 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLo

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
oscerd commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682451378 ## components/camel-solr/pom.xml: ## @@ -0,0 +1,180 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocati

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682422596 ## components/camel-solr/src/test/java/org/apache/camel/component/solr/JettySolrFactory.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682421241 ## components/camel-solr/src/main/docs/solr-component.adoc: ## @@ -0,0 +1,170 @@ += Solr Component +:doctitle: Solr +:shortname: solr +:artifactid: camel-solr +:desc

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682419962 ## components/camel-solr/pom.xml: ## @@ -0,0 +1,180 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLo

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682419720 ## components/camel-solr/pom.xml: ## @@ -0,0 +1,180 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLo

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
vdomrachev commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682419356 ## components/camel-solr/pom.xml: ## @@ -0,0 +1,180 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLo

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-18 Thread via GitHub
oscerd commented on code in PR #14865: URL: https://github.com/apache/camel/pull/14865#discussion_r1682317444 ## components/camel-solr/pom.xml: ## @@ -0,0 +1,180 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocati

Re: [PR] camel-solr 9.6.1 [camel]

2024-07-17 Thread via GitHub
github-actions[bot] commented on PR #14865: URL: https://github.com/apache/camel/pull/14865#issuecomment-2234715160 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

[PR] camel-solr 9.6.1 [camel]

2024-07-17 Thread via GitHub
vdomrachev opened a new pull request, #14865: URL: https://github.com/apache/camel/pull/14865 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e