Re: [PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-23 Thread via GitHub
squakez merged PR #97: URL: https://github.com/apache/camel-k-examples/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel

Re: [PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-23 Thread via GitHub
tdiesler commented on PR #97: URL: https://github.com/apache/camel-k-examples/pull/97#issuecomment-2127239146 This is ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-23 Thread via GitHub
tdiesler commented on PR #97: URL: https://github.com/apache/camel-k-examples/pull/97#issuecomment-2126956717 I now migrated and restored all `config/resource-file-xyz` examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-23 Thread via GitHub
squakez commented on PR #97: URL: https://github.com/apache/camel-k-examples/pull/97#issuecomment-2126419663 > This [commit](https://github.com/apache/camel-k/commit/7ee129afcd7ee53b4f25f5dab1ecc55689b1f2cd) removes `resource-file-xyz.groovy` route definitions without providing yaml equiva

Re: [PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-22 Thread via GitHub
tdiesler commented on PR #97: URL: https://github.com/apache/camel-k-examples/pull/97#issuecomment-2126269749 This [commit](https://github.com/apache/camel-k/commit/7ee129afcd7ee53b4f25f5dab1ecc55689b1f2cd) removes `resource-file-xyz.groovy` route definitions without providing yaml equival

Re: [PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-22 Thread via GitHub
tdiesler commented on code in PR #97: URL: https://github.com/apache/camel-k-examples/pull/97#discussion_r1610244544 ## .vscode/extensions.json: ## @@ -1,6 +0,0 @@ -{ - "recommendations": [ -"redhat.vscode-didact", -"redhat.apache-camel-extension-pack" Review Comment:

Re: [PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-22 Thread via GitHub
tdiesler commented on PR #97: URL: https://github.com/apache/camel-k-examples/pull/97#issuecomment-2125132330 > I think you forgot to swith `resource-file-xyz` examples. You've also removing `resources-data` files which were used by those examples. I removed it because I thought it wa

Re: [PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-22 Thread via GitHub
apupier commented on code in PR #97: URL: https://github.com/apache/camel-k-examples/pull/97#discussion_r1609810599 ## .vscode/extensions.json: ## @@ -1,6 +0,0 @@ -{ - "recommendations": [ -"redhat.vscode-didact", -"redhat.apache-camel-extension-pack" Review Comment:

[PR] Remove usage of deprecated VS Code Didact [camel-k-examples]

2024-05-22 Thread via GitHub
tdiesler opened a new pull request, #97: URL: https://github.com/apache/camel-k-examples/pull/97 Update generic languages, env, cron -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c