Re: [PR] OpenTelemetry testing improvements [camel]

orpiske commented on PR #15182: URL: https://github.com/apache/camel/pull/15182#issuecomment-2301579813 I'm seeing a couple of failures in the `camel-opentelemetry`. We might need to fix this or rollback the changes. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] OpenTelemetry testing improvements [camel]

davsclaus commented on PR #15182: URL: https://github.com/apache/camel/pull/15182#issuecomment-2300851934 We need to do something about double closing 2024-08-21 06:24:25,911 [Pool-2-worker-1] ERROR ActiveSpanManager - Tracing: scope already closed: io.opentelemetry.cont

Re: [PR] OpenTelemetry testing improvements [camel]

davsclaus merged PR #15182: URL: https://github.com/apache/camel/pull/15182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.ap

Re: [PR] OpenTelemetry testing improvements [camel]

davsclaus commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r172268 ## components/camel-opentelemetry/src/test/resources/log4j2.properties: ## Review Comment: Yes we must keep the existing log4j properties that is what we use

Re: [PR] OpenTelemetry testing improvements [camel]

orpiske commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721982795 ## components/camel-opentelemetry/src/test/resources/log4j2.properties: ## Review Comment: Hi, why does it delete this file and replaces it with an XML one? They s

Re: [PR] OpenTelemetry testing improvements [camel]

ammachado commented on PR #15182: URL: https://github.com/apache/camel/pull/15182#issuecomment-2296642332 Thanks @davsclaus for the help. The tests are fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] OpenTelemetry testing improvements [camel]

davsclaus commented on PR #15182: URL: https://github.com/apache/camel/pull/15182#issuecomment-2295781477 This PR on CI reports test failures such as Failed Test | Duration | Failure Type -- | -- | -- org.apache.camel.opentelemetry.ClientRecipientListRouteTest.testRoute | 5.

Re: [PR] OpenTelemetry testing improvements [camel]

ammachado commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721218020 ## parent/pom.xml: ## @@ -388,6 +388,8 @@ 2.1.0 3.12 1.41.0 + 2.7.0-alpha Review Comment: All versions available for these com

Re: [PR] OpenTelemetry testing improvements [camel]

ammachado commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721218020 ## parent/pom.xml: ## @@ -388,6 +388,8 @@ 2.1.0 3.12 1.41.0 + 2.7.0-alpha Review Comment: All versions available for this comp

Re: [PR] OpenTelemetry testing improvements [camel]

ammachado commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721218020 ## parent/pom.xml: ## @@ -388,6 +388,8 @@ 2.1.0 3.12 1.41.0 + 2.7.0-alpha Review Comment: All versions available for these com

Re: [PR] OpenTelemetry testing improvements [camel]

davsclaus commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721221567 ## parent/pom.xml: ## @@ -388,6 +388,8 @@ 2.1.0 3.12 1.41.0 + 2.7.0-alpha Review Comment: okay are they released regulay ie ho

Re: [PR] OpenTelemetry testing improvements [camel]

ammachado commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721220675 ## core/camel-api/src/main/java/org/apache/camel/ExchangePropertyKey.java: ## @@ -23,6 +23,7 @@ */ public enum ExchangePropertyKey { +ACTIVE_SPAN("OpenTracin

Re: [PR] OpenTelemetry testing improvements [camel]

davsclaus commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721216284 ## parent/pom.xml: ## @@ -388,6 +388,8 @@ 2.1.0 3.12 1.41.0 + 2.7.0-alpha Review Comment: Hmm this is alpha software so we may

Re: [PR] OpenTelemetry testing improvements [camel]

ammachado commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721218020 ## parent/pom.xml: ## @@ -388,6 +388,8 @@ 2.1.0 3.12 1.41.0 + 2.7.0-alpha Review Comment: All versions available for this comp

Re: [PR] OpenTelemetry testing improvements [camel]

davsclaus commented on code in PR #15182: URL: https://github.com/apache/camel/pull/15182#discussion_r1721216284 ## parent/pom.xml: ## @@ -388,6 +388,8 @@ 2.1.0 3.12 1.41.0 + 2.7.0-alpha Review Comment: Hmm this is alpha software so we may

Re: [PR] OpenTelemetry testing improvements [camel]

davsclaus commented on PR #15182: URL: https://github.com/apache/camel/pull/15182#issuecomment-2295670391 When you work on PRs in the future can you avoid doing code changes in the same PRs that change comments, coding standard etc in other codes. The PRs should be easier to review and ensu

Re: [PR] OpenTelemetry testing improvements [camel]

github-actions[bot] commented on PR #15182: URL: https://github.com/apache/camel/pull/15182#issuecomment-2295499754 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

[PR] OpenTelemetry testing improvements [camel]

ammachado opened a new pull request, #15182: URL: https://github.com/apache/camel/pull/15182 # Description This PR adds leaking spans detection, OTEL log reporting and prints a tree with the generated traces from the test run to help identify issues in user code. # Target