Re: [PR] Officially add Splunk HEC URL and token as query parameters [camel]

davsclaus commented on PR #13041: URL: https://github.com/apache/camel/pull/13041#issuecomment-1933572216 @Nephery if you want to work more on splunk then we have this ticket https://issues.apache.org/jira/browse/CAMEL-20393 -- This is an automated message from the Apache Git Service. T

Re: [PR] Officially add Splunk HEC URL and token as query parameters [camel]

davsclaus merged PR #13041: URL: https://github.com/apache/camel/pull/13041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.ap

Re: [PR] Officially add Splunk HEC URL and token as query parameters [camel]

oscerd commented on PR #13041: URL: https://github.com/apache/camel/pull/13041#issuecomment-1932829389 LGTM, if you have time it would be nice to have an example of usage of the component in camel-examples, camel-spring-boot-examples or camel-quarkus-examples. Let's wait for more reviews :-

Re: [PR] Officially add Splunk HEC URL and token as query parameters [camel]

Nephery commented on PR #13041: URL: https://github.com/apache/camel/pull/13041#issuecomment-1932801270 > In my opinion it doesn't make sense to have both the parameters as path and query. I would leave just the url as path and add the token as mandatory query parameter. The proposed soluti

Re: [PR] Officially add Splunk HEC URL and token as query parameters [camel]

Nephery commented on PR #13041: URL: https://github.com/apache/camel/pull/13041#issuecomment-1932587593 Okay, sounds good. In that case, I'll update the PR to do what you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Officially add Splunk HEC URL and token as query parameters [camel]

oscerd commented on PR #13041: URL: https://github.com/apache/camel/pull/13041#issuecomment-1932585072 Camel is too big to follow semantic versioning. We usually allow breaking changes between minor versions. When we release an LTS all the patch releases will avoid breaking changes -- Th

Re: [PR] Officially add Splunk HEC URL and token as query parameters [camel]

Nephery commented on PR #13041: URL: https://github.com/apache/camel/pull/13041#issuecomment-1932581930 @oscerd wouldn't that be breaking backwards compatibility for a minor version upgrade? Or is that okay in Camel? From a simplicity & code perspective, I agree that your suggestion w

Re: [PR] Officially add Splunk HEC URL and token as query parameters [camel]

github-actions[bot] commented on PR #13041: URL: https://github.com/apache/camel/pull/13041#issuecomment-1932521517 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

[PR] Officially add Splunk HEC URL and token as query parameters [camel]

Nephery opened a new pull request, #13041: URL: https://github.com/apache/camel/pull/13041 # Description Make providing `splunkURL` and `token` through query parameters an officially documented feature of the Splunk HEC component. **Background** The current method (i.e.