davsclaus merged PR #14768:
URL: https://github.com/apache/camel/pull/14768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.ap
davsclaus commented on PR #14768:
URL: https://github.com/apache/camel/pull/14768#issuecomment-2219737159
> > > I've left some suggestions. I think this is adding a lot of complexity
to a component that is already very complex. IMHO, a decorator would be able to
isolate that complexity and
davsclaus commented on code in PR #14768:
URL: https://github.com/apache/camel/pull/14768#discussion_r1671735359
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##
@@ -343,6 +371,30 @@ protected void startPolling() {
orpiske commented on PR #14768:
URL: https://github.com/apache/camel/pull/14768#issuecomment-2219661097
> > I've left some suggestions. I think this is adding a lot of complexity
to a component that is already very complex. IMHO, a decorator would be able to
isolate that complexity and redu
orpiske commented on code in PR #14768:
URL: https://github.com/apache/camel/pull/14768#discussion_r1671678632
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##
@@ -343,6 +371,30 @@ protected void startPolling() {
fi
orpiske commented on code in PR #14768:
URL: https://github.com/apache/camel/pull/14768#discussion_r1671674901
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##
@@ -343,6 +371,30 @@ protected void startPolling() {
fi
orpiske commented on code in PR #14768:
URL: https://github.com/apache/camel/pull/14768#discussion_r1671674901
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##
@@ -343,6 +371,30 @@ protected void startPolling() {
fi
davsclaus commented on PR #14768:
URL: https://github.com/apache/camel/pull/14768#issuecomment-2219629075
> I've left some suggestions. I think this is adding a lot of complexity to
a component that is already very complex. IMHO, a decorator would be able to
isolate that complexity and redu
davsclaus commented on code in PR #14768:
URL: https://github.com/apache/camel/pull/14768#discussion_r1671660004
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##
@@ -343,6 +371,30 @@ protected void startPolling() {
davsclaus commented on code in PR #14768:
URL: https://github.com/apache/camel/pull/14768#discussion_r1671659607
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaDevConsole.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation
orpiske commented on code in PR #14768:
URL: https://github.com/apache/camel/pull/14768#discussion_r1671653582
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##
@@ -343,6 +371,30 @@ protected void startPolling() {
fi
github-actions[bot] commented on PR #14768:
URL: https://github.com/apache/camel/pull/14768#issuecomment-2217966293
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committer
davsclaus opened a new pull request, #14768:
URL: https://github.com/apache/camel/pull/14768
# Description
# Target
- [ ] I checked that the commit is targeting the correct branch (note that
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Trac
13 matches
Mail list logo
