Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-30 Thread via GitHub
ppalaga merged PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
aldettinger commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507653275 IMHO it seems fair enough to add those properties, anyone building with a non US default locale should have tests working. Otherwise we could try format the date indepen

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
zhfeng commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507582646 Now the native test works with adding the following configurations: ``` quarkus.native.user-country=US quarkus.native.user-language=en ``` -- This is an auto

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
aldettinger commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507508408 Aha, 2 problems are better than 1 :) "Jul" it looks like, short month notation, strange. Not sure, it's related but maybe it could be tried to play with quar

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
ppalaga commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507498405 IIRC somebody mentioned some locale related changes in GraalVM on X. Not sure at all, what kind of they were... -- This is an automated message from the Apache Git Service

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
zhfeng commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507464416 Hmm, but in native build, it is failing ``` [ERROR] Failures: [ERROR] RouteIT>RouteTest.unstructuredFileTranscriptsAreTransformedToPojos:70 1 expectation failed.

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
zhfeng commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507458381 @aldettinger @ppalaga OK, it works with using `en_US` in String.format -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
zhfeng commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507443062 Yeah, I will try `String.format`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
aldettinger commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507406214 It smells non localized [String.format](https://github.com/apache/camel-quarkus-examples/blob/main/data-extract-langchain4j/src/main/java/org/acme/extraction/CustomPojoEx

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
ppalaga commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507387529 @zhfeng sounds like it fails for you in JVM mode on a machine where the default locale is non-english, right? (I just wonder whether it has to do with some recent changes in

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
zhfeng commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507381508 Well, it's just failing with the test like ``` ERROR] Failures: [ERROR] RouteTest.unstructuredFileTranscriptsAreTransformedToPojos:70 1 expectation failed. JSON

Re: [PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-29 Thread via GitHub
aldettinger commented on PR #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313#issuecomment-2507325353 Interesting, do we by any chance remind what kind of issue it generate when we don't force english locale please ? -- This is an automated message from the Apache Git

[PR] Explicitly set locale with en_US [camel-quarkus-examples]

2024-11-28 Thread via GitHub
zhfeng opened a new pull request, #313: URL: https://github.com/apache/camel-quarkus-examples/pull/313 Note that the `main` branch points at the latest stable Camel Quarkus release. Pull requests should be generally send against the `camel-quarkus-main` branch pointing at the current Cam